Vasiliy Telezhnikov (Gerrit)

unread,

May 1, 2026, 4:16:30 PMMay 1

to Geoff Lang, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Eugene Zemtsov and Geoff Lang

Vasiliy Telezhnikov added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Vasiliy Telezhnikov . resolved

Please, take a look.

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov
Geoff Lang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eugene Zemtsov (Gerrit)

unread,

May 1, 2026, 5:06:35 PMMay 1

to Vasiliy Telezhnikov, Eugene Zemtsov, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Geoff Lang and Vasiliy Telezhnikov

Eugene Zemtsov voted and added 1 comment

Votes added by Eugene Zemtsov

Code-Review

+1

1 comment

File ui/gl/gl_surface_egl.cc

Line 136, Patchset 3 (Latest): static bool is_emulator = []() {

Eugene Zemtsov . unresolved

I don't think we need this lambda. `static bool is_emulator` will be initialized only once anyway.

Open in Gerrit

Related details

Attention is currently required from:

Geoff Lang
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Geoff Lang (Gerrit)

unread,

May 1, 2026, 5:19:57 PMMay 1

to Vasiliy Telezhnikov, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Vasiliy Telezhnikov

Geoff Lang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vasiliy Telezhnikov (Gerrit)

unread,

May 1, 2026, 6:37:00 PMMay 1

to Geoff Lang, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Vasiliy Telezhnikov . resolved

Thanks for the reviews!

File ui/gl/gl_surface_egl.cc

Line 136, Patchset 3: static bool is_emulator = []() {

Eugene Zemtsov . resolved

I don't think we need this lambda. `static bool is_emulator` will be initialized only once anyway.

Vasiliy Telezhnikov

Oh, you're right. Not sure why I decided that lambda is needed here. Removed.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 1, 2026, 8:41:19 PMMay 1

to Vasiliy Telezhnikov, Geoff Lang, Eugene Zemtsov, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/gl/gl_surface_egl.cc
Insertions: 3, Deletions: 4.

@@ -133,10 +133,9 @@
 
 bool IsAndroidEmulator() {
 #if BUILDFLAG(IS_ANDROID)
-  static bool is_emulator = []() {
-    return base::SysInfo::GetAndroidHardwareEGL() == "swiftshader" ||
-           base::SysInfo::GetAndroidHardwareEGL() == "emulation";
-  }();
+  static bool is_emulator =
+      base::SysInfo::GetAndroidHardwareEGL() == "swiftshader" ||
+      base::SysInfo::GetAndroidHardwareEGL() == "emulation";
   return is_emulator;
 #else
   return false;
```

Change information

Commit message:

Fix media tests on angle / android emulator

Android emulator's swiftshader doesn't support RECORDABLE, it was added
to the later version of the swift shader.

It always returns config without recordable set. While we don't
validate it in chromium, angle is more strict and fails to find
appropriate config.

NDK encoder unit tests pass with this change.

Change-Id: I9c7fe3b67cf7406f751291e2539037dc26f24167

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7810415

Reviewed-by: Eugene Zemtsov <eug...@chromium.org>

Reviewed-by: Geoff Lang <geof...@chromium.org>

Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1624191}

Files:

M ui/gl/gl_surface_egl.cc

Change size: S

Delta: 1 file changed, 15 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Geoff Lang, +1 by Eugene Zemtsov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix media tests on angle / android emulator [chromium/src : main]

Vasiliy Telezhnikov (Gerrit)

Vasiliy Telezhnikov added 1 comment

Related details

Eugene Zemtsov (Gerrit)

Eugene Zemtsov voted and added 1 comment

Votes added by Eugene Zemtsov

1 comment

Related details

Geoff Lang (Gerrit)

Geoff Lang voted Code-Review+1

Related details

Vasiliy Telezhnikov (Gerrit)

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information