Revert "Reland "Sanitize cursor theme name and size in GTK and Wayland"" [chromium/src : main]

0 views

Skip to first unread message

Chromium LUCI CQ (Gerrit)

unread,

Aug 10, 2026, 11:51:42 AM (3 days ago) Aug 10

to Zonghan Xu, rubber-...@appspot.gserviceaccount.com, Yichen Zhou, Thomas Anderson, android-bu...@system.gserviceaccount.com, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "Reland "Sanitize cursor theme name and size in GTK and Wayland""

This reverts commit 91a2334cbf479f688cc421aa7f7eb1802e8e2bfb.

Reason for revert: CursorThemeSizesSanitizedAtWriteTime seems to be failing on multiple Linux builders

Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/133036/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/17465/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/32576/overview

Original change's description:
> Reland "Sanitize cursor theme name and size in GTK and Wayland"
>
> This is a reland of commit 283ac1ef12df16eb0256a4d5ce83477b5afba061
>
> Original change's description:
> > Sanitize cursor theme name and size in GTK and Wayland
> >
> > This change extends GtkSettingsSetProperty interceptor and GtkUi to
> > sanitize gtk-cursor-theme-name and gtk-cursor-theme-size at write-time,
> > preventing unsanitized cursor theme names from being set in GTK
> > settings.
> >
> > It also introduces unified ui::IsValidCursorThemeName and
> > ui::IsValidCursorThemeSize validation helpers in //ui/base/cursor, and
> > adds validation to WaylandCursorFactory to ensure invalid or
> > path-traversing cursor theme names are rejected before calling
> > wl_cursor_theme_load.
> >
> > Change-Id: Ibe8a3ce208d76d2e724902424491a6116d4352f6
> > Fixed: 540289900
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8164559
> > Reviewed-by: Yichen Zhou <yic...@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1670761}
>
> Bug: 542165218
> Fixed: 540289900
> Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8180111
> Reviewed-by: Yichen Zhou <yic...@chromium.org>
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1673803}