Prepare to remove base::JSONReader::Read's parsing option default [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:41:25 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f9df53cf6e8a0be95b1bd30b400a12d1bf3ae05
Gerrit-Change-Number: 6992109
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:41:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:41:31 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
Gerrit-Change-Number: 6990986
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:41:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:41:50 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c7299794bfaf82830b28394ced0072d40cf8775
Gerrit-Change-Number: 6990984
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:41:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:41:59 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If218e03839e8ac3a818270fef1c0cf6bac2b6968
Gerrit-Change-Number: 6990983
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:41:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:42:23 PM (8 days ago) Sep 29
to Daniel Cheng, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0ca01fbbd4a889a480e8661d17496f775b5df0d2
Gerrit-Change-Number: 6990985
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:42:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:42:48 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
Gerrit-Change-Number: 6990987
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:42:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:43:01 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icd3ef8b9da4f7cafc7ea8a4335f7e6c26cfde818
Gerrit-Change-Number: 6990988
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:42:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:43:36 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I16da8e1a12a0901ba77807016677f77b407685ca
Gerrit-Change-Number: 6992110
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:43:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:44:13 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f11750a999b1b2707d528d80f6175723f08cfba
Gerrit-Change-Number: 6992111
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:44:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:44:28 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
Gerrit-Change-Number: 6992112
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:44:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 12:44:49 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I832f8c9f0b6fe098905a387a23c1cce203e2ec2f
Gerrit-Change-Number: 6992113
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 16:44:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:00:47 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review+1

1 comment

File services/network/trust_tokens/trust_token_key_commitment_parser_unittest.cc
Line 681, Patchset 1 (Latest): // not valid JSON.
Lei Zhang . unresolved

Format the comment like line 668 / 689.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
Gerrit-Change-Number: 6990987
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 17:00:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:04:09 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
Gerrit-Change-Number: 6990986
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 17:03:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:09:04 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0ca01fbbd4a889a480e8661d17496f775b5df0d2
Gerrit-Change-Number: 6990985
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 17:08:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:14:49 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I16da8e1a12a0901ba77807016677f77b407685ca
Gerrit-Change-Number: 6992110
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 17:14:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:15:20 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f11750a999b1b2707d528d80f6175723f08cfba
Gerrit-Change-Number: 6992111
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 17:14:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 1:15:30 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review+1
Owners-Override+1

1 comment

File chromecast/crash/linux/synchronized_minidump_manager.cc
Line 301, Patchset 1 (Latest): std::optional<base::Value> dump_info = base::JSONReader::Read(line, base::JSON_PARSE_CHROMIUM_EXTENSIONS);
Lei Zhang . unresolved

Wrap.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
    Gerrit-Change-Number: 6992112
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:15:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 29, 2025, 1:25:37 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted

    Code-Review+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If218e03839e8ac3a818270fef1c0cf6bac2b6968
    Gerrit-Change-Number: 6990983
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:25:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 29, 2025, 1:37:41 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c7299794bfaf82830b28394ced0072d40cf8775
    Gerrit-Change-Number: 6990984
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:37:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 29, 2025, 1:40:48 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted

    Code-Review+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd3ef8b9da4f7cafc7ea8a4335f7e6c26cfde818
    Gerrit-Change-Number: 6990988
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:40:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 29, 2025, 1:42:23 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted

    Code-Review+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f9df53cf6e8a0be95b1bd30b400a12d1bf3ae05
    Gerrit-Change-Number: 6992109
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:42:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 29, 2025, 1:43:27 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Daniel Cheng

    Lei Zhang voted

    Code-Review+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I832f8c9f0b6fe098905a387a23c1cce203e2ec2f
    Gerrit-Change-Number: 6992113
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 17:43:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 2:41:09 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c7299794bfaf82830b28394ced0072d40cf8775
    Gerrit-Change-Number: 6990984
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 18:40:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 2:41:16 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
    Gerrit-Change-Number: 6990986
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 18:41:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 2:46:32 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+0

    Commit-Queue+0
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
    Gerrit-Change-Number: 6990986
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 18:46:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 2:46:35 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Mon, 29 Sep 2025 18:46:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 2:49:24 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances in //net included in a typical Linux developer build.
    Bug: 446188265
    Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522380}
    Files:
    • M net/cert/ct_log_response_parser_unittest.cc
    • M net/device_bound_sessions/jwk_utils_unittest.cc
    • M net/device_bound_sessions/session_binding_utils_unittest.cc
    • M net/dns/host_cache_unittest.cc
    • M net/dns/host_resolver_internal_result_unittest.cc
    • M net/dns/public/dns_over_https_server_config_unittest.cc
    • M net/extras/sqlite/sqlite_persistent_reporting_and_nel_store.cc
    • M net/http/http_auth_gssapi_posix_unittest.cc
    • M net/reporting/reporting_header_parser_unittest.cc
    • M net/reporting/reporting_test_util.cc
    Change size: M
    Delta: 10 files changed, 140 insertions(+), 78 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id3e82645a976214d231dc6edb1abf12dfd95825d
    Gerrit-Change-Number: 6990986
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 3:01:31 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f9df53cf6e8a0be95b1bd30b400a12d1bf3ae05
    Gerrit-Change-Number: 6992109
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 19:01:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 3:04:39 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I16da8e1a12a0901ba77807016677f77b407685ca
    Gerrit-Change-Number: 6992110
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 19:04:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 3:05:07 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances included in a typical ChromeOS developer build.
    Bug: 446188265
    Change-Id: I2f9df53cf6e8a0be95b1bd30b400a12d1bf3ae05
    Owners-Override: Lei Zhang <the...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522397}
    Files:
    • M ash/projector/projector_metadata_model_unittest.cc
    • M ash/webui/eche_app_ui/system_info_provider_unittest.cc
    • M ash/webui/os_feedback_ui/backend/help_content_provider_unittest.cc
    • M chrome/browser/ash/app_list/search/omnibox/omnibox_answer_result_unittest.cc
    • M chrome/browser/ash/app_list/search/omnibox/omnibox_util_unittest.cc
    • M chrome/browser/ash/app_mode/fake_cws.cc
    • M chrome/browser/ash/arc/extensions/arc_support_message_host_unittest.cc
    • M chrome/browser/ash/arc/extensions/fake_arc_support.cc
    • M chrome/browser/ash/arc/fileapi/arc_select_files_handler_unittest.cc
    • M chrome/browser/ash/arc/intent_helper/arc_settings_service_browsertest.cc
    • M chrome/browser/ash/arc/policy/arc_policy_bridge_unittest.cc
    • M chrome/browser/ash/arc/survey/arc_survey_service.cc
    • M chrome/browser/ash/arc/tracing/arc_system_stat_collector.cc
    • M chrome/browser/ash/arc/tracing/arc_system_stat_collector_unittest.cc
    • M chrome/browser/ash/arc/tracing/arc_tracing_event_matcher_unittest.cc
    • M chrome/browser/ash/arc/tracing/arc_tracing_model.cc
    • M chrome/browser/ash/arc/tracing/arc_tracing_model_unittest.cc
    • M chrome/browser/ash/file_manager/file_manager_browsertest_base.cc
    • M chrome/browser/ash/file_manager/url_util_unittest.cc
    • M chrome/browser/ash/file_suggest/item_suggest_cache_unittest.cc
    • M chrome/browser/ash/first_party_sets/first_party_sets_policy_initialization_browsertest.cc
    • M chrome/browser/ash/growth/install_web_app_action_unittest.cc
    • M chrome/browser/ash/growth/open_url_action_performer_unittest.cc
    • M chrome/browser/ash/growth/show_notification_action_performer_unittest.cc
    • M chrome/browser/ash/growth/show_nudge_action_performer_unittest.cc
    • M chrome/browser/ash/growth/update_user_pref_action_performer_unittest.cc
    • M chrome/browser/ash/guest_os/guest_id_unittest.cc
    • M chrome/browser/ash/guest_os/guest_os_terminal_unittest.cc
    • M chrome/browser/ash/input_method/editor_switch.cc
    • M chrome/browser/ash/locale/startup_settings_cache.cc
    • M chrome/browser/ash/login/gaia_reauth_token_fetcher.cc
    • M chrome/browser/ash/login/oobe_quick_start/connectivity/account_transfer_client_data_unittest.cc
    • M chrome/browser/ash/login/oobe_quick_start/connectivity/connection_unittest.cc
    • M chrome/browser/ash/login/signin/device_id_browsertest.cc
    • M chrome/browser/ash/net/network_diagnostics/gateway_can_be_pinged_routine.cc
    • M chrome/browser/ash/net/rollback_network_config/fake_rollback_network_config.cc
    • M chrome/browser/ash/net/rollback_network_config/rollback_network_config_unittest.cc
    • M chrome/browser/ash/policy/handlers/configuration_policy_handler_ash_unittest.cc
    • M chrome/browser/ash/power/auto_screen_brightness/model_config_loader_impl.cc
    • M chrome/browser/ash/power/ml/smart_dim/ml_agent_util_unittest.cc
    • M chrome/browser/ash/printing/oauth2/test_authorization_server.cc
    • M chrome/browser/ash/settings/about_flags.cc
    • M chrome/browser/ash/smb_client/smb_service_unittest.cc
    • M chrome/browser/ash/wallpaper_handlers/google_photos_wallpaper_handlers_unittest.cc
    • M chrome/browser/certificate_provider/test_certificate_provider_extension.cc
    • M chrome/browser/enterprise/connectors/connectors_service_unittest.cc
    • M chrome/browser/extensions/api/automation/automation_apitest.cc
    • M chrome/browser/extensions/api/messaging/native_message_echo_host.cc
    • M chrome/browser/extensions/api/printing/printing_api_utils.cc
    • M chrome/browser/nearby_sharing/network_traversal_ice_config_fetcher.cc
    • M chrome/browser/sessions/session_restore_browsertest.cc
    • M chrome/browser/speech/tts_controller_delegate_impl.cc
    • M chrome/browser/support_tool/signin_data_collector_browsertest.cc
    • M chrome/browser/ui/ash/projector/pending_screencast_manager.cc
    • M chrome/browser/ui/webui/ash/settings/pages/a11y/settings_with_tts_preview_handler.cc
    • M chrome/browser/ui/webui/policy/policy_ui_browsertest.cc
    • M chrome/browser/ui/webui/signin/ash/inline_login_dialog_browsertest.cc
    • M chrome/browser/web_applications/preinstalled_web_app_manager_browsertest.cc
    • M chrome/test/base/ash/extension_js_browser_test.cc
    • M chromeos/ash/components/boca/receiver/get_receiver_connection_info_request_unittest.cc
    • M chromeos/ash/components/boca/receiver/update_kiosk_receiver_state_request_unittest.cc
    • M chromeos/ash/components/boca/session_api/update_session_config_request_unittest.cc
    • M chromeos/ash/components/carrier_lock/provisioning_config_fetcher_unittest.cc
    • M chromeos/ash/components/dbus/biod/fake_biod_client.cc
    • M chromeos/ash/components/emoji/emoji_search.cc
    • M chromeos/ash/components/enhanced_network_tts/enhanced_network_tts_test_utils.cc
    • M chromeos/ash/components/enhanced_network_tts/enhanced_network_tts_utils_unittest.cc
    • M chromeos/ash/components/network/onc/onc_translator_shill_to_onc.cc
    • M chromeos/ash/components/policy/external_storage/device_id_unittest.cc
    • M chromeos/ash/components/policy/weekly_time/test_support.cc
    • M chromeos/ash/components/proximity_auth/remote_status_update_unittest.cc
    • M chromeos/ash/components/quick_start/quick_start_message.cc
    • M chromeos/ash/components/tether/message_wrapper.cc
    • M chromeos/ash/services/network_config/cros_network_config_unittest.cc
    • M chromeos/components/onc/onc_parsed_certificates_unittest.cc
    • M chromeos/components/onc/onc_utils_unittest.cc
    • M chromeos/printing/ppd_metadata_parser_unittest.cc
    • M extensions/browser/api/diagnostics/diagnostics_api.cc
    • M google_apis/classroom/classroom_api_course_work_materials_response_types_unittest.cc
    • M google_apis/classroom/classroom_api_course_work_response_types_unittest.cc
    • M google_apis/classroom/classroom_api_courses_response_types_unittest.cc
    • M google_apis/classroom/classroom_api_material_response_types_unittest.cc
    • M google_apis/classroom/classroom_api_student_submissions_response_types_unittest.cc
    • M google_apis/classroom/classroom_api_students_response_types_unittest.cc
    • M google_apis/people/people_api_requests.cc
    • M google_apis/tasks/tasks_api_response_types_unittest.cc
    • M services/accessibility/features/devtools/os_devtools_unittest.cc
    • M ui/display/manager/display_change_observer.cc
    • M ui/display/manager/display_properties_parser_unittest.cc
    Change size: L
    Delta: 89 files changed, 545 insertions(+), 300 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f9df53cf6e8a0be95b1bd30b400a12d1bf3ae05
    Gerrit-Change-Number: 6992109
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 3:07:19 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances in //chrome/browser that are included in a typical Linux
    developer build.
    Bug: 446188265
    Change-Id: I8c7299794bfaf82830b28394ced0072d40cf8775
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522399}
    Files:
    • M chrome/browser/autofill/captured_sites_test_utils.cc
    • M chrome/browser/browsing_data/chrome_browsing_data_lifetime_manager_browsertest.cc
    • M chrome/browser/browsing_data/chrome_browsing_data_lifetime_manager_unittest.cc
    • M chrome/browser/content_settings/host_content_settings_map_unittest.cc
    • M chrome/browser/devtools/device/devtools_device_discovery.cc
    • M chrome/browser/devtools/devtools_ui_bindings.cc
    • M chrome/browser/devtools/devtools_window.cc
    • M chrome/browser/domain_reliability/browsertest.cc
    • M chrome/browser/download/download_ui_enterprise_util_unittest.cc
    • M chrome/browser/enterprise/connectors/connectors_service_browsertest.cc
    • M chrome/browser/enterprise/connectors/connectors_service_unittest.cc
    • M chrome/browser/enterprise/connectors/reporting/crash_reporting_context_browsertest.cc
    • M chrome/browser/enterprise/connectors/test/deep_scanning_test_utils.cc
    • M chrome/browser/enterprise/profile_management/profile_management_navigation_throttle.cc
    • M chrome/browser/enterprise/reporting/extension_request/extension_request_observer_unittest.cc
    • M chrome/browser/enterprise/reporting/extension_request/extension_request_report_generator_unittest.cc
    • M chrome/browser/enterprise/reporting/profile_report_generator_unittest.cc
    • M chrome/browser/extensions/activity_log/counting_policy.cc
    • M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
    • M chrome/browser/extensions/api/declarative_net_request/declarative_net_request_unittest.cc
    • M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
    • M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
    • M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc
    • M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
    • M chrome/browser/extensions/api/storage/managed_value_store_cache_unittest.cc
    • M chrome/browser/extensions/api/storage/setting_sync_data.cc
    • M chrome/browser/extensions/api/web_request/web_request_apitest.cc
    • M chrome/browser/extensions/api/webstore_private/extension_install_status_unittest.cc
    • M chrome/browser/extensions/api/webstore_private/webstore_private_unittest.cc
    • M chrome/browser/extensions/chrome_app_api_browsertest.cc
    • M chrome/browser/extensions/extension_tab_util_unittest.cc
    • M chrome/browser/extensions/install_signer.cc
    • M chrome/browser/extensions/service_worker_apitest.cc
    • M chrome/browser/extensions/updater/update_service_browsertest.cc
    • M chrome/browser/first_party_sets/first_party_sets_overrides_policy_handler_unittest.cc
    • M chrome/browser/first_party_sets/first_party_sets_policy_browsertest.cc
    • M chrome/browser/media/cast_mirroring_service_host_browsertest.cc
    • M chrome/browser/media/router/logger_list_unittest.cc
    • M chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
    • M chrome/browser/media/router/providers/cast/mirroring_activity_unittest.cc
    • M chrome/browser/media/router/providers/dial/dial_internal_message_util_unittest.cc
    • M chrome/browser/media/router/test/provider_test_helpers.cc
    • M chrome/browser/media/webrtc/webrtc_browsertest_base.cc
    • M chrome/browser/net/cert_verify_proc_browsertest.cc
    • M chrome/browser/net/log_net_log_browsertest.cc
    • M chrome/browser/new_tab_page/modules/file_suggestion/drive_service_unittest.cc
    • M chrome/browser/new_tab_page/new_tab_page_interactive_uitest.cc
    • M chrome/browser/payments/secure_payment_confirmation_authenticator_browsertest.cc
    • M chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client_unittest.cc
    • M chrome/browser/policy/messaging_layer/util/reporting_server_connector_test_util.cc
    • M chrome/browser/policy/messaging_layer/util/test_request_payload.cc
    • M chrome/browser/policy/printing_restrictions_policy_handler_unittest.cc
    • M chrome/browser/policy/test/component_updater_policy_browsertest.cc
    • M chrome/browser/prefs/tracked/pref_hash_browsertest.cc
    • M chrome/browser/profiles/profile_browsertest.cc
    • M chrome/browser/safe_xml_parser_browsertest.cc
    • M chrome/browser/support_tool/policy_data_collector_browsertest.cc
    • M chrome/browser/sync/test/integration/password_manager_sync_test.cc
    • M chrome/browser/sync/test/integration/single_client_common_sync_test.cc
    • M chrome/browser/sync/test/integration/single_client_preferences_sync_test.cc
    • M chrome/browser/themes/browser_theme_pack_unittest.cc
    • M chrome/browser/ui/autofill/autofill_context_menu_manager_interactive_uitest.cc
    • M chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl_interactive_uitest.cc
    • M chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl_unittest.cc
    • M chrome/browser/ui/lens/lens_overlay_controller.cc
    • M chrome/browser/ui/lens/lens_url_matcher.cc
    • M chrome/browser/ui/media_router/media_route_starter_unittest.cc
    • M chrome/browser/ui/plus_addresses/views/plus_address_creation_dialog_interactive_uitest.cc
    • M chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
    • M chrome/browser/ui/views/autofill/payments/bnpl_tos_view_desktop_browsertest.cc
    • M chrome/browser/ui/views/autofill/payments/bnpl_tos_view_desktop_interactive_uitest.cc
    • M chrome/browser/ui/views/digital_credentials/digital_identity_integration_test.cc
    • M chrome/browser/ui/views/extensions/extensions_toolbar_container_unittest.cc
    • M chrome/browser/ui/views/side_panel/extensions/extension_side_panel_browsertest.cc
    • M chrome/browser/ui/webui/browser_switch/browser_switch_ui_unittest.cc
    • M chrome/browser/ui/webui/discards/graph_dump_impl_unittest.cc
    • M chrome/browser/ui/webui/extensions/extensions_internals_unittest.cc
    • M chrome/browser/ui/webui/management/management_ui_browsertest.cc
    • M chrome/browser/ui/webui/management/management_ui_handler_unittest.cc
    • M chrome/browser/ui/webui/management/management_ui_pwa_browsertest.cc
    • M chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc
    • M chrome/browser/ui/webui/policy/policy_ui_browsertest.cc
    • M chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • M chrome/browser/ui/webui/settings/people_handler.cc
    • M chrome/browser/ui/webui/settings/site_settings_helper_unittest.cc
    • M chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc
    • M chrome/browser/web_applications/isolated_web_apps/update_manifest/update_manifest_fuzzer.cc
    • M chrome/browser/web_applications/policy/web_app_policy_manager_browsertest.cc
    • M chrome/browser/web_applications/preinstalled_web_app_migration_browsertest.cc
    • M chrome/browser/web_applications/preinstalled_web_app_utils_unittest.cc
    • M chrome/browser/web_applications/web_app_link_capturing_parameterized_browsertest.cc
    • M chrome/browser/web_applications/web_app_unittest.cc
    • M chrome/browser/webauthn/enclave_manager_unittest.cc
    Change size: L
    Delta: 93 files changed, 359 insertions(+), 221 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8c7299794bfaf82830b28394ced0072d40cf8775
    Gerrit-Change-Number: 6990984
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 3:07:34 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances included in a typical Android developer build.
    Bug: 446188265
    Change-Id: I16da8e1a12a0901ba77807016677f77b407685ca
    Owners-Override: Lei Zhang <the...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522400}
    Files:
    • M android_webview/browser/enterprise_authentication_app_link_policy_handler_unittest.cc
    • M android_webview/nonembedded/component_updater/aw_component_update_service_test.cc
    • M chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
    • M chrome/browser/digital_credentials/digital_identity_provider_android.cc
    • M components/browser_ui/site_settings/android/website_preference_bridge.cc
    • M components/content_capture/android/test_support/content_capture_test_support_android.cc
    • M components/facilitated_payments/core/browser/network_api/facilitated_payments_initiate_payment_request_unittest.cc
    • M components/facilitated_payments/core/browser/network_api/get_details_for_pix_account_linking_request_unittest.cc
    • M components/ntp_tiles/popular_sites_impl.cc
    Change size: M
    Delta: 9 files changed, 41 insertions(+), 23 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I16da8e1a12a0901ba77807016677f77b407685ca
    Gerrit-Change-Number: 6992110
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 3:08:32 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances in //content included in a typical Linux developer build.
    Bug: 446188265
    Change-Id: If218e03839e8ac3a818270fef1c0cf6bac2b6968
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522401}
    Files:
    • M content/browser/aggregation_service/public_key_parsing_utils_unittest.cc
    • M content/browser/devtools/devtools_http_handler_unittest.cc
    • M content/browser/devtools/devtools_protocol_encoding_json_fuzzer.cc
    • M content/browser/devtools/protocol/devtools_protocol_browsertest.cc
    • M content/browser/devtools/protocol/tracing_handler_unittest.cc
    • M content/browser/digital_credentials/cross_device_request_dispatcher_unittest.cc
    • M content/browser/digital_credentials/digital_identity_request_impl.cc
    • M content/browser/digital_credentials/digital_identity_request_impl_unittest.cc
    • M content/browser/first_party_sets/first_party_set_parser_unittest.cc
    • M content/browser/first_party_sets/first_party_sets_handler_impl_instance_unittest.cc
    • M content/browser/indexed_db/instance/leveldb/indexed_db_leveldb_operations.cc
    • M content/browser/interest_group/bidding_and_auction_server_key_fetcher.cc
    • M content/browser/interest_group/interest_group_storage.cc
    • M content/browser/media/media_internals_unittest.cc
    • M content/browser/network_service_browsertest.cc
    • M content/browser/preloading/preloading_config.cc
    • M content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
    • M content/browser/renderer_host/render_frame_host_impl.cc
    • M content/browser/renderer_host/scroll_into_view_browsertest.cc
    • M content/browser/service_worker/service_worker_browsertest.cc
    • M content/browser/shared_storage/shared_storage_browsertest.cc
    • M content/browser/site_per_process_hit_test_browsertest.cc
    • M content/browser/tracing/background_tracing_manager_browsertest.cc
    • M content/browser/tracing/startup_tracing_browsertest.cc
    • M content/browser/tracing/tracing_ui.cc
    • M content/browser/webauth/authenticator_impl_unittest.cc
    • M content/browser/webid/delegation/sd_jwt_unittest.cc
    • M content/browser/webid/request_service.cc
    • M content/browser/webid/webid_browsertest.cc
    • M content/common/input/actions_parser_test_driver_unittest.cc
    • M content/common/input/actions_parser_unittest.cc
    • M content/public/test/browser_test_utils.cc
    • M content/public/test/scoped_page_focus_override.cc
    • M content/public/test/test_devtools_protocol_client.cc
    • M content/renderer/render_frame_impl.cc
    • M content/services/auction_worklet/worklet_devtools_debug_test_util.cc
    • M content/services/auction_worklet/worklet_v8_debug_test_util.cc
    Change size: L
    Delta: 37 files changed, 220 insertions(+), 116 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If218e03839e8ac3a818270fef1c0cf6bac2b6968
    Gerrit-Change-Number: 6990983
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 3:27:53 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances in //components included in a typical Linux developer build.
    Bug: 446188265
    Change-Id: I0ca01fbbd4a889a480e8661d17496f775b5df0d2
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522415}
    Files:
    • M components/autofill/content/renderer/dom_label_browsertest.cc
    • M components/autofill/core/browser/heuristic_classification_unittest.cc
    • M components/autofill/core/browser/payments/legal_message_line_unittest.cc
    • M components/autofill/core/browser/payments/multiple_request_payments_network_interface_base.cc
    • M components/autofill/core/browser/payments/payments_network_interface_base.cc
    • M components/autofill/core/browser/payments/payments_requests/get_details_for_enrollment_request_unittest.cc
    • M components/autofill/core/browser/payments/payments_requests/unmask_card_request_unittest.cc
    • M components/autofill/core/browser/payments/payments_requests/update_virtual_card_enrollment_request_unittest.cc
    • M components/autofill/core/browser/payments/test_payments_network_interface.cc
    • M components/autofill/core/browser/studies/autofill_experiments_unittest.cc
    • M components/autofill/core/browser/ui/payments/bnpl_tos_controller_impl_unittest.cc
    • M components/bookmarks/managed/managed_bookmarks_policy_handler_unittest.cc
    • M components/cast_streaming/browser/cast_message_port_impl_unittest.cc
    • M components/commerce/core/commerce_utils_unittest.cc
    • M components/commerce/core/heuristics/commerce_heuristics_provider.cc
    • M components/content_capture/browser/content_capture_receiver_browsertest.cc
    • M components/content_capture/browser/content_capture_receiver_test.cc
    • M components/content_settings/core/common/content_settings_partition_key.cc
    • M components/contextual_search/core/browser/contextual_search_delegate_impl.cc
    • M components/devtools/simple_devtools_protocol_client/simple_devtools_protocol_client.cc
    • M components/dom_distiller/core/page_features_unittest.cc
    • M components/domain_reliability/config.cc
    • M components/enterprise/connectors/core/connectors_service_base_unittest.cc
    • M components/enterprise/data_controls/core/browser/rule_unittest.cc
    • M components/enterprise/data_controls/core/browser/test_utils.cc
    • M components/feed/core/v2/types_unittest.cc
    • M components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc
    • M components/history/core/browser/web_history_service.cc
    • M components/history_clusters/core/file_clustering_backend.cc
    • M components/media_router/browser/logger_impl_unittest.cc
    • M components/mirroring/service/openscreen_message_port_unittest.cc
    • M components/mirroring/service/rpc_dispatcher_impl_unittest.cc
    • M components/omnibox/browser/document_provider_unittest.cc
    • M components/omnibox/browser/enterprise_search_aggregator_suggestions_service_unittest.cc
    • M components/omnibox/browser/search_suggestion_parser_unittest.cc
    • M components/payments/core/payment_details_validation_unittest.cc
    • M components/performance_manager/graph/node_data_describer_util_unittest.cc
    • M components/permissions/permission_actions_history_unittest.cc
    • M components/plus_addresses/core/browser/plus_address_http_client_impl_unittest.cc
    • M components/plus_addresses/core/browser/plus_address_parsing_utils_unittest.cc
    • M components/plus_addresses/core/browser/plus_address_test_utils.cc
    • M components/policy/core/common/cloud/cloud_policy_client_unittest.cc
    • M components/policy/core/common/cloud/encrypted_reporting_job_configuration_unittest.cc
    • M components/policy/core/common/cloud/realtime_reporting_job_configuration.cc
    • M components/policy/core/common/cloud/realtime_reporting_job_configuration_unittest.cc
    • M components/policy/core/common/cloud/reporting_job_configuration_base.cc
    • M components/policy/core/common/cloud/user_info_fetcher.cc
    • M components/proto_extras/proto_extras_unittest.cc
    • M components/reporting/client/report_queue_impl_unittest.cc
    • M components/safe_browsing/core/browser/tailored_security_service/tailored_security_service.cc
    • M components/safe_search_api/safe_search/safe_search_url_checker_client.cc
    • M components/search_engines/keyword_table.cc
    • M components/search_provider_logos/logo_cache.cc
    • M components/services/app_service/public/cpp/preferred_apps_converter_unittest.cc
    • M components/services/heap_profiling/json_exporter_unittest.cc
    • M components/shared_highlighting/core/common/shared_highlighting_data_driven_test.cc
    • M components/signin/internal/identity_manager/gaia_cookie_manager_service.cc
    • M components/signin/public/base/session_binding_utils_unittest.cc
    • M components/subresource_filter/tools/filter_tool.cc
    • M components/subresource_filter/tools/indexing_tool_unittest.cc
    • M components/supervised_user/core/browser/supervised_user_settings_service.cc
    • M components/supervised_user/core/browser/supervised_user_settings_service_unittest.cc
    • M components/sync_preferences/pref_service_syncable_unittest.cc
    • M components/sync_preferences/preferences_merge_helper_unittest.cc
    • M components/update_client/ping_manager_unittest.cc
    • M components/update_client/update_checker_unittest.cc
    • M components/upload_list/text_log_upload_list.cc
    • M components/value_store/lazy_leveldb.cc
    • M components/value_store/leveldb_value_store.cc
    • M components/viz/common/quads/render_pass_io_unittest.cc
    • M components/viz/service/display/viz_perftest.cc
    • M components/webcrypto/algorithms/test_helpers.cc
    Change size: L
    Delta: 72 files changed, 490 insertions(+), 288 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0ca01fbbd4a889a480e8661d17496f775b5df0d2
    Gerrit-Change-Number: 6990985
    open
    diffy
    satisfied_requirement

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 3:53:25 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng added 1 comment

    File services/network/trust_tokens/trust_token_key_commitment_parser_unittest.cc
    Line 681, Patchset 1: // not valid JSON.
    Lei Zhang . resolved

    Format the comment like line 668 / 689.

    Daniel Cheng

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
    Gerrit-Change-Number: 6990987
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 19:53:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 3:54:27 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng added 1 comment

    File chromecast/crash/linux/synchronized_minidump_manager.cc
    Line 301, Patchset 1: std::optional<base::Value> dump_info = base::JSONReader::Read(line, base::JSON_PARSE_CHROMIUM_EXTENSIONS);
    Lei Zhang . resolved

    Wrap.

    Daniel Cheng

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
    Gerrit-Change-Number: 6992112
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 19:54:14 +0000
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 3:59:15 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I832f8c9f0b6fe098905a387a23c1cce203e2ec2f
    Gerrit-Change-Number: 6992113
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 19:59:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 4:02:49 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chromecast/renderer/assistant_bindings.cc
    Insertions: 1, Deletions: 2.

    The diff is too large to show. Please review the diff.
    ```
    ```
    The name of the file: chromecast/crash/linux/synchronized_minidump_manager.cc
    Insertions: 1, Deletions: 2.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances included in a typical fuzzer build.
    Bug: 446188265
    Change-Id: I832f8c9f0b6fe098905a387a23c1cce203e2ec2f
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522438}
    Files:
    • M base/json/json_reader_fuzzer.cc
    • M chrome/browser/extensions/extension_management_internal_fuzzer.cc
    • M chrome/browser/first_party_sets/test/first_party_sets_overrides_policy_handler_fuzzer.cc
    • M chrome/browser/media/router/providers/dial/dial_internal_message_fuzzer.cc
    • M components/payments/content/utility/payment_method_manifest_parser_fuzzer.cc
    • M components/payments/content/utility/payment_web_app_manifest_parser_fuzzer.cc
    • M components/policy/core/common/schema_fuzzer.cc
    • M components/update_client/protocol_serializer_fuzzer.cc
    • M content/test/fuzzer/renderer_tree_fuzzer.cc
    • M extensions/browser/api/declarative_net_request/indexed_rule_fuzzer.cc
    • M extensions/common/api/scripts_internal/script_serialization_fuzzer.cc
    • M extensions/common/manifest_fuzzer.cc
    • M net/base/backoff_entry_serializer_fuzzer.cc
    • M net/dns/host_cache_fuzzer.cc
    • M net/dns/host_resolver_cache_fuzzer.cc
    • M net/reporting/reporting_header_parser_fuzzer.cc
    Change size: M
    Delta: 16 files changed, 34 insertions(+), 19 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I832f8c9f0b6fe098905a387a23c1cce203e2ec2f
    Gerrit-Change-Number: 6992113
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 6:20:13 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
    Gerrit-Change-Number: 6990987
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 22:19:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 6:20:18 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f11750a999b1b2707d528d80f6175723f08cfba
    Gerrit-Change-Number: 6992111
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 22:20:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 6:20:43 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd3ef8b9da4f7cafc7ea8a4335f7e6c26cfde818
    Gerrit-Change-Number: 6990988
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 22:20:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 6:23:12 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: services/network/trust_tokens/trust_token_key_commitment_parser_unittest.cc
    Insertions: 3, Deletions: 3.


    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances in //services included in a typical Linux developer build.
    Bug: 446188265
    Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522529}
    Files:
    • M services/device/geolocation/network_location_provider_unittest.cc
    • M services/image_annotation/annotator_unittest.cc
    • M services/network/sct_auditing/sct_auditing_handler.cc
    • M services/network/test/trust_token_test_util.cc
    • M services/network/trust_tokens/trust_token_key_commitment_parser_unittest.cc
    • M services/tracing/public/cpp/perfetto/perfetto_config_unittest.cc
    • M services/tracing/tracing_service_unittest.cc
    Change size: M
    Delta: 7 files changed, 95 insertions(+), 47 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iba76062f9a21d8048443767e801fd658a48e71b4
    Gerrit-Change-Number: 6990987
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 6:24:03 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances included in a typical Fuchsia developer build.
    Bug: 446188265
    Change-Id: I0f11750a999b1b2707d528d80f6175723f08cfba
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522530}
    Files:
    • M chromecast/base/device_capabilities_impl_unittest.cc
    • M fuchsia_web/common/test/frame_test_util.cc
    • M fuchsia_web/common/test/test_devtools_list_fetcher.cc
    • M fuchsia_web/webengine/browser/content_directory_loader_factory.cc
    Change size: S
    Delta: 4 files changed, 9 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f11750a999b1b2707d528d80f6175723f08cfba
    Gerrit-Change-Number: 6992111
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 6:25:17 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes miscellaneous instances included in a typical Linux developer build.
    Bug: 446188265
    Change-Id: Icd3ef8b9da4f7cafc7ea8a4335f7e6c26cfde818
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522532}
    Files:
    • M chrome/test/base/devtools_listener.cc
    • M chrome/test/base/web_ui_mocha_browser_test.cc
    • M chrome/test/chromedriver/capabilities_unittest.cc
    • M chrome/test/chromedriver/chrome/browser_info.cc
    • M chrome/test/chromedriver/chrome/devtools_client_impl.cc
    • M chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
    • M chrome/test/chromedriver/chrome/devtools_http_client.cc
    • M chrome/test/chromedriver/chrome/log.cc
    • M chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
    • M chrome/test/chromedriver/chrome_launcher.cc
    • M chrome/test/chromedriver/chrome_launcher_unittest.cc
    • M chrome/test/chromedriver/log_replay/log_replay_socket.cc
    • M chrome/test/chromedriver/net/pipe_connection_unittest.cc
    • M chrome/test/chromedriver/net/stub_sync_websocket.cc
    • M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
    • M chrome/test/chromedriver/server/http_handler.cc
    • M chrome/test/chromedriver/test/command_injecting_socket.cc
    • M chrome/test/chromedriver/test/commands_integrationtest.cc
    • M chrome/updater/test/integration_tests_helper.cc
    • M chrome/utility/importer/nss_decryptor.cc
    • M device/fido/enclave/enclave_protocol_utils_unittest.cc
    • M extensions/browser/api/declarative_net_request/filter_list_converter/converter_unittest.cc
    • M extensions/browser/computed_hashes.cc
    • M extensions/browser/content_verifier/content_hash.cc
    • M extensions/browser/json_file_sanitizer.cc
    • M extensions/browser/verified_contents.cc
    • M extensions/browser/zipfile_installer.cc
    • M extensions/common/api/sockets/sockets_manifest_permission_unittest.cc
    • M extensions/common/manifest_unittest.cc
    • M extensions/renderer/bindings/api_binding_test_util.cc
    • M google_apis/gaia/gaia_config_unittest.cc
    • M google_apis/gaia/gaia_oauth_client_unittest.cc
    • M google_apis/gaia/oauth2_id_token_decoder.cc
    • M google_apis/gaia/oauth_multilogin_result.cc
    • M media/cdm/aes_decryptor_unittest.cc
    • M media/cdm/json_web_key.cc
    • M remoting/host/native_messaging/native_messaging_helpers.cc
    • M remoting/host/native_messaging/native_messaging_pipe.cc
    • M remoting/host/native_messaging/native_messaging_reader.cc
    • M remoting/host/setup/cloud_host_starter.cc
    • M remoting/host/webauthn/remote_webauthn_native_messaging_host_unittest.cc
    • M testing/perf/luci_test_result_unittest.cc
    • M third_party/blink/renderer/core/css/style_perftest.cc
    • M third_party/blink/renderer/core/html/html_perftest.cc
    • M third_party/blink/renderer/platform/instrumentation/tracing/traced_value_test.cc
    • M third_party/libaddressinput/chromium/json.cc
    • M tools/json_schema_compiler/test/simple_api_unittest.cc
    • M ui/base/clipboard/clipboard.cc
    • M ui/events/ozone/evdev/touch_filter/neural_stylus_palm_detection_filter.cc
    • M ui/events/ozone/evdev/touch_filter/palm_detection_filter_factory.cc
    • M ui/gfx/hdr_metadata_agtm.cc
    • M ui/native_theme/caption_style.cc
    Change size: M
    Delta: 52 files changed, 146 insertions(+), 91 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icd3ef8b9da4f7cafc7ea8a4335f7e6c26cfde818
    Gerrit-Change-Number: 6990988
    open
    diffy
    satisfied_requirement

    Daniel Cheng (Gerrit)

    unread,
    Sep 29, 2025, 6:58:49 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
    Gerrit-Change-Number: 6992112
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Mon, 29 Sep 2025 22:58:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 29, 2025, 7:05:26 PM (8 days ago) Sep 29
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chromecast/crash/linux/synchronized_minidump_manager.cc
    Insertions: 2, Deletions: 1.


    The diff is too large to show. Please review the diff.
    ```
    ```
    The name of the file: chromecast/renderer/assistant_bindings.cc
    Insertions: 2, Deletions: 1.


    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Prepare to remove base::JSONReader::Read's parsing option default

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments. This
    fixes instances included in a typical Cast developer build.
    Bug: 446188265
    Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Owners-Override: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1522547}
    Files:
    • M chromecast/crash/linux/synchronized_minidump_manager.cc
    • M chromecast/renderer/assistant_bindings.cc
    Change size: XS
    Delta: 2 files changed, 4 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1cba2727655bff5c152379c7dd514e658ba83b99
    Gerrit-Change-Number: 6992112
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages