Do not use uninitialized 'self' in WaylandZwpLinuxDmabuf::OnMainDevice() [chromium/src : main]
0 views
Skip to first unread message
Kate Kulikova (Gerrit)
Sep 1, 2025, 5:02:37 AM (7 days ago) Sep 1
to Eliot Courtney, Chromium LUCI CQ, Kenny Levinsen, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kate Kulikova added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 1:
Do not use unitialized 'self' in WaylandZwpLinuxDmabuf::OnMainDevice()Eliot Courtney . resolved
Kate KulikovaPlease fix this WARNING reported by Spellchecker: "unitialized" is a possible misspelling of "uninitialized".
To bypass Spellchec...
"unitialized" is a possible misspelling of "uninitialized".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Sorry, that was a typo, thank you! Done.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kate Kulikova (Gerrit)
Sep 1, 2025, 5:03:11 AM (7 days ago) Sep 1
to Eliot Courtney, Chromium LUCI CQ, Kenny Levinsen, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kate Kulikova voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 1, 2025, 5:45:54 AM (7 days ago) Sep 1
to Kate Kulikova, Eliot Courtney, Kramer Ge, Kenny Levinsen, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Do not use uninitialized 'self' in WaylandZwpLinuxDmabuf::OnMainDevice()
In the CL https://crrev.com/c/6850415 added usage of
self->supported_buffer_formats_with_modifiers_.clear() outside
the "if defined(WAYLAND_GBM)" insertion in
WaylandZwpLinuxDmabuf::OnMainDevice(), but 'self' is initialized only
if defined(WAYLAND_GBM).
Bug: 437811360
Change-Id: Ia5acbb1999b27559d1774ac01527bbc317b5543e
Commit-Queue: Kate Kulikova <kate.k...@lge.com>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Eliot Courtney <edcou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1509071}
Files:
- M ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eliot Courtney, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages