[ozone/wayland] Remove IsDragSource check for tab dragging [chromium/src : main]
1 view
Skip to first unread message
Kramer Ge (Gerrit)
Apr 21, 2026, 4:08:14 PM (8 days ago) Apr 21
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Kramer Ge voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 21, 2026, 4:38:54 PM (8 days ago) Apr 21
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Apr 22, 2026, 10:51:28 AM (7 days ago) Apr 22
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 22, 2026, 10:55:00 AM (7 days ago) Apr 22
to Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ozone/wayland] Remove IsDragSource check for tab dragging
We observe CHECK failures here. There are states which resets
drag_source_ but does not set state_ to kIdle.
Replace the CHECK with a debug dump and use !!drag_source_ as source of
truth.
Bug: 498008192
Change-Id: I5cffc230e84855c7e9648ce60efe79221d9ebdec
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618870}
Files:
- M ui/ozone/platform/wayland/host/wayland_window_drag_controller.cc
Change size: S
Delta: 1 file changed, 15 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages