Wayland: skip pointer release if a surface has capture [chromium/src : main]
0 views
Skip to first unread message
Mitchell Cohen (Gerrit)
Jun 21, 2026, 2:03:37 PM (8 days ago) Jun 21
to Thomas Anderson, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Thomas Anderson
Mitchell Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mitchell Cohen . unresolved
Note: I cannot actually repro the issue in https://issues.chromium.org/issues/500653052 to confirm that this fixes it, but I can confirm that it does not regress the previous fixes in https://chromium-review.googlesource.com/c/chromium/src/+/7091872 and https://chromium-review.googlesource.com/c/chromium/src/+/7746265.
Related details
Attention is currently required from:
- Kramer Ge
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jun 22, 2026, 4:16:44 PM (7 days ago) Jun 22
to Mitchell Cohen, Chromium LUCI CQ, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Mitchell Cohen
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
1 comment
Patchset-level comments
Mitchell Cohen . resolved
Note: I cannot actually repro the issue in https://issues.chromium.org/issues/500653052 to confirm that this fixes it, but I can confirm that it does not regress the previous fixes in https://chromium-review.googlesource.com/c/chromium/src/+/7091872 and https://chromium-review.googlesource.com/c/chromium/src/+/7746265.
Attention is currently required from:
- Kramer Ge
- Mitchell Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 22, 2026, 5:35:31 PM (7 days ago) Jun 22
to Mitchell Cohen, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen
Kramer Ge voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mitchell Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 22, 2026, 5:35:38 PM (7 days ago) Jun 22
to Mitchell Cohen, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Mitchell Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 22, 2026, 6:42:10 PM (6 days ago) Jun 22
to Mitchell Cohen, Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Wayland: skip pointer release if a surface has capture
Compositors should fire the pointer enter event for a new surface in the
same frame as the previous leave event, but sometimes they don't. Check
to see if Views still has pointer capture before releasing the pointer
instead of relying only on frame timing. This should make it more
reliable to hold down right-click to open a menu.
Bug: 500653052
Change-Id: Iafc97bb92049de76917f9c4008453870562fa8b4
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650629}
Files:
- M ui/ozone/platform/wayland/host/wayland_event_source.cc
- M ui/ozone/platform/wayland/host/wayland_event_source_unittest.cc
Change size: M
Delta: 2 files changed, 55 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages