[Wayland] Fix crash during tablet pen tab drag proximity change [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Jul 14, 2026, 11:34:59 AM (9 days ago) Jul 14
to Thomas Lukaszewicz, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Lukaszewicz
Thomas Anderson voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jul 14, 2026, 2:30:32 PM (9 days ago) Jul 14
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Thomas Lukaszewicz voted![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 14, 2026, 2:38:41 PM (9 days ago) Jul 14
to Thomas Anderson, Thomas Lukaszewicz, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Wayland] Fix crash during tablet pen tab drag proximity change
When dragging a tab with a tablet pen, lifting the pen triggers
OnTabletToolProximityOut(), which retains the buttons as pressed.
When the pen comes back into proximity, OnTabletToolProximityIn() is
called. Previously, this unilaterally dispatched a button release
event, causing the active drag session to terminate on the client side
while the compositor and high-level drag controller still considered
the drag active, resulting in a subsequent crash.
This CL fixes the issue by only releasing the buttons on proximity-in
if there is no drag session currently in progress.
Bug: 532860184
Change-Id: I980db2b5bacee22a520c9a8b0e050c28d7de0365
Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1662025}
Files:
- M ui/ozone/platform/wayland/host/wayland_event_source.cc
- M ui/ozone/platform/wayland/host/wayland_window_drag_controller_unittest.cc
Change size: M
Delta: 2 files changed, 52 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages