Fix dangling pointer in TestSelectionSource [chromium/src : main]
0 views
Skip to first unread message
AbdAlRahman Gad (Gerrit)
Aug 26, 2025, 7:45:03 AM (13 days ago) Aug 26
to Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Max Ihlenfeldt
AbdAlRahman Gad added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
AbdAlRahman Gad . resolved
Adding a `manager_` member to `TestSelectionSource` so that we can reset the selection source later.
Related details
Attention is currently required from:
- Max Ihlenfeldt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Max Ihlenfeldt (Gerrit)
Aug 26, 2025, 9:18:56 AM (13 days ago) Aug 26
to AbdAlRahman Gad, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from AbdAlRahman Gad
Max Ihlenfeldt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Max Ihlenfeldt
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- AbdAlRahman Gad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Sep 2, 2025, 9:59:46 AM (6 days ago) Sep 2
to AbdAlRahman Gad, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from AbdAlRahman Gad
Orko Garai voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- AbdAlRahman Gad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
AbdAlRahman Gad (Gerrit)
Sep 2, 2025, 1:01:42 PM (5 days ago) Sep 2
to Orko Garai, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
AbdAlRahman Gad voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 2, 2025, 1:54:20 PM (5 days ago) Sep 2
to AbdAlRahman Gad, Orko Garai, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix dangling pointer in TestSelectionSource
Change-Id: Id1e98fb101860d96962ef446cc2e0010c8a2eff4
Bug: 324294360
Reviewed-by: Max Ihlenfeldt <m...@igalia.com>
Commit-Queue: AbdAlRahman Gad <ag...@igalia.com>
Reviewed-by: Orko Garai <or...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1509668}
Files:
- M ui/ozone/platform/wayland/test/test_selection_device_manager.cc
- M ui/ozone/platform/wayland/test/test_selection_device_manager.h
Change size: S
Delta: 2 files changed, 12 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Max Ihlenfeldt, +1 by Orko Garai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages