[SupportsWeakPtr] Add WeakPtrFactory to GLSurface [chromium/src : main]
0 views
Skip to first unread message
Bo Liu (Gerrit)
Jul 25, 2024, 4:16:07 PM (2 days ago) Jul 25
to Dave Tapuska, Bo Liu, Geoff Lang, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dave Tapuska, Geoff Lang and Hidehiko Abe
Bo Liu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
- Geoff Lang
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Jul 25, 2024, 4:27:05 PM (2 days ago) Jul 25
to Dave Tapuska, Bo Liu, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dave Tapuska and Hidehiko Abe
Geoff Lang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 26, 2024, 3:20:44 AM (yesterday) Jul 26
to Dave Tapuska, Geoff Lang, Bo Liu, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dave Tapuska
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hidehiko Abe . resolved
ui/ozone/platform/wayland/gpu/gl_surface_wayland.cc LGTM
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 26, 2024, 3:20:51 AM (yesterday) Jul 26
to Dave Tapuska, Geoff Lang, Bo Liu, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dave Tapuska
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jul 26, 2024, 10:26:58 AM (22 hours ago) Jul 26
to Hidehiko Abe, Geoff Lang, Bo Liu, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Dave Tapuska voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 26, 2024, 10:30:07 AM (22 hours ago) Jul 26
to Dave Tapuska, Hidehiko Abe, Geoff Lang, Bo Liu, chromium...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[SupportsWeakPtr] Add WeakPtrFactory to GLSurface
The GLSurface now contains a WeakPtrFactory and subclasses must
call InvalidateWeakPtrs from their leafmost class.
Bug: 40485134
Change-Id: I94e8373a4ac48b523c111cd26988b6e9721a0bc3
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Bo Liu <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1333537}
Files:
- M android_webview/browser/gfx/aw_gl_surface.cc
- M android_webview/browser/gfx/aw_gl_surface_external_stencil.cc
- M gpu/command_buffer/service/gl_surface_mock.cc
- M gpu/command_buffer/service/shared_image/dcomp_surface_image_backing.cc
- M gpu/command_buffer/service/shared_image/ozone_image_backing_factory_unittest.cc
- M ui/gl/gl_surface.cc
- M ui/gl/gl_surface.h
- M ui/gl/gl_surface_egl.cc
- M ui/gl/gl_surface_egl_x11.cc
- M ui/gl/gl_surface_egl_x11_gles2.cc
- M ui/ozone/platform/wayland/gpu/gl_surface_wayland.cc
Change size: M
Delta: 11 files changed, 45 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Bo Liu, +1 by Hidehiko Abe, +1 by Geoff Lang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages