Revert "[//gpu] Eliminate clone of handle in ClientSharedImage" [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Jan 9, 2026, 3:29:37 AM (3 days ago) Jan 9
to Dominic Battre, AyeAye, Colin Blundell, Chromium LUCI CQ, Vasiliy Telezhnikov, Antonio Sartori, David Worsham, Zijie He, chromium...@chromium.org, Robert Kroeger, feature-me...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Antonio Sartori, Colin Blundell and Vasiliy Telezhnikov
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Antonio Sartori
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 3:29:55 AM (3 days ago) Jan 9
to Dominic Battre, Rubber Stamper, AyeAye, Colin Blundell, Chromium LUCI CQ, Vasiliy Telezhnikov, Antonio Sartori, David Worsham, Zijie He, chromium...@chromium.org, Robert Kroeger, feature-me...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Antonio Sartori, Colin Blundell and Vasiliy Telezhnikov
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection recommends submitting this revert because it has confirmed the target of this revert is the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693167778763831553
Sample failed build: https://ci.chromium.org/b/8693167778763831553
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7414979&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8693167778763831553&type=BUG
Dominic Battre (Gerrit)
Jan 9, 2026, 3:30:15 AM (3 days ago) Jan 9
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, AyeAye, Colin Blundell, Chromium LUCI CQ, Vasiliy Telezhnikov, Antonio Sartori, David Worsham, Zijie He, chromium...@chromium.org, Robert Kroeger, feature-me...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Antonio Sartori, Colin Blundell and Vasiliy Telezhnikov
Dominic Battre voted![]( "Open in Gerrit")
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Antonio Sartori
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 3:30:47 AM (3 days ago) Jan 9
to Dominic Battre, luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, AyeAye, Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, David Worsham, Zijie He, chromium...@chromium.org, Robert Kroeger, feature-me...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[//gpu] Eliminate clone of handle in ClientSharedImage"
This reverts commit 7a0990eb0ef7335327473694f90ee0f519f49f84.
Reason for revert: Breaks https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/64906/blamelist
Original change's description:
> [//gpu] Eliminate clone of handle in ClientSharedImage
>
> Our hypothesis is that crbug.com/472087363 is arising due to the clone
> of the handle failing. This CL avoids the clone by adding an API to get
> the needed information directly from the existing handle.
>
> Bug: 472087363
> Change-Id: I4ac7d911a80fb55e1a622befa7fefc91bc21c263
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7414979
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Commit-Queue: Colin Blundell <blun...@chromium.org>
> Reviewed-by: Antonio Sartori <antonio...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566776}
Bug: 472087363
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ie059204b486d2a620afbe3836e3b9b46f5dbcc40
Commit-Queue: Dominic Battre <bat...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Owners-Override: Dominic Battre <bat...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566780}
Files:
- M gpu/command_buffer/client/client_shared_image.cc
- M gpu/command_buffer/client/internal/mappable_buffer_native_pixmap.h
- M media/fuchsia/video/fuchsia_video_decoder_unittest.cc
- M ui/gfx/client_native_pixmap.h
- M ui/gfx/linux/client_native_pixmap_dmabuf.cc
- M ui/gfx/linux/client_native_pixmap_dmabuf.h
- M ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
- M ui/ozone/platform/flatland/client_native_pixmap_factory_flatland.cc
Change size: S
Delta: 8 files changed, 2 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 9, 2026, 3:31:06 AM (3 days ago) Jan 9
to Dominic Battre, Chromium LUCI CQ, Colin Blundell, luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, AyeAye, Vasiliy Telezhnikov, Antonio Sartori, David Worsham, Zijie He, chromium...@chromium.org, Robert Kroeger, feature-me...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages