[viz] Remove BufferFormat utility methods no longer needed [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Jan 23, 2026, 11:00:25 AM (10 days ago) Jan 23
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov
Saifuddin Hitawala added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 23, 2026, 11:14:44 AM (10 days ago) Jan 23
to Saifuddin Hitawala, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala and Vasiliy Telezhnikov
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
Colin Blundell . resolved
\o/
File components/viz/common/resources/shared_image_format.h
Line 335, Patchset 2 (Latest):
// NOTE: These formats are not Mappable as they are not used withColin Blundell . unresolved
nit: I'm not sure we need this comment at this point?
Related details
Attention is currently required from:
- Saifuddin Hitawala
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 23, 2026, 12:50:26 PM (10 days ago) Jan 23
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov
Saifuddin Hitawala voted and added 2 comments![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File components/viz/common/resources/shared_image_format.h
Line 335, Patchset 2:
// NOTE: These formats are not Mappable as they are not used withColin Blundell . resolved
nit: I'm not sure we need this comment at this point?
Saifuddin Hitawala
Ah right, its not really needed. Updated to remove it.
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 23, 2026, 2:31:04 PM (9 days ago) Jan 23
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov
Saifuddin Hitawala voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 23, 2026, 3:21:38 PM (9 days ago) Jan 23
to Saifuddin Hitawala, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/viz/common/resources/shared_image_format.h
Insertions: 0, Deletions: 2.
@@ -332,8 +332,6 @@
SharedImageFormat::MultiPlane(SharedImageFormat::PlaneConfig::kY_UV,
SharedImageFormat::Subsampling::k420,
SharedImageFormat::ChannelFormat::k10);
-// NOTE: These formats are not Mappable as they are not used with
-// GpuMemoryBuffers.
inline constexpr SharedImageFormat kNV16 =
SharedImageFormat::MultiPlane(SharedImageFormat::PlaneConfig::kY_UV,
SharedImageFormat::Subsampling::k422,
```
Change information
Commit message:
[viz] Remove BufferFormat utility methods no longer needed
Remove some BufferFormat utility methods that are not called
anywhere and are no longer needed.
Bug: 356649879
Change-Id: Ifadf00a2c663082152709707e03a7660200d0619
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573874}
Files:
- M components/viz/common/resources/shared_image_format.h
- M components/viz/common/resources/shared_image_format_utils.cc
- M components/viz/common/resources/shared_image_format_utils.h
- M ui/gfx/buffer_types.h
- M ui/gfx/linux/drm_util_linux.cc
- M ui/gfx/linux/drm_util_linux.h
Change size: M
Delta: 6 files changed, 0 insertions(+), 157 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages