[M146] Compensate tablet input with panel orientation [chromium/src : refs/branch-heads/7680]

0 views
Skip to first unread message

Vincent Chiang (Gerrit)

unread,
Mar 17, 2026, 1:42:21 PMMar 17
to Rubber Stamper, AyeAye, ozone-...@chromium.org

Vincent Chiang voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7680
Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
Gerrit-Change-Number: 7674109
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 17:42:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Mar 17, 2026, 1:43:15 PMMar 17
to Vincent Chiang, AyeAye, ozone-...@chromium.org

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7680
    Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
    Gerrit-Change-Number: 7674109
    Gerrit-PatchSet: 1
    Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
    Gerrit-Comment-Date: Tue, 17 Mar 2026 17:43:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Vincent Chiang (Gerrit)

    unread,
    Mar 17, 2026, 1:49:26 PMMar 17
    to Sean O'Brien, Chromium LUCI CQ, Rubber Stamper, AyeAye, ozone-...@chromium.org
    Attention needed from Sean O'Brien

    Vincent Chiang voted and added 1 comment

    Votes added by Vincent Chiang

    Auto-Submit+0

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Vincent Chiang . resolved

    Hi Sean, can you take a look at this merge request? Thank you!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sean O'Brien
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7680
    Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
    Gerrit-Change-Number: 7674109
    Gerrit-PatchSet: 1
    Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
    Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
    Gerrit-Comment-Date: Tue, 17 Mar 2026 17:49:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Sean O'Brien (Gerrit)

    unread,
    Mar 17, 2026, 2:17:08 PMMar 17
    to Vincent Chiang, Chromium LUCI CQ, Rubber Stamper, AyeAye, ozone-...@chromium.org
    Attention needed from Vincent Chiang

    Sean O'Brien added 1 comment

    File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
    Line 214, Patchset 1 (Latest): gfx::PointF point(
    Sean O'Brien . unresolved

    nit: please use a more descriptive variable name.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vincent Chiang
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7680
      Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
      Gerrit-Change-Number: 7674109
      Gerrit-PatchSet: 1
      Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
      Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Attention: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Comment-Date: Tue, 17 Mar 2026 18:17:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Sean O'Brien (Gerrit)

      unread,
      Mar 17, 2026, 2:17:42 PMMar 17
      to Vincent Chiang, Chromium LUCI CQ, Rubber Stamper, AyeAye, ozone-...@chromium.org
      Attention needed from Vincent Chiang

      Sean O'Brien voted and added 2 comments

      Votes added by Sean O'Brien

      Code-Review+1

      2 comments

      Patchset-level comments
      Sean O'Brien . resolved

      Just realized this is a cherry pick - no need to resolve nit.

      File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
      Sean O'Brien . resolved

      nit: please use a more descriptive variable name.

      Sean O'Brien

      Acknowledged

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vincent Chiang
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7680
      Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
      Gerrit-Change-Number: 7674109
      Gerrit-PatchSet: 1
      Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
      Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Attention: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Comment-Date: Tue, 17 Mar 2026 18:17:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Sean O'Brien <seob...@chromium.org>
      satisfied_requirement
      open
      diffy

      Vincent Chiang (Gerrit)

      unread,
      Mar 17, 2026, 2:19:03 PMMar 17
      to Sean O'Brien, Chromium LUCI CQ, Rubber Stamper, AyeAye, ozone-...@chromium.org

      Vincent Chiang voted and added 1 comment

      Votes added by Vincent Chiang

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Sean O'Brien . resolved

      Just realized this is a cherry pick - no need to resolve nit.

      Vincent Chiang

      Thank you!

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7680
      Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
      Gerrit-Change-Number: 7674109
      Gerrit-PatchSet: 1
      Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
      Gerrit-Reviewer: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Comment-Date: Tue, 17 Mar 2026 18:18:53 +0000
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 17, 2026, 3:36:14 PMMar 17
      to Vincent Chiang, Sean O'Brien, Rubber Stamper, AyeAye, ozone-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [M146] Compensate tablet input with panel orientation

      Add rotation logic to TabletEventConverterEvdev so devices with none-0
      panel orientation can use tablet devices. The change adds a transform
      to tablet input coordinates before updating cursor location.

      (cherry picked from commit e824c7895e1a0ea952409a06a1a401e08487613c)
      Bug: b:487118330, b:162444998
      Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
      Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
      Commit-Queue: Vincent Chiang <vincen...@chromium.org>
      Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>
      Cr-Original-Commit-Position: refs/heads/main@{#1598230}
      Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Reviewed-by: Sean O'Brien <seob...@chromium.org>
      Cr-Commit-Position: refs/branch-heads/7680@{#2743}
      Cr-Branched-From: 76b7d80e5cda23fe6537eed26d68c92e995c7f39-refs/heads/main@{#1582197}
      Files:
      • M ui/events/ozone/evdev/BUILD.gn
      • M ui/events/ozone/evdev/tablet_event_converter_evdev.cc
      • M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
      Change size: M
      Delta: 3 files changed, 176 insertions(+), 11 deletions(-)
      Branch: refs/branch-heads/7680
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Sean O'Brien, Bot-Commit+1 by Rubber Stamper
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7680
      Gerrit-Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
      Gerrit-Change-Number: 7674109
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vincent Chiang <vincen...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages