Thomas Anderson (Gerrit)

unread,

Jan 21, 2026, 12:21:46 PM (12 days ago) Jan 21

to Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Thomas Anderson voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jan 21, 2026, 2:30:17 PM (11 days ago) Jan 21

to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Thomas Anderson

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kramer Ge . resolved

Thank you

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 21, 2026, 2:35:20 PM (11 days ago) Jan 21

to Thomas Anderson, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Wayland] Allow non-square icons for xdg-toplevel-icon

Non-square icons will be letterboxed or pillarboxed with transparent
pixels to pad to a square.

R=fangzhoug

Fixed: 472402541

Change-Id: Ic5f86cb34b106a59c4bde621c4e6f184f39f9ef6

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7504855

Auto-Submit: Thomas Anderson <thomasa...@chromium.org>

Commit-Queue: Kramer Ge <fang...@chromium.org>

Reviewed-by: Kramer Ge <fang...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1572475}

Files:

M ui/ozone/platform/wayland/host/xdg_toplevel.cc
M ui/ozone/platform/wayland/host/xdg_toplevel_icon_unittest.cc

Change size: S

Delta: 2 files changed, 36 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kramer Ge

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Wayland] Allow non-square icons for xdg-toplevel-icon [chromium/src : main]

Thomas Anderson (Gerrit)

Thomas Anderson voted

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information