Remove base::NotFatalUntil::M130 usage [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
May 24, 2025, 6:52:10 AM5/24/25
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, David Worsham, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Tommy Li, Ian Vollick, Wanming Lin, James Maclean, Yoav Weiss (@Shopify), Zijie He, abigailbk...@google.com, alandin...@chromium.org, aleventhal...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cblume...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, cros-ed...@google.com, cros-print...@google.com, crostin...@chromium.org, devtools-re...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, djacob...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, emi...@google.com, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, gcasto+w...@chromium.org, geoffla...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pmonett...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org
Attention needed from Lei Zhang

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Daniel Cheng . resolved

Unfortunately, this one is huge. It is also completely autogenerated; if you want to reproduce this with the script, you should get an exact match (after running git cl format as well).

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6de2094c1779e047252e2bb24e665113913721bc
Gerrit-Change-Number: 6579713
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Sat, 24 May 2025 10:52:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyle Charbonneau (Gerrit)

unread,
May 26, 2025, 2:20:04 PM5/26/25
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, David Worsham, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Tommy Li, Ian Vollick, Wanming Lin, James Maclean, Yoav Weiss (@Shopify), Zijie He, abigailbk...@google.com, alandin...@chromium.org, aleventhal...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cblume...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, cros-ed...@google.com, cros-print...@google.com, crostin...@chromium.org, devtools-re...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, djacob...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, emi...@google.com, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, gcasto+w...@chromium.org, geoffla...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pmonett...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org
Attention needed from Daniel Cheng

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

Code-Review+1
Owners-Override+1

1 comment

File components/performance_manager/execution_context_priority/override_vote_aggregator.cc
Line 7, Patchset 3 (Latest):
Kyle Charbonneau . unresolved

This produced double a new line. Maybe it's something the script should check for?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6de2094c1779e047252e2bb24e665113913721bc
Gerrit-Change-Number: 6579713
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 26 May 2025 18:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
May 26, 2025, 4:25:43 PM5/26/25
to Daniel Cheng, Kyle Charbonneau, Lei Zhang, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, David Worsham, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Tommy Li, Ian Vollick, Wanming Lin, James Maclean, Yoav Weiss (@Shopify), Zijie He, abigailbk...@google.com, alandin...@chromium.org, aleventhal...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cblume...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, cros-ed...@google.com, cros-print...@google.com, crostin...@chromium.org, devtools-re...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, djacob...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, emi...@google.com, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, gcasto+w...@chromium.org, geoffla...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pmonett...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Commit-Queue+2

1 comment

File components/performance_manager/execution_context_priority/override_vote_aggregator.cc
Line 7, Patchset 3:
Kyle Charbonneau . resolved

This produced double a new line. Maybe it's something the script should check for?

Daniel Cheng

Done, thanks for catching this!

... maybe but I mostly rely on git cl format to fix things. I guess this is one of those things clang-format tends to leave alone, since there's not always a reliable heuristic one way or another.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6de2094c1779e047252e2bb24e665113913721bc
Gerrit-Change-Number: 6579713
Gerrit-PatchSet: 5
Gerrit-Comment-Date: Mon, 26 May 2025 20:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyle Charbonneau <kyle...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 26, 2025, 6:59:44 PM5/26/25
to Daniel Cheng, Kyle Charbonneau, Lei Zhang, Akihiro Ota, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, David Worsham, Enterprise Policy Reviews, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Tommy Li, Ian Vollick, Wanming Lin, James Maclean, Yoav Weiss (@Shopify), Zijie He, abigailbk...@google.com, alandin...@chromium.org, aleventhal...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cblume...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, chlily...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chrome-waff...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, cros-ed...@google.com, cros-print...@google.com, crostin...@chromium.org, devtools-re...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, djacob...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, emi...@google.com, enne...@chromium.org, eric.c...@apple.com, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, gcasto+w...@chromium.org, geoffla...@chromium.org, gogerald+pa...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jackshira+w...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mahmad...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mbarowsky+watc...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, npnavarro+p...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdr+svgw...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, pmonett...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, steimel+...@chromium.org, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, tburkar...@chromium.org, tmartino+tran...@chromium.org, tommyw+w...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org, zhangwen...@google.com, zol...@webkit.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: components/performance_manager/execution_context_priority/override_vote_aggregator.cc
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Remove base::NotFatalUntil::M130 usage

As of May 2025, this is always fatal.
Autogenerated with base/tools/clean-up-not-fatal-until.py -m 130
Bug: 419922502
Change-Id: I6de2094c1779e047252e2bb24e665113913721bc
Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Owners-Override: Kyle Charbonneau <kyle...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1465680}
Files:
  • M android_webview/browser/gfx/overlay_processor_webview.cc
  • M android_webview/browser/lifecycle/aw_contents_lifecycle_notifier.cc
  • M android_webview/renderer/aw_render_view_ext.cc
  • M apps/saved_files_service.cc
  • M cc/layers/layer.cc
  • M cc/paint/paint_cache.cc
  • M cc/raster/task_graph_work_queue.cc
  • M cc/resources/resource_pool.cc
  • M cc/slim/frame_sink_impl.cc
  • M cc/slim/layer.cc
  • M cc/test/animation_timelines_test_common.cc
  • M cc/tiles/checker_image_tracker.cc
  • M cc/tiles/gpu_image_decode_cache.cc
  • M cc/tiles/image_controller.cc
  • M cc/tiles/software_image_decode_cache.cc
  • M cc/trees/image_animation_controller.cc
  • M cc/trees/layer_tree_host.cc
  • M cc/trees/layer_tree_host_impl.cc
  • M cc/trees/layer_tree_impl.cc
  • M chrome/browser/android/httpclient/http_client.cc
  • M chrome/browser/android/metrics/android_session_durations_service.cc
  • M chrome/browser/apps/app_service/app_icon/app_icon_reader.cc
  • M chrome/browser/apps/app_service/app_notifications.cc
  • M chrome/browser/apps/app_service/app_service_proxy_ash.cc
  • M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
  • M chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc
  • M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc
  • M chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
  • M chrome/browser/devtools/chrome_devtools_manager_delegate.cc
  • M chrome/browser/devtools/device/devtools_android_bridge.cc
  • M chrome/browser/devtools/devtools_ui_bindings.cc
  • M chrome/browser/devtools/devtools_window.cc
  • M chrome/browser/download/chrome_download_manager_delegate.cc
  • M chrome/browser/download/download_history.cc
  • M chrome/browser/download/notification/multi_profile_download_notifier.cc
  • M chrome/browser/enterprise/connectors/analysis/files_request_handler.cc
  • M chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
  • M chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
  • M chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
  • M chrome/browser/extensions/api/messaging/incognito_connectability.cc
  • M chrome/browser/extensions/api/passwords_private/passwords_private_utils.cc
  • M chrome/browser/extensions/api/web_authentication_proxy/web_authentication_proxy_api.cc
  • M chrome/browser/extensions/chrome_app_icon_service.cc
  • M chrome/browser/extensions/device_permissions_dialog_controller.cc
  • M chrome/browser/extensions/extension_assets_manager_chromeos.cc
  • M chrome/browser/extensions/updater/extension_updater.cc
  • M chrome/browser/image_fetcher/image_decoder_impl.cc
  • M chrome/browser/intranet_redirect_detector.cc
  • M chrome/browser/media/router/providers/cast/cast_app_availability_tracker.cc
  • M chrome/browser/media/router/providers/dial/dial_activity_manager.cc
  • M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
  • M chrome/browser/media_galleries/fileapi/mtp_device_map_service.cc
  • M chrome/browser/media_galleries/media_file_system_registry.cc
  • M chrome/browser/media_galleries/media_galleries_permission_controller.cc
  • M chrome/browser/metrics/power/process_monitor.cc
  • M chrome/browser/metrics/usage_scenario/tab_usage_scenario_tracker.cc
  • M chrome/browser/notifications/notification_channels_provider_android_unittest.cc
  • M chrome/browser/notifications/scheduler/internal/display_decider.cc
  • M chrome/browser/performance_manager/user_tuning/profile_discard_opt_out_list_helper.cc
  • M chrome/browser/performance_monitor/system_monitor.cc
  • M chrome/browser/predictors/preconnect_manager.cc
  • M chrome/browser/predictors/prefetch_manager.cc
  • M chrome/browser/printing/print_backend_service_manager.cc
  • M chrome/browser/profiles/profile_destroyer.cc
  • M chrome/browser/profiles/profile_manager.cc
  • M chrome/browser/push_messaging/push_messaging_refresher.cc
  • M chrome/browser/resource_coordinator/session_restore_policy.cc
  • M chrome/browser/resource_coordinator/tab_load_tracker.cc
  • M chrome/browser/safe_browsing/download_protection/download_protection_service.cc
  • M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
  • M chrome/browser/sessions/tab_loader.cc
  • M chrome/browser/signin/chrome_signin_proxying_url_loader_factory.cc
  • M chrome/browser/sync/test/integration/bookmarks_helper.cc
  • M chrome/browser/task_manager/mock_web_contents_task_manager.cc
  • M chrome/browser/task_manager/providers/per_profile_worker_task_tracker.cc
  • M chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc
  • M chrome/browser/task_manager/providers/worker_task_provider.cc
  • M chrome/browser/task_manager/sampling/task_manager_impl.cc
  • M chrome/browser/trusted_vault/trusted_vault_client_android.cc
  • M chrome/browser/ui/android/device_dialog/serial_chooser_dialog_android.cc
  • M chrome/browser/ui/android/device_dialog/usb_chooser_dialog_android.cc
  • M chrome/browser/ui/android/hats/hats_service_android.cc
  • M chrome/browser/ui/hats/hats_service_desktop.cc
  • M chrome/browser/ui/hid/hid_chooser_controller.cc
  • M chrome/browser/ui/hung_plugin_tab_helper.cc
  • M chrome/browser/ui/tabs/saved_tab_groups/saved_tab_group_utils.cc
  • M chrome/browser/ui/tabs/tab_strip_model.cc
  • M chrome/browser/ui/thumbnails/thumbnail_image.cc
  • M chrome/browser/ui/thumbnails/thumbnail_scheduler_impl.cc
  • M chrome/browser/ui/toolbar/toolbar_actions_model.cc
  • M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
  • M chrome/browser/ui/views/download/bubble/download_bubble_row_view.cc
  • M chrome/browser/ui/views/download/download_shelf_view.cc
  • M chrome/browser/ui/views/extensions/extensions_menu_view.cc
  • M chrome/browser/ui/views/extensions/extensions_toolbar_container.cc
  • M chrome/browser/ui/views/global_media_controls/media_item_ui_device_selector_view.cc
  • M chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc
  • M chrome/browser/ui/views/payments/editor_view_controller.cc
  • M chrome/browser/ui/views/profiles/profile_picker_view.cc
  • M chrome/browser/ui/views/toolbar/app_menu.cc
  • M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container.cc
  • M chrome/browser/ui/webui/discards/graph_dump_impl.cc
  • M chrome/browser/usb/usb_chooser_controller.cc
  • M chrome/browser/vr/webxr_vr_input_browser_test.cc
  • M chrome/browser/web_applications/external_install_options.cc
  • M chrome/browser/web_applications/externally_managed_app_manager.cc
  • M chrome/browser/web_applications/locks/partitioned_lock_manager.cc
  • M chrome/browser/win/conflicts/incompatible_applications_updater.cc
  • M chrome/browser/win/conflicts/module_blocklist_cache_updater.cc
  • M chrome/browser/win/conflicts/module_database.cc
  • M chrome/services/printing/print_backend_service_impl.cc
  • M chrome/test/base/testing_profile_manager.cc
  • M chromecast/base/device_capabilities_impl.cc
  • M chromecast/cast_core/runtime/browser/core_streaming_config_manager.cc
  • M chromecast/device/bluetooth/le/remote_characteristic_impl.cc
  • M chromecast/device/bluetooth/le/remote_device_impl.cc
  • M chromecast/renderer/feature_manager.cc
  • M chromeos/components/sensors/fake_sensor_device.cc
  • M chromeos/ui/base/file_icon_util.cc
  • M components/account_manager_core/chromeos/account_manager.cc
  • M components/app_restore/restore_data.cc
  • M components/background_fetch/background_fetch_delegate_base.cc
  • M components/bookmarks/browser/url_index.cc
  • M components/browsing_data/content/browsing_data_model.cc
  • M components/cdm/browser/media_drm_storage_impl.cc
  • M components/chromeos_camera/mojo_jpeg_encode_accelerator_service.cc
  • M components/content_settings/core/browser/content_settings_pref_provider.cc
  • M components/content_settings/core/browser/content_settings_rule.cc
  • M components/content_settings/core/common/cookie_settings_base.cc
  • M components/domain_reliability/context.cc
  • M components/domain_reliability/dispatcher.cc
  • M components/domain_reliability/uploader.cc
  • M components/download/internal/background_service/model_impl.cc
  • M components/download/internal/common/parallel_download_job.cc
  • M components/drive/service/fake_drive_service.cc
  • M components/exo/buffer.cc
  • M components/exo/client_controlled_accelerators.cc
  • M components/exo/data_offer.cc
  • M components/exo/frame_timing_history.cc
  • M components/exo/surface.cc
  • M components/exo/wayland/clients/rects.cc
  • M components/exo/wayland/clients/simple.cc
  • M components/feature_engagement/internal/chrome_variations_configuration.cc
  • M components/feature_engagement/internal/display_lock_controller_impl.cc
  • M components/feature_engagement/internal/editable_configuration.cc
  • M components/gcm_driver/crypto/gcm_encryption_provider.cc
  • M components/gcm_driver/gcm_client_impl.cc
  • M components/gcm_driver/gcm_driver_desktop.cc
  • M components/global_media_controls/public/media_session_item_producer.cc
  • M components/history/core/browser/visit_database.cc
  • M components/history_clusters/core/similar_visit_deduper_cluster_finalizer.cc
  • M components/image_fetcher/core/image_data_fetcher.cc
  • M components/image_fetcher/core/image_fetcher_impl.cc
  • M components/media_router/common/providers/cast/channel/cast_message_handler.cc
  • M components/mirroring/browser/single_client_video_capture_host.cc
  • M components/no_state_prefetch/browser/no_state_prefetch_manager.cc
  • M components/omnibox/browser/favicon_cache.cc
  • M components/omnibox/browser/history_fuzzy_provider.cc
  • M components/omnibox/browser/history_url_provider.cc
  • M components/omnibox/browser/url_index_private_data.cc
  • M components/optimization_guide/core/prediction_manager.cc
  • M components/paint_preview/common/paint_preview_tracker.cc
  • M components/password_manager/core/browser/affiliation/affiliated_match_helper.cc
  • M components/password_manager/core/browser/form_parsing/form_data_parser.cc
  • M components/password_manager/core/browser/import/csv_password_sequence.cc
  • M components/payments/content/installable_payment_app_crawler.cc
  • M components/payments/core/payment_manifest_downloader.cc
  • M components/performance_manager/execution_context_priority/boosting_vote_aggregator.cc
  • M components/performance_manager/execution_context_priority/inherit_client_priority_voter.cc
  • M components/performance_manager/execution_context_priority/max_vote_aggregator.cc
  • M components/performance_manager/execution_context_priority/override_vote_aggregator.cc
  • M components/performance_manager/performance_manager_registry_impl.cc
  • M components/performance_manager/performance_manager_tab_helper.cc
  • M components/performance_manager/public/voting/voting.h
  • M components/performance_manager/tab_helper_frame_node_source.cc
  • M components/performance_manager/test_support/voting.h
  • M components/performance_manager/v8_memory/v8_context_tracker_internal.cc
  • M components/performance_manager/worker_watcher.cc
  • M components/permissions/android/permissions_reprompt_controller_android.cc
  • M components/permissions/bluetooth_chooser_controller.cc
  • M components/permissions/bluetooth_scanning_prompt_controller.cc
  • M components/permissions/permission_context_base.cc
  • M components/policy/core/browser/url_blocklist_manager.cc
  • M components/policy/test_support/client_storage.cc
  • M components/safe_browsing/core/browser/db/v4_database.cc
  • M components/safe_browsing/core/browser/db/v4_get_hash_protocol_manager.cc
  • M components/safe_browsing/core/browser/db/v4_local_database_manager.cc
  • M components/safe_browsing/core/browser/ping_manager.cc
  • M components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc
  • M components/search_engines/template_url_fetcher.cc
  • M components/search_engines/util.cc
  • M components/segmentation_platform/internal/metadata/metadata_utils.cc
  • M components/services/storage/dom_storage/session_storage_namespace_impl.cc
  • M components/services/storage/service_worker/service_worker_disk_cache.cc
  • M components/services/storage/service_worker/service_worker_storage_control_impl.cc
  • M components/signin/internal/identity_manager/fake_profile_oauth2_token_service_delegate.cc
  • M components/storage_monitor/portable_device_watcher_win.cc
  • M components/storage_monitor/storage_monitor_linux.cc
  • M components/sync/engine/cycle/nudge_tracker.cc
  • M components/sync/engine/get_updates_processor.cc
  • M components/sync/engine/loopback_server/loopback_server.cc
  • M components/sync/service/model_load_manager.cc
  • M components/sync_device_info/fake_device_info_tracker.cc
  • M components/sync_sessions/tab_node_pool.cc
  • M components/ui_devtools/devtools_server.cc
  • M components/ui_devtools/ui_element.cc
  • M components/ui_devtools/views/window_element.cc
  • M components/url_pattern_index/url_pattern_index.cc
  • M components/value_store/test_value_store_factory.cc
  • M components/viz/client/client_resource_provider.cc
  • M components/viz/host/client_frame_sink_video_capturer.cc
  • M components/viz/host/host_frame_sink_manager.cc
  • M components/viz/service/display/display_resource_provider.cc
  • M components/viz/service/display/display_resource_provider_null.cc
  • M components/viz/service/display/display_resource_provider_skia.cc
  • M components/viz/service/display/skia_renderer.cc
  • M components/viz/service/display/software_renderer.cc
  • M components/viz/service/display_embedder/skia_output_device_buffer_queue.cc
  • M components/viz/service/surfaces/surface_allocation_group.cc
  • M components/viz/service/surfaces/surface_manager.cc
  • M components/viz/test/fake_skia_output_surface.cc
  • M components/web_package/web_bundle_parser.cc
  • M components/webui/flags/flags_state.cc
  • M components/wifi/wifi_service_win.cc
  • M content/browser/android/content_view_statics.cc
  • M content/browser/background_fetch/background_fetch_job_controller.cc
  • M content/browser/background_fetch/background_fetch_scheduler.cc
  • M content/browser/background_sync/background_sync_context_impl.cc
  • M content/browser/browser_child_process_host_impl.cc
  • M content/browser/browser_url_handler_impl.cc
  • M content/browser/cache_storage/cache_storage.cc
  • M content/browser/cache_storage/cache_storage_index.cc
  • M content/browser/cache_storage/cache_storage_manager.cc
  • M content/browser/cache_storage/cache_storage_scheduler.cc
  • M content/browser/child_process_security_policy_impl.cc
  • M content/browser/code_cache/generated_code_cache.cc
  • M content/browser/code_cache/simple_lru_cache.cc
  • M content/browser/cookie_store/cookie_store_manager.cc
  • M content/browser/download/save_package.cc
  • M content/browser/fenced_frame/fenced_frame_reporter.cc
  • M content/browser/fenced_frame/fenced_frame_url_mapping.cc
  • M content/browser/indexed_db/indexed_db_context_impl.cc
  • M content/browser/indexed_db/instance/leveldb/tombstone_sweeper.cc
  • M content/browser/indexed_db/list_set.h
  • M content/browser/interest_group/ad_auction_service_impl.cc
  • M content/browser/interest_group/auction_process_manager.cc
  • M content/browser/interest_group/auction_worklet_manager.cc
  • M content/browser/interest_group/subresource_url_authorizations.cc
  • M content/browser/media/media_internals_audio_focus_helper.cc
  • M content/browser/media/session/media_players_callback_aggregator_unittest.cc
  • M content/browser/mojo_binder_policy_map_impl.cc
  • M content/browser/renderer_host/frame_tree.cc
  • M content/browser/renderer_host/media/media_stream_manager.cc
  • M content/browser/renderer_host/media/video_capture_controller.cc
  • M content/browser/renderer_host/pepper/pepper_network_proxy_host.cc
  • M content/browser/renderer_host/render_frame_host_impl_ppapi_support.cc
  • M content/browser/renderer_host/render_process_host_impl.cc
  • M content/browser/renderer_host/render_view_host_impl.cc
  • M content/browser/service_host/service_process_tracker.cc
  • M content/browser/service_worker/service_worker_context_core.cc
  • M content/browser/service_worker/service_worker_job_coordinator.cc
  • M content/browser/service_worker/service_worker_registry.cc
  • M content/browser/service_worker/service_worker_script_cache_map.cc
  • M content/browser/service_worker/service_worker_version.cc
  • M content/browser/shared_storage/shared_storage_worklet_host.cc
  • M content/browser/speech/speech_recognition_manager_impl.cc
  • M content/browser/web_contents/web_contents_view_aura.cc
  • M content/browser/worker_host/dedicated_worker_service_impl.cc
  • M content/browser/worker_host/shared_worker_service_impl.cc
  • M content/browser/xr/service/xr_runtime_manager_impl.cc
  • M content/renderer/media/media_permission_dispatcher.cc
  • M content/renderer/pepper/host_var_tracker.cc
  • M content/renderer/pepper/pepper_plugin_instance_impl.cc
  • M content/renderer/pepper/pepper_video_decoder_host.cc
  • M content/renderer/pepper/ppb_graphics_3d_impl.cc
  • M content/services/auction_worklet/auction_v8_devtools_agent.cc
  • M content/services/auction_worklet/auction_v8_helper.cc
  • M content/services/auction_worklet/direct_from_seller_signals_requester.cc
  • M crypto/nss_util_chromeos.cc
  • M device/bluetooth/adapter.cc
  • M device/bluetooth/bluetooth_adapter_win.cc
  • M device/bluetooth/test/fake_bluetooth_le_device_winrt.cc
  • M device/fido/virtual_ctap2_device.cc
  • M device/vr/android/arcore/ar_compositor_frame_sink.cc
  • M extensions/browser/api/declarative_net_request/regex_rules_matcher.cc
  • M extensions/browser/api/declarative_net_request/ruleset_manager.cc
  • M extensions/browser/api/declarative_net_request/test_utils.cc
  • M extensions/browser/api/execute_code_function.cc
  • M extensions/browser/api/hid/hid_device_manager.cc
  • M extensions/browser/api/offscreen/lifetime_enforcer_factories.cc
  • M extensions/browser/api/offscreen/offscreen_document_manager.cc
  • M extensions/browser/api/serial/serial_apitest.cc
  • M extensions/browser/api/web_request/web_request_api.cc
  • M extensions/browser/api/web_request/web_request_api_helpers.cc
  • M extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
  • M extensions/browser/api/web_request/web_request_time_tracker.cc
  • M extensions/browser/app_window/app_window_geometry_cache.cc
  • M extensions/browser/content_verifier/content_verifier.cc
  • M extensions/browser/embedder_user_script_loader.cc
  • M extensions/browser/extension_function.cc
  • M extensions/browser/guest_view/web_view/web_view_find_helper.cc
  • M extensions/common/event_filter.cc
  • M extensions/renderer/bindings/api_bindings_system.cc
  • M extensions/renderer/bindings/listener_tracker.cc
  • M extensions/renderer/native_extension_bindings_system.cc
  • M extensions/shell/browser/root_window_controller_unittest.cc
  • M extensions/shell/browser/shell_desktop_controller_aura.cc
  • M fuchsia_web/runners/cast/cast_runner.cc
  • M fuchsia_web/webengine/browser/context_impl.cc
  • M google_apis/drive/drive_api_requests.cc
  • M gpu/command_buffer/client/client_discardable_texture_manager.cc
  • M gpu/command_buffer/client/client_font_manager.cc
  • M gpu/command_buffer/client/fenced_allocator.cc
  • M gpu/command_buffer/service/framebuffer_manager.cc
  • M gpu/command_buffer/service/gles2_external_framebuffer.cc
  • M gpu/command_buffer/service/image_reader_gl_owner.cc
  • M gpu/command_buffer/service/passthrough_discardable_manager.cc
  • M gpu/command_buffer/service/query_manager.cc
  • M gpu/command_buffer/service/shared_image/external_vk_image_backing.cc
  • M gpu/command_buffer/service/shared_image/ozone_image_backing.cc
  • M gpu/command_buffer/service/shared_image/shared_image_backing.cc
  • M gpu/command_buffer/service/webgpu_decoder_impl.cc
  • M gpu/config/gpu_control_list.cc
  • M gpu/ipc/host/gpu_disk_cache.cc
  • M gpu/vulkan/tests/native_window.cc
  • M gpu/vulkan/tests/native_window_win.cc
  • M headless/lib/browser/headless_devtools_manager_delegate.cc
  • M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/clear_browsing_data_table_view_controller.mm
  • M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/base_grid_mediator.mm
  • M mojo/core/ipcz_driver/mojo_trap.cc
  • M mojo/core/ports/node.cc
  • M mojo/public/cpp/bindings/lib/sync_handle_registry.cc
  • M mojo/public/cpp/bindings/receiver_set.cc
  • M mojo/public/cpp/system/wait_set.cc
  • M net/base/priority_queue.h
  • M net/cert/coalescing_cert_verifier.cc
  • M net/cert_net/cert_net_fetcher_url_request.cc
  • M net/cookies/cookie_monster_change_dispatcher.cc
  • M net/disk_cache/simple/simple_file_tracker.cc
  • M net/disk_cache/simple/simple_index.cc
  • M net/dns/host_resolver_dns_task.cc
  • M net/dns/host_resolver_manager.cc
  • M net/dns/host_resolver_manager_job.cc
  • M net/dns/httpssvc_metrics.cc
  • M net/dns/mdns_client_impl.cc
  • M net/dns/system_dns_config_change_notifier.cc
  • M net/first_party_sets/global_first_party_sets.cc
  • M net/http/http_auth_cache.cc
  • M net/http/http_cache.cc
  • M net/http/http_cache_writers.cc
  • M net/log/net_log.cc
  • M net/network_error_logging/network_error_logging_service.cc
  • M net/proxy_resolution/mock_proxy_resolver.cc
  • M net/proxy_resolution/win/proxy_config_service_win.cc
  • M net/quic/quic_chromium_client_stream.cc
  • M net/quic/quic_session_pool.cc
  • M net/quic/quic_session_pool_job.cc
  • M net/reporting/reporting_cache_impl.cc
  • M net/reporting/reporting_uploader.cc
  • M net/socket/transport_client_socket_pool.cc
  • M net/spdy/http2_priority_dependencies.cc
  • M net/spdy/spdy_session_pool.cc
  • M net/tools/huffman_trie/trie/trie_bit_buffer.cc
  • M ppapi/proxy/audio_encoder_resource.cc
  • M ppapi/proxy/nacl_message_scanner.cc
  • M ppapi/proxy/plugin_resource_tracker.cc
  • M ppapi/proxy/plugin_var_tracker.cc
  • M ppapi/proxy/video_encoder_resource.cc
  • M ppapi/shared_impl/callback_tracker.cc
  • M ppapi/shared_impl/ppb_video_decoder_shared.cc
  • M printing/metafile_skia.cc
  • M services/audio/group_coordinator-impl.h
  • M services/audio/loopback_stream.cc
  • M services/audio/mixing_graph_impl.cc
  • M services/audio/output_controller.cc
  • M services/audio/output_device_mixer_impl.cc
  • M services/audio/stream_factory.cc
  • M services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc
  • M services/data_decoder/public/cpp/safe_web_bundle_parser.cc
  • M services/device/generic_sensor/platform_sensor_provider_chromeos.cc
  • M services/device/geolocation/geolocation_context.cc
  • M services/device/hid/hid_connection_win.cc
  • M services/device/public/cpp/test/fake_serial_port_manager.cc
  • M services/device/public/cpp/test/test_wake_lock_provider.cc
  • M services/device/serial/fake_serial_device_enumerator.cc
  • M services/device/serial/serial_device_enumerator.cc
  • M services/device/usb/usb_device_handle_usbfs.cc
  • M services/device/usb/usb_device_handle_win.cc
  • M services/device/usb/usb_service.cc
  • M services/device/wake_lock/wake_lock_provider.cc
  • M services/network/cors/cors_url_loader_factory.h
  • M services/network/cors/preflight_controller.cc
  • M services/network/host_resolver.cc
  • M services/network/keepalive_statistics_recorder.cc
  • M services/network/mdns_responder.cc
  • M services/network/network_context.cc
  • M services/network/network_service.cc
  • M services/network/oblivious_http_request_handler.cc
  • M services/network/p2p/socket_manager.cc
  • M services/network/trust_tokens/in_memory_trust_token_persister.cc
  • M services/network/url_loader_util.cc
  • M services/on_device_model/on_device_model_service.cc
  • M services/proxy_resolver/proxy_host_resolver_cache.cc
  • M services/proxy_resolver_win/windows_system_proxy_resolver_impl.cc
  • M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
  • M services/service_manager/service_manager.cc
  • M storage/browser/blob/blob_registry_impl.cc
  • M storage/browser/file_system/isolated_context.cc
  • M storage/browser/file_system/sandbox_origin_database.cc
  • M storage/browser/test/mock_quota_client.cc
  • M third_party/blink/renderer/controller/highest_pmf_reporter_test.cc
  • M third_party/blink/renderer/core/css/resolver/style_cascade.cc
  • M third_party/blink/renderer/core/dom/live_node_list_registry.cc
  • M third_party/blink/renderer/core/highlight/highlight.cc
  • M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
  • M third_party/blink/renderer/core/html/forms/radio_button_group_scope.cc
  • M third_party/blink/renderer/core/html/media/html_media_element.cc
  • M third_party/blink/renderer/core/inspector/inspector_media_context_impl.cc
  • M third_party/blink/renderer/core/layout/column_layout_algorithm.cc
  • M third_party/blink/renderer/core/layout/flex/flex_layout_algorithm.cc
  • M third_party/blink/renderer/core/layout/inline/fragment_items_builder.cc
  • M third_party/blink/renderer/core/layout/inline/inline_cursor.cc
  • M third_party/blink/renderer/core/layout/layout_multi_column_flow_thread.cc
  • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
  • M third_party/blink/renderer/core/loader/modulescript/module_script_loader_registry.cc
  • M third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
  • M third_party/blink/renderer/core/loader/resource/image_resource_content.cc
  • M third_party/blink/renderer/core/paint/highlight_painter.cc
  • M third_party/blink/renderer/core/speculation_rules/document_speculation_rules.cc
  • M third_party/blink/renderer/core/svg/animation/smil_animation_sandwich.cc
  • M third_party/blink/renderer/core/timing/event_counts.cc
  • M third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
  • M third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
  • M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer.cc
  • M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_manager.cc
  • M third_party/blink/renderer/modules/mediastream/browser_capture_media_stream_track.cc
  • M third_party/blink/renderer/modules/mediastream/media_devices.cc
  • M third_party/blink/renderer/modules/mediastream/media_stream_video_track.cc
  • M third_party/blink/renderer/modules/mediastream/user_media_processor.cc
  • M third_party/blink/renderer/modules/peerconnection/mock_peer_connection_dependency_factory.cc
  • M third_party/blink/renderer/modules/remote_objects/remote_object_gateway_impl.cc
  • M third_party/blink/renderer/modules/screen_details/screen_details.cc
  • M third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
  • M third_party/blink/renderer/modules/service_worker/service_worker_installed_scripts_manager.cc
  • M third_party/blink/renderer/modules/service_worker/thread_safe_script_container.cc
  • M third_party/blink/renderer/modules/storage/cached_storage_area.cc
  • M third_party/blink/renderer/modules/wake_lock/wake_lock_manager.cc
  • M third_party/blink/renderer/modules/webcodecs/video_frame_monitor.cc
  • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
  • M third_party/blink/renderer/modules/webusb/usb_device.cc
  • M third_party/blink/renderer/modules/xr/xr_frame_provider.cc
  • M third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.cc
  • M third_party/blink/renderer/modules/xr/xr_plane_manager.cc
  • M third_party/blink/renderer/modules/xr/xr_session.cc
  • M third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
  • M third_party/blink/renderer/platform/disk_data_allocator.cc
  • M third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
  • M third_party/blink/renderer/platform/graphics/image_decoding_store.cc
  • M third_party/blink/renderer/platform/graphics/image_frame_generator.cc
  • M third_party/blink/renderer/platform/graphics/parkable_image_manager.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
  • M third_party/blink/renderer/platform/loader/fetch/shared_buffer_bytes_consumer.cc
  • M third_party/blink/renderer/platform/media/interval_map.h
  • M third_party/blink/renderer/platform/media/multi_buffer.cc
  • M third_party/blink/renderer/platform/peerconnection/two_keys_adapter_map.h
  • M third_party/blink/renderer/platform/scheduler/common/frame_or_worker_scheduler.cc
  • M third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.cc
  • M third_party/blink/renderer/platform/scheduler/main_thread/pending_user_input.cc
  • M ui/accessibility/ax_event_generator.cc
  • M ui/accessibility/ax_tree.cc
  • M ui/accessibility/platform/ax_platform_node_auralinux.cc
  • M ui/accessibility/platform/fuchsia/accessibility_bridge_fuchsia_registry.cc
  • M ui/android/view_android.cc
  • M ui/aura/window.cc
  • M ui/aura/window_occlusion_tracker.cc
  • M ui/base/accelerators/global_accelerator_listener/global_accelerator_listener.cc
  • M ui/base/accelerators/global_accelerator_listener/global_accelerator_listener_win.cc
  • M ui/base/interaction/element_tracker.cc
  • M ui/base/interaction/interaction_sequence.cc
  • M ui/compositor/compositor.cc
  • M ui/compositor/layer.cc
  • M ui/display/display_layout.cc
  • M ui/display/display_list.cc
  • M ui/display/manager/display_change_observer.cc
  • M ui/display/unified_desktop_utils.cc
  • M ui/gfx/sequential_id_generator.cc
  • M ui/gfx/system_fonts_win.cc
  • M ui/gtk/nav_button_provider_gtk.cc
  • M ui/message_center/message_center_stats_collector.cc
  • M ui/message_center/notification_list.cc
  • M ui/ozone/platform/drm/common/drm_util.cc
  • M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
  • M ui/ozone/platform/drm/gpu/screen_manager.cc
  • M ui/ozone/platform/flatland/flatland_surface.cc
  • M ui/ozone/platform/flatland/flatland_surface_factory.cc
  • M ui/ozone/platform/headless/headless_screen.cc
  • M ui/ozone/platform/wayland/host/proxy/wayland_proxy_impl.cc
  • M ui/ozone/platform/wayland/host/wayland_buffer_handle.cc
  • M ui/ozone/platform/wayland/host/wayland_surface.cc
  • M ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
  • M ui/ozone/platform/wayland/host/xdg_foreign_wrapper.cc
  • M ui/ozone/platform/wayland/test/mock_surface.cc
  • M ui/ozone/platform/wayland/test/mock_wayland_zcr_color_manager.cc
  • M ui/ozone/platform/wayland/test/mock_zwp_linux_dmabuf.cc
  • M ui/ozone/platform/x11/x11_window_manager.cc
  • M ui/views/animation/bounds_animator.cc
  • M ui/views/interaction/element_tracker_views.cc
  • M ui/views/layout/flex_layout.cc
  • M ui/views/layout/layout_manager_base.cc
  • M ui/views/view.cc
  • M ui/views/win/scoped_fullscreen_visibility.cc
  • M ui/wm/core/transient_window_manager.cc
  • M ui/wm/core/window_animations.cc
Change size: XL
Delta: 514 files changed, 800 insertions(+), 1408 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kyle Charbonneau
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6de2094c1779e047252e2bb24e665113913721bc
Gerrit-Change-Number: 6579713
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages