Compensate tablet input with panel orientation [chromium/src : main]
0 views
Skip to first unread message
Vincent Chiang (Gerrit)
Mar 4, 2026, 9:26:56 PM (8 days ago) Mar 4
to Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima
Vincent Chiang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Achuith Bhandarkar (Gerrit)
Mar 5, 2026, 8:48:19 PM (7 days ago) Mar 5
to Vincent Chiang, Zoraiz Naeem, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima, Vincent Chiang and Zoraiz Naeem
Achuith Bhandarkar added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 217, Patchset 4 (Latest):
float x;Achuith Bhandarkar . unresolved
why not assign to norm_x? that removes both the else branches.
Line 226, Patchset 4 (Latest):
display::Display::Rotation panel_rotation =Achuith Bhandarkar . unresolved
const
Related details
Attention is currently required from:
- Mitsuru Oshima
- Vincent Chiang
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Achuith Bhandarkar (Gerrit)
Mar 5, 2026, 8:51:15 PM (7 days ago) Mar 5
to Vincent Chiang, Zoraiz Naeem, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima, Vincent Chiang and Zoraiz Naeem
Achuith Bhandarkar added 1 comment![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 225, Patchset 4 (Latest):
display::Display primary_display = screen->GetPrimaryDisplay();Achuith Bhandarkar . unresolved
What happens in a multi-monitor setup? Do we need to consider secondary displays?
Zoraiz Naeem (Gerrit)
Mar 5, 2026, 10:37:10 PM (7 days ago) Mar 5
to Vincent Chiang, Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima and Vincent Chiang
Zoraiz Naeem added 4 comments![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 221, Patchset 4 (Latest):
// In ChromeOS, when a display is not installed right side up, we would needZoraiz Naeem . unresolved
nit" paraphrase comment in terms of panel rotation.
```
// In ChromeOS, for rotate panel, we would need ....
```
Line 222, Patchset 4 (Latest):
// to apply a rotation to map the tablet to the display correctly.Zoraiz Naeem . unresolved
apply rotation to what?
Line 261, Patchset 4 (Latest):
cursor_->MoveCursorTo(gfx::PointF(x, y));Zoraiz Naeem . unresolved
By account for panel rotation for the cursor position, are the mouse/touch events also correctly mapped?
Line 262, Patchset 4 (Latest):
}Zoraiz Naeem . unresolved
We can format this as such:
```
float x = norm_x;
float y = norm_y;
#if BUILDFLAG(IS_CHROMEOS)
const display::Screen* screen = display::Screen::Get();
if (screen) {
.....
}
#endif // BUILDFLAG(IS_CHROMEOS)
```
Related details
Attention is currently required from:
- Mitsuru Oshima
- Vincent Chiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vincent Chiang (Gerrit)
Mar 8, 2026, 8:48:00 PM (4 days ago) Mar 8
to Zoraiz Naeem, Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar, Mitsuru Oshima and Zoraiz Naeem
Vincent Chiang voted and added 9 comments![]( "Open in Gerrit")
Votes added by Vincent Chiang
| Commit-Queue | +1 |
Achuith Bhandarkar . resolved
don't you need a unit test?
Vincent Chiang
Test added.
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
why not assign to norm_x? that removes both the else branches.
Vincent Chiang
Done
Line 221, Patchset 4:
// In ChromeOS, when a display is not installed right side up, we would needZoraiz Naeem . resolved
nit" paraphrase comment in terms of panel rotation.
```
// In ChromeOS, for rotate panel, we would need ....
```
Vincent Chiang
Done
Line 222, Patchset 4:
// to apply a rotation to map the tablet to the display correctly.Zoraiz Naeem . resolved
Vincent Chiangapply rotation to what?
Adjusted comment.
Line 225, Patchset 4:
display::Display primary_display = screen->GetPrimaryDisplay();Achuith Bhandarkar . resolved
What happens in a multi-monitor setup? Do we need to consider secondary displays?
Vincent Chiang
I've tested this, the touch tablet will only be able to mouse cursor on the primary display. This is true for all regular Chromebook.
Line 226, Patchset 4:
display::Display::Rotation panel_rotation =Achuith Bhandarkar . resolved
Vincent Chiangconst
Done
By account for panel rotation for the cursor position, are the mouse/touch events also correctly mapped?
Vincent Chiang
Yup
We can format this as such:
```
float x = norm_x;
float y = norm_y;#if BUILDFLAG(IS_CHROMEOS)
const display::Screen* screen = display::Screen::Get();
if (screen) {
.....
}#endif // BUILDFLAG(IS_CHROMEOS)
```
Attention is currently required from:
- Achuith Bhandarkar
- Mitsuru Oshima
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zoraiz Naeem (Gerrit)
Mar 9, 2026, 3:44:44 PM (4 days ago) Mar 9
to Vincent Chiang, Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar, Mitsuru Oshima and Vincent Chiang
Zoraiz Naeem added 1 comment![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 209, Patchset 7 (Latest):
void TabletEventConverterEvdev::UpdateCursor() {Zoraiz Naeem . unresolved
Tablet in this context refers only to these external touch/pen devices?
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Mitsuru Oshima
- Vincent Chiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Mar 9, 2026, 7:33:25 PM (4 days ago) Mar 9
to Vincent Chiang, Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar and Vincent Chiang
Mitsuru Oshima added 2 comments![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 218, Patchset 7 (Latest):
float y = norm_y;Mitsuru Oshima . unresolved
can we create gfx::PointF then transpose/transform?
Line 220, Patchset 7 (Latest):
#if BUILDFLAG(IS_CHROMEOS)Mitsuru Oshima . unresolved
AFAIK this class shoulod be cros only
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Vincent Chiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vincent Chiang (Gerrit)
Mar 11, 2026, 8:32:22 PM (2 days ago) Mar 11
to Zoraiz Naeem, Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar, Mitsuru Oshima and Zoraiz Naeem
Vincent Chiang added 3 comments![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Tablet in this context refers only to these external touch/pen devices?
Vincent Chiang
AFAIK yes, @osh...@chromium.org can probably confirm.
can we create gfx::PointF then transpose/transform?
Vincent Chiang
Done
AFAIK this class shoulod be cros only
Attention is currently required from:
- Achuith Bhandarkar
- Mitsuru Oshima
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Mar 11, 2026, 10:09:06 PM (2 days ago) Mar 11
to Vincent Chiang, Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar, Vincent Chiang and Zoraiz Naeem
Mitsuru Oshima voted and added 5 comments![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Code-Review | +1 |
5 comments
File ui/events/ozone/evdev/tablet_event_converter_evdev.cc
Line 209, Patchset 7:
void TabletEventConverterEvdev::UpdateCursor() {Zoraiz Naeem . resolved
Vincent ChiangTablet in this context refers only to these external touch/pen devices?
AFAIK yes, @osh...@chromium.org can probably confirm.
Mitsuru Oshima
Yes, I wish there is a better name for this. Maybe we can rename to PenTablet ?
File ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
Line 45, Patchset 8 (Latest):
#if BUILDFLAG(IS_CHROMEOS)Mitsuru Oshima . unresolved
nit: remove this as well?
Line 2301, Patchset 8 (Latest):
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . unresolved
std::array
Line 2340, Patchset 8 (Latest):
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . unresolved
ditto
Line 2380, Patchset 8 (Latest):
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . unresolved
ditto
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Vincent Chiang
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vincent Chiang (Gerrit)
Mar 11, 2026, 11:08:15 PM (2 days ago) Mar 11
to Mitsuru Oshima, Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar and Zoraiz Naeem
Vincent Chiang added 4 comments![]( "Open in Gerrit")
File ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
nit: remove this as well?
Vincent Chiang
Done
Line 2301, Patchset 8:
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . resolved
Vincent Chiangstd::array
Done
Line 2340, Patchset 8:
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . resolved
Vincent Chiangditto
Done
Line 2380, Patchset 8:
struct input_event mock_kernel_queue[] = {Mitsuru Oshima . resolved
Vincent Chiangditto
Done
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vincent Chiang (Gerrit)
Mar 12, 2026, 1:59:21 AM (yesterday) Mar 12
to Mitsuru Oshima, Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar and Zoraiz Naeem
Vincent Chiang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Zoraiz Naeem (Gerrit)
Mar 12, 2026, 2:01:33 AM (yesterday) Mar 12
to Vincent Chiang, Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Achuith Bhandarkar and Vincent Chiang
Zoraiz Naeem voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Achuith Bhandarkar
- Vincent Chiang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 2:07:51 AM (yesterday) Mar 12
to Vincent Chiang, Zoraiz Naeem, Mitsuru Oshima, Achuith Bhandarkar, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Compensate tablet input with panel orientation
Add rotation logic to TabletEventConverterEvdev so devices with none-0
panel orientation can use tablet devices. The change adds a transform
to tablet input coordinates before updating cursor location.
Bug: b:487118330, b:162444998
Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996
Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
Commit-Queue: Vincent Chiang <vincen...@chromium.org>
Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598230}
Files:
- M ui/events/ozone/evdev/BUILD.gn
- M ui/events/ozone/evdev/tablet_event_converter_evdev.cc
- M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
Change size: M
Delta: 3 files changed, 176 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mitsuru Oshima, +1 by Zoraiz Naeem
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages