[ozone/wayland] Export window handle looks for the xdg_toplevel [chromium/src : main]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Mar 2, 2026, 4:43:04 PM (11 days ago) Mar 2
to Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Thomas Anderson
Message from Kramer Ge![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Kramer Ge
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Mar 2, 2026, 6:19:56 PM (11 days ago) Mar 2
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Mar 2, 2026, 9:42:30 PM (10 days ago) Mar 2
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 2, 2026, 10:25:19 PM (10 days ago) Mar 2
to Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ozone/wayland] Export window handle looks for the xdg_toplevel
Subsurface and popups are not allowed to be exported via xdg_foreign.
This causes chrome to be closed when an extension attempts to open a
file picker dialog. Similar to WaylandBubble spawning popup workaround,
delegate the export action to the xdg_toplevel ancestor.
R=thomasanderson
Fixed: 469787959
Change-Id: I26f155c4f81feee87e18589143f17c737399eabe
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1592943}
Files:
- M ui/ozone/platform/wayland/host/linux_ui_delegate_wayland.cc
Change size: S
Delta: 1 file changed, 8 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages