Migrate base::Contains() to std::ranges::contains() in ui [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Jan 13, 2026, 1:29:53 AMJan 13
to Victor Vianna, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org
Attention needed from Victor Vianna

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mitsuru Oshima . resolved

can you run "git cl format"?

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
Gerrit-Change-Number: 7456228
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 06:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 1:43:09 AMJan 13
to Mitsuru Oshima, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org
Attention needed from Mitsuru Oshima

Victor Vianna added 1 comment

Patchset-level comments
Mitsuru Oshima . resolved

can you run "git cl format"?

Victor Vianna

I did. With `InsertBraces: false` to avoid unnecessarily increasing the diff. Done with `InsertBraces: true` now.

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
Gerrit-Change-Number: 7456228
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 06:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 13, 2026, 11:01:49 AMJan 13
to Mitsuru Oshima, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org
Attention needed from Mitsuru Oshima

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
Gerrit-Change-Number: 7456228
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:01:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jan 13, 2026, 3:18:45 PMJan 13
to Victor Vianna, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org
Attention needed from Victor Vianna

Mitsuru Oshima voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
    Gerrit-Change-Number: 7456228
    Gerrit-PatchSet: 3
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 20:18:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 7:18:23 PMJan 13
    to Mitsuru Oshima, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org

    Victor Vianna voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Wed, 14 Jan 2026 00:18:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Jan 13, 2026, 7:19:26 PMJan 13
    to Mitsuru Oshima, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, AyeAye, Chromium LUCI CQ, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org

    Victor Vianna voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
    Gerrit-Change-Number: 7456228
    Gerrit-PatchSet: 4
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 00:19:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 7:22:45 PMJan 13
    to Victor Vianna, Mitsuru Oshima, Kevin Babbitt, Sadrul Chowdhury, (Julie)Jeongeun Kim, James Su, Ian Vollick, Peter Beverloo, Akihiro Ota, AyeAye, dtseng...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, jbauma...@chromium.org, sky+...@chromium.org, francisjp...@google.com, abigailbk...@google.com, ozone-...@chromium.org, josiah...@chromium.org, lucasrada...@google.com, dcheng+c...@chromium.org, max+watc...@igalia.com, kyungjunle...@google.com, yuzo+...@chromium.org, keithle...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, nektar...@chromium.org, cc-...@chromium.org, spang...@chromium.org, shuche...@chromium.org, mac-r...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Migrate base::Contains() to std::ranges::contains() in ui

    base::Contains() is an alias to std::ranges::contains() since
    crrev.com/c/7415207, so this CL has no behavior change.
    Bug: 470391351
    Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
    Commit-Queue: Victor Vianna <victor...@google.com>
    Auto-Submit: Victor Vianna <victor...@google.com>
    Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568806}
    Files:
    • M ui/accessibility/ax_event_generator.cc
    • M ui/accessibility/ax_tree_unittest.cc
    • M ui/accessibility/platform/ax_platform_node_delegate.cc
    • M ui/accessibility/platform/ax_platform_node_win_unittest.cc
    • M ui/accessibility/platform/browser_accessibility.cc
    • M ui/accessibility/platform/inspect/ax_tree_formatter_base.cc
    • M ui/android/view_android.cc
    • M ui/aura/native_window_occlusion_tracker_win.cc
    • M ui/aura/window.cc
    • M ui/aura/window_event_dispatcher_unittest.cc
    • M ui/aura/window_tracker.cc
    • M ui/base/accelerators/accelerator_manager.cc
    • M ui/base/clipboard/clipboard.cc
    • M ui/base/clipboard/clipboard_android.cc
    • M ui/base/clipboard/clipboard_ozone.cc
    • M ui/base/ime/ash/input_method_util.cc
    • M ui/base/ime/character_composer_unittest.cc
    • M ui/base/ime/win/tsf_input_scope.cc
    • M ui/base/metadata/metadata_cache.cc
    • M ui/base/metadata/metadata_unittest.cc
    • M ui/base/resource/resource_scale_factor.cc
    • M ui/base/win/hwnd_subclass.cc
    • M ui/base/x/selection_utils.cc
    • M ui/base/x/x11_clipboard_helper.cc
    • M ui/base/x/x11_gl_egl_utility.cc
    • M ui/base/x/x11_os_exchange_data_provider.cc
    • M ui/base/x/x11_util.cc
    • M ui/compositor/layer.cc
    • M ui/display/display_change_notifier.cc
    • M ui/display/display_layout.cc
    • M ui/display/manager/display_configurator.cc
    • M ui/display/manager/display_manager.cc
    • M ui/display/screen.cc
    • M ui/display/unified_desktop_utils.cc
    • M ui/display/win/screen_win.cc
    • M ui/events/ash/keyboard_capability.cc
    • M ui/events/ash/keyboard_capability_unittest.cc
    • M ui/events/devices/device_data_manager.cc
    • M ui/events/ozone/evdev/event_converter_evdev_impl.cc
    • M ui/events/ozone/evdev/input_device_factory_evdev.cc
    • M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
    • M ui/gfx/font_fallback_unittest.cc
    • M ui/gfx/image/image_skia.cc
    • M ui/gfx/linux/gbm_support_x11.cc
    • M ui/gfx/linux/test/mock_gbm_device.cc
    • M ui/gfx/render_text_harfbuzz.cc
    • M ui/gfx/x/connection.cc
    • M ui/gfx/x/randr_output_manager.cc
    • M ui/gfx/x/x11_crtc_resizer.cc
    • M ui/gl/gl_implementation.cc
    • M ui/gl/gl_surface_egl_x11.cc
    • M ui/gl/init/gl_display_initializer.cc
    • M ui/gl/test/egl_initialization_displays_unittest.cc
    • M ui/message_center/message_center_impl.cc
    • M ui/ozone/platform/drm/gpu/drm_device_manager.cc
    • M ui/ozone/platform/drm/gpu/drm_framebuffer.cc
    • M ui/ozone/platform/drm/gpu/fake_drm_device.cc
    • M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
    • M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
    • M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc
    • M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
    • M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
    • M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
    • M ui/ozone/platform/wayland/gpu/wayland_gl_egl_utility.cc
    • M ui/ozone/platform/wayland/host/gtk_primary_selection_offer.cc
    • M ui/ozone/platform/wayland/host/wayland_data_drag_controller_unittest.cc
    • M ui/ozone/platform/wayland/host/wayland_data_offer.cc
    • M ui/ozone/platform/wayland/host/wayland_data_offer_base.cc
    • M ui/ozone/platform/wayland/host/wayland_event_source_unittest.cc
    • M ui/ozone/platform/wayland/host/wayland_input_method_context.cc
    • M ui/ozone/platform/wayland/host/wayland_window.cc
    • M ui/ozone/platform/wayland/host/wayland_window_drag_controller.cc
    • M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
    • M ui/ozone/platform/wayland/host/xdg_toplevel.cc
    • M ui/ozone/platform/wayland/host/zwp_primary_selection_offer.cc
    • M ui/ozone/platform/wayland/host/zwp_text_input_v3_unittest.cc
    • M ui/ozone/platform/x11/test/x11_window_unittest.cc
    • M ui/wm/core/shadow_controller.cc
    • M ui/wm/core/transient_window_manager.cc
    • M ui/wm/core/window_animations.cc
    • M ui/wm/core/window_animations_unittest.cc
    Change size: L
    Delta: 81 files changed, 267 insertions(+), 262 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mitsuru Oshima
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idfd7cfe00fc039d1cd47462f36275b31c3eee6f4
    Gerrit-Change-Number: 7456228
    Gerrit-PatchSet: 5
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages