[ozone] Remove WaylandBufferManagerHost::GetBufferFormat [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Feb 5, 2026, 4:51:45 PMFeb 5
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell

Saifuddin Hitawala added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7ca087b9442a82d5d5387c1bf96f0e7691631a5
Gerrit-Change-Number: 7546068
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 21:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Feb 6, 2026, 3:38:22 AMFeb 6
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

Code-Review+1

2 comments

Patchset-level comments
Colin Blundell . resolved

Thanks!

File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
Line 294, Patchset 2 (Parent): return it->second.get()->format();
Colin Blundell . resolved

(to look at in followup): Is the `format()` method here still used?

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7ca087b9442a82d5d5387c1bf96f0e7691631a5
Gerrit-Change-Number: 7546068
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 08:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Saifuddin Hitawala (Gerrit)

unread,
Feb 6, 2026, 9:11:36 AM (14 days ago) Feb 6
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

Commit-Queue+2

2 comments

Patchset-level comments
Saifuddin Hitawala . resolved

Thanks for reviewing!

File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
Line 294, Patchset 2 (Parent): return it->second.get()->format();
Colin Blundell . resolved

(to look at in followup): Is the `format()` method here still used?

Saifuddin Hitawala

Ah good catch! This can indeed be removed in a follow-up.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7ca087b9442a82d5d5387c1bf96f0e7691631a5
Gerrit-Change-Number: 7546068
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 14:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 6, 2026, 9:14:58 AM (14 days ago) Feb 6
to Saifuddin Hitawala, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ozone] Remove WaylandBufferManagerHost::GetBufferFormat

This is dead code and no longer used.
Bug: 356649879
Change-Id: Ib7ca087b9442a82d5d5387c1bf96f0e7691631a5
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1580790}
Files:
  • M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
  • M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
Change size: S
Delta: 2 files changed, 0 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7ca087b9442a82d5d5387c1bf96f0e7691631a5
Gerrit-Change-Number: 7546068
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages