[ozone] Move WaylandBufferBacking::format to WaylandBufferBackingDmabuf [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Feb 6, 2026, 10:19:36 AM (14 days ago) Feb 6
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice72d1259def6674c59d17b3b42027f1a1f9822c
Gerrit-Change-Number: 7548122
Gerrit-PatchSet: 1
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Feb 6, 2026, 10:30:34 AM (14 days ago) Feb 6
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks for following up!

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice72d1259def6674c59d17b3b42027f1a1f9822c
Gerrit-Change-Number: 7548122
Gerrit-PatchSet: 1
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Saifuddin Hitawala (Gerrit)

unread,
Feb 6, 2026, 10:32:20 AM (14 days ago) Feb 6
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+2

1 comment

Patchset-level comments
Saifuddin Hitawala . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice72d1259def6674c59d17b3b42027f1a1f9822c
Gerrit-Change-Number: 7548122
Gerrit-PatchSet: 1
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 15:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 6, 2026, 10:35:46 AM (14 days ago) Feb 6
to Saifuddin Hitawala, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ozone] Move WaylandBufferBacking::format to WaylandBufferBackingDmabuf

We do not need format_ and its accessor on WaylandBufferBacking
anymore as it is only used by WaylandBufferBackingDmabuf. This change
removes the accessor and moves the member to WaylandBufferBackingDmabuf
which uses it.
Bug: 356649879
Change-Id: Ice72d1259def6674c59d17b3b42027f1a1f9822c
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1580837}
Files:
  • M ui/ozone/platform/wayland/host/wayland_buffer_backing.cc
  • M ui/ozone/platform/wayland/host/wayland_buffer_backing.h
  • M ui/ozone/platform/wayland/host/wayland_buffer_backing_dmabuf.cc
  • M ui/ozone/platform/wayland/host/wayland_buffer_backing_dmabuf.h
Change size: S
Delta: 4 files changed, 7 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice72d1259def6674c59d17b3b42027f1a1f9822c
Gerrit-Change-Number: 7548122
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages