AGTM: Remove JSON prototype [chromium/src : main]

0 views
Skip to first unread message

ccameron chromium (Gerrit)

unread,
Dec 12, 2025, 7:44:48 AM (10 days ago) Dec 12
to ccameron chromium, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dale Curtis

ccameron chromium voted and added 1 comment

Votes added by ccameron chromium

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
ccameron chromium . resolved

This is the removal of the JSON part!

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a864f11f8d928fbe7e68dbbc4bfcca8086eaad2
Gerrit-Change-Number: 7256035
Gerrit-PatchSet: 2
Gerrit-Owner: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 12:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Dec 12, 2025, 12:47:20 PM (10 days ago) Dec 12
to ccameron chromium, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from ccameron chromium

Dale Curtis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • ccameron chromium
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a864f11f8d928fbe7e68dbbc4bfcca8086eaad2
Gerrit-Change-Number: 7256035
Gerrit-PatchSet: 2
Gerrit-Owner: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 17:47:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

ccameron chromium (Gerrit)

unread,
Dec 13, 2025, 2:27:43 AM (9 days ago) Dec 13
to ccameron chromium, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org

ccameron chromium voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a864f11f8d928fbe7e68dbbc4bfcca8086eaad2
Gerrit-Change-Number: 7256035
Gerrit-PatchSet: 3
Gerrit-Owner: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Comment-Date: Sat, 13 Dec 2025 07:27:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 13, 2025, 2:32:20 AM (9 days ago) Dec 13
to ccameron chromium, Dale Curtis, chromium...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
AGTM: Remove JSON prototype

Change GetSerializedAgtmItutT35 to only parse the ITU-T T.35 header, and
nothing else (not the version inside ST 2094-50, etc).

Update tests to reflect this.

Remove the JSON-based prototype AGTM implementation, and instead hook up
the skhdr::Agtm based implementation.
Bug: 395659818
Change-Id: I3a864f11f8d928fbe7e68dbbc4bfcca8086eaad2
Commit-Queue: ccameron chromium <ccam...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558413}
Files:
  • M cc/paint/tone_map_util.cc
  • M media/base/agtm.cc
  • M media/base/agtm_unittest.cc
  • M media/filters/dav1d_video_decoder_unittest.cc
  • M media/filters/vpx_video_decoder_unittest.cc
  • M media/gpu/av1_decoder_unittest.cc
  • M ui/gfx/BUILD.gn
  • M ui/gfx/hdr_metadata.cc
  • M ui/gfx/hdr_metadata.h
  • D ui/gfx/hdr_metadata_agtm.cc
  • D ui/gfx/hdr_metadata_agtm.h
  • M ui/ozone/platform/wayland/host/wayland_wp_color_manager.cc
Change size: L
Delta: 12 files changed, 62 insertions(+), 562 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dale Curtis
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a864f11f8d928fbe7e68dbbc4bfcca8086eaad2
Gerrit-Change-Number: 7256035
Gerrit-PatchSet: 4
Gerrit-Owner: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages