eglWaitSyncKHR is part of the EGL_KHR_wait_sync extension (issue 900233003 by rogerj@opera.com)

[rog...@opera.com]

Reviewers: sievers,

Description:
eglWaitSyncKHR is part of the EGL_KHR_wait_sync extension

The eglWaitSyncKHR function should only be expected to exist if the
EGL_KHR_wait_sync extension is supported. The code prior to this patch
triggered a DCHECK if only the EGL_KHR_fence_sync extension was available.

BUG=None

Please review this at https://codereview.chromium.org/900233003/

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+2, -2 lines):
M ui/gl/generate_bindings.py
M ui/gl/gl_bindings_autogen_egl.cc


Index: ui/gl/generate_bindings.py
diff --git a/ui/gl/generate_bindings.py b/ui/gl/generate_bindings.py
index
cd25b04bb542c4dd1bfb765ada949f530d47f5d4..52daf1c2dbbfa5d093332b94a18b95fb083aad09
100755
--- a/ui/gl/generate_bindings.py
+++ b/ui/gl/generate_bindings.py
@@ -1360,7 +1360,7 @@ EGL_FUNCTIONS = [
'arguments': 'EGLint engine', },
{ 'return_type': 'EGLint',
'versions': [{ 'name': 'eglWaitSyncKHR',
- 'extensions': ['EGL_KHR_fence_sync', 'EGL_KHR_wait_sync']
}],
+ 'extensions': ['EGL_KHR_wait_sync'] }],
'arguments': 'EGLDisplay dpy, EGLSyncKHR sync, EGLint flags' },
]

Index: ui/gl/gl_bindings_autogen_egl.cc
diff --git a/ui/gl/gl_bindings_autogen_egl.cc
b/ui/gl/gl_bindings_autogen_egl.cc
index
e0de7f2b26d591f49d9ae7a71f2022e64f2d31e0..003b5457823f967c1606ca7d20d15100b6fbca65
100644
--- a/ui/gl/gl_bindings_autogen_egl.cc
+++ b/ui/gl/gl_bindings_autogen_egl.cc
@@ -209,7 +209,7 @@ void DriverEGL::InitializeStaticBindings() {
}

debug_fn.eglWaitSyncKHRFn = 0;
- if (ext.b_EGL_KHR_fence_sync || ext.b_EGL_KHR_wait_sync) {
+ if (ext.b_EGL_KHR_wait_sync) {
fn.eglWaitSyncKHRFn = reinterpret_cast<eglWaitSyncKHRProc>(
GetGLProcAddress("eglWaitSyncKHR"));
DCHECK(fn.eglWaitSyncKHRFn);

[sie...@chromium.org]

lgtm, thanks!

https://codereview.chromium.org/900233003/

[commi...@chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/900233003/1


https://codereview.chromium.org/900233003/

[commi...@chromium.org]

Committed patchset #1 (id:1)

https://codereview.chromium.org/900233003/

[commi...@chromium.org]

Patchset 1 (id:??) landed as
https://crrev.com/075f83963550a232d2832d615ad5c1fea8426b45
Cr-Commit-Position: refs/heads/master@{#314878}

https://codereview.chromium.org/900233003/