[Wayland] Pass through sRGB instead of re-encoding as gamma 2.2 [chromium/src : main]

1 view
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Nov 3, 2025, 3:43:56 PM (3 days ago) Nov 3
to Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Thomas Anderson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c4f0597ba76c67beb1ad4ed796bc318cdfc3758
Gerrit-Change-Number: 7113900
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 20:43:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Nov 4, 2025, 4:48:12 PM (2 days ago) Nov 4
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kramer Ge . resolved

Thanks for fixing and explaining!

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c4f0597ba76c67beb1ad4ed796bc318cdfc3758
    Gerrit-Change-Number: 7113900
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 21:48:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Anderson (Gerrit)

    unread,
    Nov 4, 2025, 6:55:49 PM (2 days ago) Nov 4
    to Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Thomas Anderson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c4f0597ba76c67beb1ad4ed796bc318cdfc3758
    Gerrit-Change-Number: 7113900
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 23:55:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 4, 2025, 6:58:43 PM (2 days ago) Nov 4
    to Thomas Anderson, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [Wayland] Pass through sRGB instead of re-encoding as gamma 2.2

    This CL changes the TF for SDR content from gamma 2.2 to sRGB. The
    wayland spec says this about sRGB: "sRGB material is intended to be
    viewed on an sRGB display, and that is described by gamma22." However
    there is disagreement: "Regardless of the original intents of the
    specification writers, 'sRGB' displays have always decoded their signal
    with 2.2 power-law. That produces the look that artists and content
    authors have tuned their works for and what end users expect. Changing
    that is both unnecessary and would lead to complaints" [2].

    [1] https://wayland.app/protocols/color-management-v1

    [2]
    https://gitlab.freedesktop.org/pq/color-and-hdr/-/blob/bcad995181cc1931ed28aa8ba4b9ea843843d60c/doc/wayland_qa.md#L79

    R=fangzhoug
    Fixed: 449423580
    Change-Id: I7c4f0597ba76c67beb1ad4ed796bc318cdfc3758
    Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1540371}
    Files:
    • M ui/ozone/platform/wayland/host/wayland_wp_image_description.cc
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kramer Ge
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c4f0597ba76c67beb1ad4ed796bc318cdfc3758
    Gerrit-Change-Number: 7113900
    Gerrit-PatchSet: 5
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages