Kramer Ge (Gerrit)

unread,

Aug 11, 2026, 5:14:46 PM (2 days ago) Aug 11

to Thomas Anderson, //chrome/browser/ui/views Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from //chrome/browser/ui/views Reviews and Thomas Anderson

Kramer Ge voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

//chrome/browser/ui/views Reviews
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Aug 11, 2026, 5:19:04 PM (2 days ago) Aug 11

to //chrome/browser/ui/views Reviews, Dana Fried, Chromium LUCI CQ, Thomas Anderson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from Dana Fried and Thomas Anderson

Message from gwsq

Reviewer source(s):
dfr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Aug 11, 2026, 5:19:13 PM (2 days ago) Aug 11

to Kramer Ge, //chrome/browser/ui/views Reviews, Dana Fried, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from Dana Fried and Kramer Ge

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Thomas Anderson . resolved

lgtm as a stopgap until weston is upreved

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dana Fried (Gerrit)

unread,

Aug 12, 2026, 8:59:23 AM (20 hours ago) Aug 12

to Kramer Ge, Thomas Anderson, //chrome/browser/ui/views Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from Kramer Ge

Dana Fried voted and added 1 comment

Votes added by Dana Fried

Code-Review

+1

1 comment

File chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc

Line 552, Patchset 6 (Latest): // On Wayland, the 2nd resize is for xdg_toplevel.set_fullscreen, so 2 is

Dana Fried . unresolved

question: is the 2 here a result of the workaround you've built, is it tied to a particular reference implementation, or is it just how all Wayland works?

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Aug 12, 2026, 11:24:56 AM (17 hours ago) Aug 12

to Dana Fried, Thomas Anderson, //chrome/browser/ui/views Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from Dana Fried

Kramer Ge added 1 comment

File chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc

Line 552, Patchset 6 (Latest): // On Wayland, the 2nd resize is for xdg_toplevel.set_fullscreen, so 2 is

Dana Fried . unresolved

question: is the 2 here a result of the workaround you've built, is it tied to a particular reference implementation, or is it just how all Wayland works?

Kramer Ge

It's how wayland works. it requires 2 resize triggers, 1 for requesting it to the compositor and 1 for receiving the fullscreen event from the compositor, these happen asynchronously.

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Aug 12, 2026, 1:09:55 PM (16 hours ago) Aug 12

to Dana Fried, Thomas Anderson, //chrome/browser/ui/views Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Attention needed from Dana Fried

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Commit-Queue

+2

1 comment

File chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc

Line 552, Patchset 6 (Latest): // On Wayland, the 2nd resize is for xdg_toplevel.set_fullscreen, so 2 is

Dana Fried . resolved

question: is the 2 here a result of the workaround you've built, is it tied to a particular reference implementation, or is it just how all Wayland works?

Kramer Ge

It's how wayland works. it requires 2 resize triggers, 1 for requesting it to the compositor and 1 for receiving the fullscreen event from the compositor, these happen asynchronously.

Kramer Ge

Marking as resolved.

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 12, 2026, 1:21:21 PM (15 hours ago) Aug 12

to Kramer Ge, Dana Fried, Thomas Anderson, //chrome/browser/ui/views Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix flaky tests when WaylandExternalBeginFrameSource is enabled

Old version of weston does not ack empty frame callbacks immediately.
Hence, tests are flaky because we often run into timeouts.

Add test-only workaround to skip scheduling empty frame callbacks. And
fix an expectation in multi-content test.

Bug: 544919883, 477649985

Change-Id: I621d689a047d7343c3b630a9cb93f902876b425f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8225068

Reviewed-by: Thomas Anderson <thomasa...@chromium.org>

Commit-Queue: Kramer Ge <fang...@chromium.org>

Reviewed-by: Dana Fried <dfr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1678145}

Files:

M chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc
M ui/ozone/platform/wayland/host/begin_frame_source_wayland.cc

Change size: S

Delta: 2 files changed, 31 insertions(+), 5 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Thomas Anderson, +1 by Dana Fried

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix flaky tests when WaylandExternalBeginFrameSource is enabled [chromium/src : main]

Kramer Ge (Gerrit)

Kramer Ge voted Commit-Queue+1

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

1 comment

Related details

Dana Fried (Gerrit)

Dana Fried voted and added 1 comment

Votes added by Dana Fried

1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge added 1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information