Remove workaround for MT_TOOL_PALM missing from system header [chromium/src : main]
0 views
Skip to first unread message
Adam Rice (Gerrit)
Nov 25, 2025, 1:01:58 PM (6 days ago) Nov 25
to Lei Zhang, Michael Spang, Dmitry Torokhov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Lei Zhang and Michael Spang
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Adam Rice . resolved
Hopefully I don't own this, but lgtm anyway.
Related details
Attention is currently required from:
- Lei Zhang
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Schoedel (Gerrit)
Nov 25, 2025, 1:18:19 PM (6 days ago) Nov 25
to Lei Zhang, Adam Rice, Michael Spang, Dmitry Torokhov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Lei Zhang and Michael Spang
Kevin Schoedel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Lei Zhang
- Michael Spang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Nov 25, 2025, 1:40:16 PM (6 days ago) Nov 25
to Lei Zhang, Kevin Schoedel, Adam Rice, Dmitry Torokhov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Lei Zhang
Michael Spang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Nov 25, 2025, 1:41:25 PM (6 days ago) Nov 25
to Lei Zhang, Michael Spang, Kevin Schoedel, Adam Rice, Dmitry Torokhov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kevin Schoedel
Lei Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Lei Zhang
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Lei Zhang . resolved
Thanks everyone.
Attention is currently required from:
- Kevin Schoedel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 25, 2025, 2:28:23 PM (6 days ago) Nov 25
to Lei Zhang, Michael Spang, Kevin Schoedel, Adam Rice, Dmitry Torokhov, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove workaround for MT_TOOL_PALM missing from system header
Over 8 years ago, https://crrev.com/498607 added a workaround for cases
where linux/input.h is missing MT_TOOL_PALM. Assume this is no longer an
issue and delete the workaround. Fix some nits in the header along the
way.
Change-Id: I84a3e0baaf378c4173d95d1fc0e647b88363a0f0
Reviewed-by: Michael Spang <sp...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549957}
Files:
- M ui/events/ozone/evdev/touch_event_converter_evdev.cc
- M ui/events/ozone/evdev/touch_event_converter_evdev.h
Change size: S
Delta: 2 files changed, 6 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Spang, +1 by Adam Rice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages