Ozone/Wayland async minimize improvements [chromium/src : main]

0 views

Skip to first unread message

Hidehiko Abe (Gerrit)

unread,

Jul 22, 2026, 12:47:31 PM (19 hours ago) Jul 22

to Patryk Chodur, Daniel Cheng, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-...@chromium.org, ozone-...@chromium.org, creis...@chromium.org, alexmo...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, blink-revi...@chromium.org, max+watc...@igalia.com, pwa-com...@google.com

Attention needed from Patryk Chodur

Hidehiko Abe added 5 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Hidehiko Abe . resolved

is the base CL ready for review already?
As for web_app change, I think we should have review by the web app expert.

File chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_browsertest.cc

Line 2606, Patchset 7 (Latest): enabled_features.emplace_back(features::kAsyncFullscreenWindowState);

Hidehiko Abe . unresolved

for transition period, we probably want to cover both enabled and disabled cases?

File third_party/blink/renderer/core/frame/web_frame_widget_impl.cc

Line 255, Patchset 7 (Latest):constexpr base::TimeDelta kWindowingControlsChangeTimeout = base::Seconds(10);

Hidehiko Abe . unresolved

what is the purpose of update? Ditto for below.

File ui/ozone/platform/wayland/host/wayland_toplevel_window.cc

Line 318, Patchset 7 (Latest): if (previously_maximized_) {

Hidehiko Abe . unresolved

clarification: we do not need to restore fullscreen?

Line 556, Patchset 7 (Latest): pending_minimize_ = false;

Hidehiko Abe . unresolved

This change may leave this variable in a stale state...?

Open in Gerrit

Related details

Attention is currently required from:

Patryk Chodur

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages