[X11] Rename SelectionRequestor to SelectionRequester [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Mar 12, 2026, 5:26:31 PM (16 hours ago) Mar 12
to Thomas Anderson, Lei Zhang, James Su, AJITH KUMAR V, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, alexmo...@chromium.org, ozone-...@chromium.org, dtapuska+ch...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, aji...@samsung.com, roblia...@chromium.org, chromium-a...@chromium.org, mac-r...@chromium.org, nona+...@chromium.org, nickdiego+wa...@igalia.com, yhanada+...@chromium.org, dmurph+wat...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, shuche...@chromium.org, oshima...@chromium.org, jdonnel...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org, tranbaod...@chromium.org, max+watc...@igalia.com, creis...@chromium.org, webap...@microsoft.com, sky+...@chromium.org, keithle...@chromium.org, hidehik...@chromium.org
Attention needed from Thomas Anderson

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I676e928543a901660c34e88bb9a5fbcbae0a0dd9
Gerrit-Change-Number: 7658832
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 21:26:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
1:41 AM (7 hours ago) 1:41 AM
to Lei Zhang, James Su, AJITH KUMAR V, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, alexmo...@chromium.org, ozone-...@chromium.org, dtapuska+ch...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, aji...@samsung.com, roblia...@chromium.org, chromium-a...@chromium.org, mac-r...@chromium.org, nona+...@chromium.org, nickdiego+wa...@igalia.com, yhanada+...@chromium.org, dmurph+wat...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, shuche...@chromium.org, oshima...@chromium.org, jdonnel...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org, tranbaod...@chromium.org, max+watc...@igalia.com, creis...@chromium.org, webap...@microsoft.com, sky+...@chromium.org, keithle...@chromium.org, hidehik...@chromium.org

Thomas Anderson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I676e928543a901660c34e88bb9a5fbcbae0a0dd9
Gerrit-Change-Number: 7658832
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Mar 2026 05:41:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
1:44 AM (7 hours ago) 1:44 AM
to Thomas Anderson, Lei Zhang, James Su, AJITH KUMAR V, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, alexmo...@chromium.org, ozone-...@chromium.org, dtapuska+ch...@chromium.org, arc-review...@google.com, omnibox-...@chromium.org, crostin...@chromium.org, dcheng+c...@chromium.org, aji...@samsung.com, roblia...@chromium.org, chromium-a...@chromium.org, mac-r...@chromium.org, nona+...@chromium.org, nickdiego+wa...@igalia.com, yhanada+...@chromium.org, dmurph+wat...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, shuche...@chromium.org, oshima...@chromium.org, jdonnel...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org, tranbaod...@chromium.org, max+watc...@igalia.com, creis...@chromium.org, webap...@microsoft.com, sky+...@chromium.org, keithle...@chromium.org, hidehik...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[X11] Rename SelectionRequestor to SelectionRequester

This just fixes a typo.

R=thestig
Change-Id: I676e928543a901660c34e88bb9a5fbcbae0a0dd9
Bug: None
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1598889}
Files:
  • M ui/base/x/BUILD.gn
  • R ui/base/x/selection_requester.cc
  • R ui/base/x/selection_requester.h
  • R ui/base/x/selection_requester_unittest.cc
  • M ui/base/x/x11_clipboard_helper.cc
  • M ui/base/x/x11_clipboard_helper.h
  • M ui/base/x/x11_os_exchange_data_provider.h
Change size: M
Delta: 7 files changed, 67 insertions(+), 67 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Lei Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I676e928543a901660c34e88bb9a5fbcbae0a0dd9
Gerrit-Change-Number: 7658832
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages