[Wayland] Fix tests that were flaking due to Token Request Timeout [chromium/src : main]
0 views
Skip to first unread message
Claire Chambers (Gerrit)
Jan 9, 2026, 4:21:34 AM (3 days ago) Jan 9
to Thomas Anderson, Orko Garai, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Orko Garai and Thomas Anderson
Claire Chambers added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Claire Chambers . resolved
Adding the reviews of the change that caused the flake. Please reassign as needed, or if you don't have the time, thanks!
Would be happy to rejig/refactor change if it is non-idiomatic - apologies if so, this is outside my normal area.
Related details
Attention is currently required from:
- Orko Garai
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jan 9, 2026, 12:45:09 PM (2 days ago) Jan 9
to Claire Chambers, Orko Garai, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers and Orko Garai
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Claire Chambers
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jan 9, 2026, 12:45:55 PM (2 days ago) Jan 9
to Claire Chambers, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers
Orko Garai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Orko Garai
| Code-Review | +1 |
1 comment
Patchset-level comments
Orko Garai . resolved
lgtm
Related details
Attention is currently required from:
- Claire Chambers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Claire Chambers (Gerrit)
Jan 9, 2026, 5:39:09 PM (2 days ago) Jan 9
to Orko Garai, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Claire Chambers voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 5:43:06 PM (2 days ago) Jan 9
to Claire Chambers, Orko Garai, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Wayland] Fix tests that were flaking due to Token Request Timeout
A previous change added XDG Activation during window show, as part of a
stricter window activation policy. To activate a window, we create an
activation token request (see: XdgActivation::TokenRequest::
InitiateRequest). This request has a timeout of 500ms and is implemented
as a OneShotTimer.
Most of the time, ozone unit tests complete so quickly that the
existence of this timer is not a concern. However, when the system is
under load, or slow for any reason (these tests were most flakey on
ASAN/TSAN), this callback can interfere with the main test body, by
calling a watched method, or simply by changing event timestamps.
This change advances the mock test time by one second upon test set up
so that this callback always returns early by the perspective of the
tests.
Bug: 450757459, 454227184
Change-Id: Ie2b0b15622258aa2aac7119e26f3873610c7a33f
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Orko Garai <or...@igalia.com>
Commit-Queue: Claire Chambers <clcha...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1567230}
Files:
- M ui/ozone/platform/wayland/host/xdg_activation_unittest.cc
- M ui/ozone/platform/wayland/test/wayland_test.cc
Change size: S
Delta: 2 files changed, 9 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Orko Garai, +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages