Reland "[base] Rename ThreadType::s/kDisplayCritical/kPresentation" [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Jan 27, 2026, 7:28:14 AM (6 days ago) Jan 27
to AyeAye, Chromium LUCI CQ, Francois Pierre Doray, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, feature-me...@chromium.org, blink-...@chromium.org, scheduler-b...@chromium.org, fmalit...@chromium.org, ozone-...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, cc-...@chromium.org, penghu...@chromium.org, chikamu...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, jbauma...@chromium.org, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Francois Pierre Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I68328dc55883dfbda494645e5da0e5acb2fed77c
Gerrit-Change-Number: 7521244
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Minoru Chikamune <chik...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 12:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Markus Handell (Gerrit)

unread,
Jan 27, 2026, 8:25:22 AM (6 days ago) Jan 27
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, Francois Pierre Doray, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, feature-me...@chromium.org, blink-...@chromium.org, scheduler-b...@chromium.org, fmalit...@chromium.org, ozone-...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, cc-...@chromium.org, penghu...@chromium.org, chikamu...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, jbauma...@chromium.org, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Etienne Pierre-Doray and Francois Pierre Doray

Markus Handell voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
  • Francois Pierre Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68328dc55883dfbda494645e5da0e5acb2fed77c
    Gerrit-Change-Number: 7521244
    Gerrit-PatchSet: 4
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Markus Handell <hand...@google.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Minoru Chikamune <chik...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Tue, 27 Jan 2026 13:25:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Jan 27, 2026, 10:49:11 AM (6 days ago) Jan 27
    to Etienne Pierre-Doray, Markus Handell, AyeAye, Chromium LUCI CQ, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, feature-me...@chromium.org, blink-...@chromium.org, scheduler-b...@chromium.org, fmalit...@chromium.org, ozone-...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, cc-...@chromium.org, penghu...@chromium.org, chikamu...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, jbauma...@chromium.org, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
    Attention needed from Etienne Pierre-Doray

    Francois Pierre Doray voted and added 1 comment

    Votes added by Francois Pierre Doray

    Code-Review+1
    Owners-Override+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Francois Pierre Doray . resolved

    OO+1 for mechanical changes outside of //base to adapt to a //base API change

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    Gerrit-Comment-Date: Tue, 27 Jan 2026 15:49:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Jan 27, 2026, 10:49:27 AM (6 days ago) Jan 27
    to Etienne Pierre-Doray, Markus Handell, AyeAye, Chromium LUCI CQ, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, feature-me...@chromium.org, blink-...@chromium.org, scheduler-b...@chromium.org, fmalit...@chromium.org, ozone-...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, cc-...@chromium.org, penghu...@chromium.org, chikamu...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, jbauma...@chromium.org, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
    Attention needed from Etienne Pierre-Doray

    Francois Pierre Doray voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Tue, 27 Jan 2026 15:49:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 27, 2026, 12:08:14 PM (6 days ago) Jan 27
    to Etienne Pierre-Doray, Francois Pierre Doray, Markus Handell, AyeAye, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, feature-me...@chromium.org, blink-...@chromium.org, scheduler-b...@chromium.org, fmalit...@chromium.org, ozone-...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, cc-...@chromium.org, penghu...@chromium.org, chikamu...@chromium.org, android-web...@chromium.org, fuchsia...@chromium.org, jbauma...@chromium.org, blink-reviews-p...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Reland "[base] Rename ThreadType::s/kDisplayCritical/kPresentation"

    This is a reland of commit 059998a861f4caeafbb25276fda8b9426c2b9892

    Reason for revert: build failure conflicting with another CL
    that landed around the same time
    https://chromium-review.googlesource.com/c/chromium/src/+/7516585

    Fix: rebased

    Original change's description:
    > [base] Rename ThreadType::s/kDisplayCritical/kPresentation
    >
    > kDisplayCritical was introduced in
    > https://chromium-review.googlesource.com/c/chromium/src/+/3329026
    >
    > But then because kCompositing was effectively the same thing, it was merged into it in
    > https://chromium-review.googlesource.com/c/chromium/src/+/4842549
    >
    > Today, kDisplayCritical refers to any thread involved in producing
    > visible content. This CL renames the ThreadType to better reflect those threads.
    >
    > Bug: 470337728
    > Change-Id: Icec523ff692dc5a6c06fa97ff69b20ae459f2010
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7457593
    > Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    > Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
    > Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1574997}
    Bug: 470337728
    Change-Id: I68328dc55883dfbda494645e5da0e5acb2fed77c
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Markus Handell <hand...@google.com>
    Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
    Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1575290}
    Files:
    • M android_webview/browser/gfx/viz_compositor_thread_runner_webview.cc
    • M base/files/important_file_writer.cc
    • M base/no_destructor_unittest.cc
    • M base/process/process_unittest.cc
    • M base/threading/platform_thread.h
    • M base/threading/platform_thread_android.cc
    • M base/threading/platform_thread_apple.mm
    • M base/threading/platform_thread_cros.cc
    • M base/threading/platform_thread_fuchsia.cc
    • M base/threading/platform_thread_linux.cc
    • M base/threading/platform_thread_unittest.cc
    • M base/threading/platform_thread_win.cc
    • M base/threading/scoped_thread_priority_unittest.cc
    • M chrome/browser/ash/schedqos/dbus_schedqos_state_handler.cc
    • M chrome/browser/ash/schedqos/dbus_schedqos_state_handler_unittest.cc
    • M chromecast/media/audio/capture_service/capture_service_receiver.cc
    • M chromeos/ash/components/boca/spotlight/spotlight_remoting_client_manager.cc
    • M components/startup_metric_utils/common/startup_metric_utils.cc
    • M components/viz/demo/service/demo_service.cc
    • M components/viz/service/display_embedder/compositor_gpu_thread.cc
    • M components/viz/service/main/viz_compositor_thread_runner_impl.cc
    • M components/viz/service/main/viz_main_impl.cc
    • M content/browser/browser_main_loop.cc
    • M content/browser/browser_thread_browsertest.cc
    • M content/browser/child_thread_type_switcher_linux.cc
    • M content/browser/gpu/gpu_process_host.cc
    • M content/browser/network_service_instance_impl.cc
    • M content/browser/scheduler/browser_task_executor.cc
    • M content/child/child_process.cc
    • M content/gpu/gpu_main.cc
    • M content/gpu/in_process_gpu_thread.cc
    • M content/renderer/render_process.cc
    • M content/renderer/render_thread_impl.cc
    • M content/renderer/renderer_blink_platform_impl.cc
    • M content/renderer/renderer_main.cc
    • M mojo/public/cpp/base/thread_type_mojom_traits.cc
    • M mojo/public/cpp/base/thread_type_unittest.cc
    • M mojo/public/mojom/base/thread_type.mojom
    • M third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc
    • M third_party/blink/renderer/modules/webaudio/semi_realtime_audio_worklet_thread.cc
    • M third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
    • M third_party/blink/renderer/platform/scheduler/common/thread.cc
    • M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
    • M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
    • M ui/compositor/display_link_mac_mojo.mm
    • M ui/events/ozone/evdev/event_thread_evdev.cc
    • M ui/gl/vsync_thread_win.cc
    • M ui/ozone/platform/drm/gpu/drm_thread.cc
    Change size: M
    Delta: 49 files changed, 105 insertions(+), 110 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Francois Pierre Doray, +1 by Markus Handell
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68328dc55883dfbda494645e5da0e5acb2fed77c
    Gerrit-Change-Number: 7521244
    Gerrit-PatchSet: 5
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages