Add arg names & comments for SetCurrentLayoutByName() callbacks. [chromium/src : main]
0 views
Skip to first unread message
Michael Cui (Gerrit)
Dec 17, 2025, 3:03:32 AM (5 days ago) Dec 17
to Bao-Duy Tran, Michael Cui, Colin Blundell, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Bao-Duy Tran, Colin Blundell and Darren Shen
Michael Cui voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Bao-Duy Tran
- Colin Blundell
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Dec 17, 2025, 3:14:50 AM (5 days ago) Dec 17
to Bao-Duy Tran, Colin Blundell, Michael Cui, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Bao-Duy Tran and Darren Shen
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
File ui/ozone/public/input_controller.h
Line 87, Patchset 4 (Latest):
// Callback is invoked when the keyboard layout is available and initialized.Colin Blundell . unresolved
nit: Add to the comment to specify what `success` means.
Related details
Attention is currently required from:
- Bao-Duy Tran
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bao-Duy Tran (Gerrit)
Dec 17, 2025, 4:16:20 AM (5 days ago) Dec 17
to Colin Blundell, Michael Cui, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Colin Blundell and Darren Shen
Bao-Duy Tran added 1 comment![]( "Open in Gerrit")
File ui/ozone/public/input_controller.h
Line 87, Patchset 4:
// Callback is invoked when the keyboard layout is available and initialized.Colin Blundell . unresolved
nit: Add to the comment to specify what `success` means.
Bao-Duy Tran
Done. Could you PTAL to ensure no inaccurate info? Thanks. @blun...@chromium.org
Related details
Attention is currently required from:
- Colin Blundell
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Dec 17, 2025, 4:21:02 AM (5 days ago) Dec 17
to Bao-Duy Tran, Colin Blundell, Michael Cui, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Bao-Duy Tran and Darren Shen
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
Colin Blundell . resolved
Thanks!
File ui/ozone/public/input_controller.h
Line 87, Patchset 4:
// Callback is invoked when the keyboard layout is available and initialized.Colin Blundell . resolved
Bao-Duy Trannit: Add to the comment to specify what `success` means.
Done. Could you PTAL to ensure no inaccurate info? Thanks. @blun...@chromium.org
Attention is currently required from:
- Bao-Duy Tran
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bao-Duy Tran (Gerrit)
Dec 21, 2025, 9:56:26 PM (7 hours ago) Dec 21
to Darren Shen, Colin Blundell, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Bao-Duy Tran voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:00 AM (5 hours ago) 12:00 AM
to Bao-Duy Tran, Darren Shen, Colin Blundell, Michael Cui, chromium...@chromium.org, James Su, keithle...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Add arg names & comments for SetCurrentLayoutByName() callbacks.
... so their "success" meanings can be explicitly expressed,
especially as this propagates through so many layers. This will
soon help reveal some instances whereby non-sensical values are
being fed as "success" arg to some of these callbacks.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
Bug: b:469242705
Change-Id: I8ab5ed15ec88fb7740fcfa383bb0cc1b63bc9a7e
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Bao-Duy Tran <tranb...@chromium.org>
Reviewed-by: Michael Cui <ml...@google.com>
Cr-Commit-Position: refs/heads/main@{#1561689}
Files:
- M ui/base/ime/ash/fake_ime_keyboard.cc
- M ui/base/ime/ash/ime_keyboard.h
- M ui/base/ime/ash/ime_keyboard_impl.cc
- M ui/events/ozone/evdev/input_controller_evdev.cc
- M ui/events/ozone/evdev/input_controller_evdev.h
- M ui/events/ozone/evdev/keyboard_evdev.cc
- M ui/events/ozone/evdev/keyboard_evdev.h
- M ui/events/ozone/layout/keyboard_layout_engine.h
- M ui/events/ozone/layout/no/no_keyboard_layout_engine.cc
- M ui/events/ozone/layout/no/no_keyboard_layout_engine.h
- M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc
- M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.h
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h
- M ui/ozone/public/input_controller.h
- M ui/ozone/public/stub_input_controller.cc
- M ui/ozone/public/stub_input_controller.h
Change size: M
Delta: 17 files changed, 42 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Michael Cui
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages