[Fuchsia] Remove BUILDFLAG(IS_FUCHSIA) from //chrome [chromium/src : main]

0 views
Skip to first unread message

Zijie He (Gerrit)

unread,
Apr 25, 2024, 9:37:55 PM4/25/24
to John Abd-El-Malek, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from John Abd-El-Malek

Zijie He added 1 comment

Patchset-level comments
File-level comment, Patchset 8:
Zijie He . resolved

Hey, John, would you please take a look at this change? Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • John Abd-El-Malek
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 9
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: John Abd-El-Malek <j...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: John Abd-El-Malek <j...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Apr 2024 01:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

John Abd-El-Malek (Gerrit)

unread,
Apr 26, 2024, 1:17:47 PM4/26/24
to Zijie He, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Scott Violet and Zijie He

John Abd-El-Malek added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
John Abd-El-Malek . resolved

Redirecting this one to Scott who's a src/chrome owner

Open in Gerrit

Related details

Attention is currently required from:
  • Scott Violet
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 9
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 17:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Scott Violet (Gerrit)

unread,
Apr 26, 2024, 1:40:17 PM4/26/24
to Zijie He, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Zijie He

Scott Violet voted and added 1 comment

Votes added by Scott Violet

Code-Review+1

1 comment

File chrome/browser/signin/dice_signed_in_profile_creator_unittest.cc
Line 248, Patchset 9 (Latest): // I don't know why this test looks like this, but I am only removing
// !BUILDFLAG(IS_FUCHSIA).
Scott Violet . resolved

lol. I'm actually surprised this compiles.

Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 9
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 17:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 26, 2024, 3:51:12 PM4/26/24
to Zijie He, Chromium IPC Reviews, Daniel Cheng, Demetrios Papadopoulos, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng and Demetrios Papadopoulos

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: dch...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): dch...@chromium.org


Reviewer source(s):
dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Demetrios Papadopoulos
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 14
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Apr 2024 19:51:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Demetrios Papadopoulos (Gerrit)

unread,
Apr 26, 2024, 4:56:54 PM4/26/24
to Zijie He, Chromium IPC Reviews, Daniel Cheng, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng and Zijie He

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 14 (Latest):
Demetrios Papadopoulos . resolved

LGTM for chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Zijie He
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 20:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Apr 26, 2024, 5:15:23 PM4/26/24
to Zijie He, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Zijie He

Daniel Cheng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 21:15:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Apr 29, 2024, 11:05:22 AM4/29/24
to Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Zijie He voted and added 1 comment

Votes added by Zijie He

Commit-Queue+2

1 comment

Patchset-level comments
Zijie He . resolved

Thank you.

Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Mon, 29 Apr 2024 15:05:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexei Svitkine (Gerrit)

unread,
Apr 29, 2024, 11:20:44 AM4/29/24
to Zijie He, Yann Dago, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Zijie He

Alexei Svitkine added 1 comment

File chrome/browser/signin/dice_signed_in_profile_creator_unittest.cc
Line 248, Patchset 9: // I don't know why this test looks like this, but I am only removing
// !BUILDFLAG(IS_FUCHSIA).
Scott Violet . resolved

lol. I'm actually surprised this compiles.

Alexei Svitkine

Seems it came from here:
https://chromium-review.googlesource.com/c/chromium/src/+/4701763

+ydago to consider fixing as a follow-up...

Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 14
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Yann Dago <yd...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 15:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Scott Violet <s...@chromium.org>
satisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Apr 29, 2024, 12:58:06 PM4/29/24
to Yann Dago, Alexei Svitkine, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Chromium LUCI CQ, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Zijie He voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Mon, 29 Apr 2024 16:57:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 29, 2024, 3:37:47 PM4/29/24
to Zijie He, Yann Dago, Alexei Svitkine, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Fuchsia] Remove BUILDFLAG(IS_FUCHSIA) from //chrome

Except for the chromedriver.
Cq-Include-Trybots: luci.chrome.try:fuchsia-smoke-sherlock,fuchsia-cast-sherlock,fuchsia-fyi-sherlock;luci.chromium.try:fuchsia-fyi-x64-dbg,fuchsia-fyi-arm64-dbg,fuchsia-arm64-cast-receiver-rel,fuchsia-x64-cast-receiver-rel
Bug: 41481724
Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Reviewed-by: Scott Violet <s...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpa...@chromium.org>
Commit-Queue: Zijie He <zij...@google.com>
Cr-Commit-Position: refs/heads/main@{#1293890}
Files:
  • M chrome/app/chrome_main.cc
  • M chrome/app/chrome_main_delegate.cc
  • M chrome/browser/about_flags.cc
  • M chrome/browser/apps/platform_apps/app_browsertest.cc
  • M chrome/browser/apps/platform_apps/platform_app_launch.h
  • M chrome/browser/browser_switcher/browser_switcher_service_factory.cc
  • M chrome/browser/chrome_browser_field_trials.cc
  • M chrome/browser/chrome_browser_interface_binders.cc
  • M chrome/browser/chrome_browser_main.cc
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/chrome_service_worker_browsertest.cc
  • M chrome/browser/component_updater/registration.cc
  • M chrome/browser/crash_upload_list/crash_upload_list.cc
  • M chrome/browser/device_identity/device_oauth2_token_service_factory.cc
  • M chrome/browser/devtools/devtools_browsertest.cc
  • M chrome/browser/devtools/devtools_file_watcher_unittest.cc
  • M chrome/browser/diagnostics/diagnostics_model.cc
  • M chrome/browser/downgrade/downgrade_utils.cc
  • M chrome/browser/downgrade/user_data_downgrade.cc
  • M chrome/browser/download/download_browsertest.cc
  • M chrome/browser/download/download_browsertest_utils.h
  • M chrome/browser/download/download_commands.cc
  • M chrome/browser/download/download_commands.h
  • M chrome/browser/download/download_prefs.cc
  • M chrome/browser/enterprise/connectors/connectors_prefs.cc
  • M chrome/browser/enterprise/connectors/connectors_service_browsertest.cc
  • M chrome/browser/enterprise/connectors/reporting/browser_crash_event_router.cc
  • M chrome/browser/enterprise/connectors/reporting/crash_reporting_context.cc
  • M chrome/browser/enterprise/connectors/reporting/crash_reporting_context.h
  • M chrome/browser/enterprise/connectors/reporting/crash_reporting_context_browsertest.cc
  • M chrome/browser/enterprise/connectors/reporting/crash_reporting_context_unittest.cc
  • M chrome/browser/enterprise/identifiers/profile_id_delegate_impl.cc
  • M chrome/browser/enterprise/identifiers/profile_id_service_factory_unittest.cc
  • M chrome/browser/extensions/api/file_system/file_system_apitest.cc
  • M chrome/browser/extensions/api/management/management_api_browsertest.cc
  • M chrome/browser/extensions/api/management/management_apitest.cc
  • M chrome/browser/extensions/back_forward_cache_browsertest.cc
  • M chrome/browser/extensions/extension_protocols_unittest.cc
  • M chrome/browser/extensions/extension_security_exploit_browsertest.cc
  • M chrome/browser/extensions/extension_special_storage_policy_unittest.cc
  • M chrome/browser/extensions/external_pref_loader.cc
  • M chrome/browser/external_protocol/external_protocol_handler.cc
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc
  • M chrome/browser/first_run/first_run.cc
  • M chrome/browser/first_run/first_run_unittest.cc
  • M chrome/browser/flag_descriptions.cc
  • M chrome/browser/flag_descriptions.h
  • M chrome/browser/intranet_redirect_detector.h
  • M chrome/browser/media/encrypted_media_browsertest.cc
  • M chrome/browser/media/media_engagement_preloaded_list_unittest.cc
  • M chrome/browser/media/webrtc/native_desktop_media_list.cc
  • M chrome/browser/media/webrtc/webrtc_log_uploader.cc
  • M chrome/browser/media_galleries/media_galleries_test_util.cc
  • M chrome/browser/metrics/chrome_metrics_service_client.cc
  • M chrome/browser/net/profile_network_context_service.cc
  • M chrome/browser/notifications/notification_display_service_impl.cc
  • M chrome/browser/optimization_guide/model_execution/model_execution_browsertest.cc
  • M chrome/browser/optimization_guide/optimization_guide_keyed_service_browsertest.cc
  • M chrome/browser/performance_monitor/system_monitor.cc
  • M chrome/browser/policy/chrome_browser_cloud_management_controller_desktop.cc
  • M chrome/browser/policy/configuration_policy_handler_list_factory.cc
  • M chrome/browser/policy/test/autoplay_policy_browsertest.cc
  • M chrome/browser/prefs/browser_prefs.cc
  • M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
  • M chrome/browser/renderer_context_menu/render_view_context_menu.cc
  • M chrome/browser/renderer_context_menu/render_view_context_menu.h
  • M chrome/browser/search_engine_choice/search_engine_choice_dialog_service_factory.cc
  • M chrome/browser/send_tab_to_self/receiving_ui_handler_registry.cc
  • M chrome/browser/signin/dice_signed_in_profile_creator_unittest.cc
  • M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
  • M chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
  • M chrome/browser/ssl/ocsp_browsertest.cc
  • M chrome/browser/ssl/ssl_browsertest_util.cc
  • M chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc
  • M chrome/browser/sync/test/integration/single_client_dictionary_sync_test.cc
  • M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
  • M chrome/browser/sync/test/integration/two_client_dictionary_sync_test.cc
  • M chrome/browser/themes/theme_syncable_service_unittest.cc
  • M chrome/browser/ui/chrome_pages.cc
  • M chrome/browser/ui/chrome_pages.h
  • M chrome/browser/ui/sharing_hub/sharing_hub_bubble_controller.h
  • M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
  • M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
  • M chrome/browser/ui/tab_helpers.cc
  • M chrome/browser/ui/views/accelerator_table.cc
  • M chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc
  • M chrome/browser/ui/views/page_info/page_info_permission_content_view.cc
  • M chrome/browser/ui/views/page_info/page_info_permission_content_view.h
  • M chrome/browser/ui/views/page_info/page_info_permission_content_view_unittest.cc
  • M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.cc
  • M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view.h
  • M chrome/browser/ui/views/permissions/permission_prompt_bubble_one_origin_view_unittest.cc
  • M chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_unittest.cc
  • M chrome/browser/ui/web_applications/web_app_dialogs.h
  • M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
  • M chrome/browser/ui/webui/print_preview/pdf_printer_handler.cc
  • M chrome/browser/web_applications/os_integration/web_app_shortcut.cc
  • M chrome/browser/web_applications/web_app_helpers.cc
  • M chrome/browser/web_applications/web_app_install_info.h
  • M chrome/common/channel_info.h
  • M chrome/common/channel_info_unittest.cc
  • M chrome/common/chrome_features.cc
  • M chrome/common/chrome_features.h
  • M chrome/common/chrome_paths.cc
  • M chrome/common/chrome_paths_unittest.cc
  • M chrome/common/chrome_switches.cc
  • M chrome/common/chrome_switches.h
  • M chrome/common/logging_chrome.cc
  • M chrome/common/pref_names.h
  • M chrome/common/url_constants.h
  • M chrome/common/webui_url_constants.cc
  • M chrome/common/webui_url_constants.h
  • M chrome/installer/util/google_update_settings.h
  • M chrome/test/base/browser_tests_main.cc
  • M chrome/test/base/chrome_test_suite.cc
  • M chrome/test/base/scoped_channel_override.h
  • M chrome/test/base/test_browser_window.h
  • M chrome/utility/importer/firefox_importer.cc
  • M chrome/utility/importer/firefox_importer.h
  • M chrome/utility/safe_browsing/seven_zip_analyzer.cc
Change size: L
Delta: 120 files changed, 229 insertions(+), 588 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Scott Violet, +1 by Demetrios Papadopoulos, +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id1a79c4bdef69ca7e5e87ac1cd1a86c8fd25e8d5
Gerrit-Change-Number: 5485913
Gerrit-PatchSet: 15
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
open
diffy
satisfied_requirement

Lei Zhang (Gerrit)

unread,
Feb 26, 2026, 8:06:39 PMFeb 26
to Chromium LUCI CQ, Zijie He, Yann Dago, Alexei Svitkine, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Lei Zhang added 1 comment

File chrome/browser/signin/dice_signed_in_profile_creator_unittest.cc
Line 248, Patchset 15 (Latest): // I don't know why this test looks like this, but I am only removing
Lei Zhang . resolved

This file could have been left out of this CL and dealt with separately. Based on the prior comment, I uploaded https://crrev.com/c/7613644.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Comment-Date: Fri, 27 Feb 2026 01:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Mar 3, 2026, 3:57:23 PM (10 days ago) Mar 3
to Chromium LUCI CQ, Yann Dago, Alexei Svitkine, Daniel Cheng, Demetrios Papadopoulos, Chromium IPC Reviews, Scott Violet, Lei Zhang, Enterprise Policy Reviews, Simon Hangl, Peter Beverloo, Andrew Rayskiy, Rijubrata Bhaumik, Tommy Li, Mathias Bynens, AyeAye, chromium...@chromium.org, David Worsham, Robert Kroeger, print-revi...@chromium.org, net-r...@chromium.org, dtraino...@chromium.org, loyso...@chromium.org, dominickn+watch-...@chromium.org, chromiumme...@microsoft.com, mgiuca...@chromium.org, dominickn+...@chromium.org, tgupta...@chromium.org, olesiamaru...@google.com, extension...@chromium.org, dpr-eng+c...@google.com, dmurph+watc...@chromium.org, mkwst+w...@chromium.org, kuragin+web-ap...@chromium.org, permissio...@chromium.org, kinuko+...@chromium.org, eme-r...@chromium.org, glenro...@chromium.org, grt+...@chromium.org, jeffreycohen+watc...@chromium.org, jmedle...@chromium.org, philli...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, alancutter...@chromium.org, blundell+...@chromium.org, antoniosarto...@chromium.org, zelin+watch-we...@chromium.org, arthursonzog...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chrome-intell...@chromium.org, chrome-waff...@google.com, dominickn+wat...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dmurph+wat...@chromium.org, ericwillige...@chromium.org, ydago...@chromium.org, dibyapal+wa...@chromium.org, chfreme...@chromium.org, webap...@microsoft.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Zijie He added 1 comment

File chrome/browser/signin/dice_signed_in_profile_creator_unittest.cc
Line 248, Patchset 15 (Latest): // I don't know why this test looks like this, but I am only removing
Lei Zhang . resolved

This file could have been left out of this CL and dealt with separately. Based on the prior comment, I uploaded https://crrev.com/c/7613644.

Zijie He

😂

Gerrit-Comment-Date: Tue, 03 Mar 2026 20:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages