display: Maintain HDR color when switching primary display [chromium/src : main]

0 views
Skip to first unread message

Sasha McIntosh (Gerrit)

unread,
Sep 13, 2023, 5:22:48 PM9/13/23
to ozone-...@chromium.org

Sasha McIntosh uploaded patch set #2 to this change.

View Change

display: Maintain HDR color when switching primary display

When the internal display is removed from the display list, we switch an
external display to be the primary display. During the process we should
update the color space of the new primary display.

Also, add color space info to ManagedDisplayInfo logging.

Bug: b:299966444
Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
---
M ash/display/window_tree_host_manager.cc
M ui/display/manager/managed_display_info.cc
2 files changed, 13 insertions(+), 3 deletions(-)

To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
Gerrit-Change-Number: 4864480
Gerrit-PatchSet: 2
Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>

Sasha McIntosh (Gerrit)

unread,
Sep 14, 2023, 12:21:52 PM9/14/23
to Ahmed Fakhry, ozone-...@chromium.org

Attention is currently required from: Ahmed Fakhry.

Sasha McIntosh would like Ahmed Fakhry to review this change.

View Change

display: Maintain HDR color when switching primary display

When the internal display is removed from the display list, we switch an
external display to be the primary display. During the process we should
update the color space of the new primary display.

Also, add color space info to ManagedDisplayInfo logging.

Bug: b:299966444
Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
---
M ash/display/window_tree_host_manager.cc
M ui/display/manager/managed_display_info.cc
M ui/display/manager/managed_display_info_unittest.cc
3 files changed, 18 insertions(+), 6 deletions(-)


To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
Gerrit-Change-Number: 4864480
Gerrit-PatchSet: 3
Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
Gerrit-Attention: Ahmed Fakhry <afa...@chromium.org>

Sasha McIntosh (Gerrit)

unread,
Sep 14, 2023, 12:21:57 PM9/14/23
to ozone-...@chromium.org, Ahmed Fakhry, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ahmed Fakhry.

Patch set 3:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
    Gerrit-Change-Number: 4864480
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
    Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Attention: Ahmed Fakhry <afa...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 Sep 2023 16:21:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Ahmed Fakhry (Gerrit)

    unread,
    Sep 14, 2023, 9:26:00 PM9/14/23
    to Sasha McIntosh, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Sasha McIntosh.

    Patch set 3:Code-Review +1

    View Change

    2 comments:

    • Patchset:

    • File ash/display/window_tree_host_manager.cc:

    To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
    Gerrit-Change-Number: 4864480
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
    Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Attention: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 Sep 2023 01:25:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Sasha McIntosh (Gerrit)

    unread,
    Sep 15, 2023, 1:22:57 PM9/15/23
    to ozone-...@chromium.org, Ahmed Fakhry, Chromium LUCI CQ, chromium...@chromium.org

    Patch set 4:Auto-Submit +1Commit-Queue +2

    View Change

    1 comment:

    • File ash/display/window_tree_host_manager.cc:

      • Done

    To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
    Gerrit-Change-Number: 4864480
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
    Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 Sep 2023 17:22:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Ahmed Fakhry <afa...@chromium.org>

    Sasha McIntosh (Gerrit)

    unread,
    Sep 15, 2023, 1:34:34 PM9/15/23
    to ozone-...@chromium.org, Ahmed Fakhry, Chromium LUCI CQ, chromium...@chromium.org

    Patch set 5:Commit-Queue +2

    View Change

      To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
      Gerrit-Change-Number: 4864480
      Gerrit-PatchSet: 5
      Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
      Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
      Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 Sep 2023 17:34:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      Sasha McIntosh (Gerrit)

      unread,
      Sep 15, 2023, 1:54:01 PM9/15/23
      to ozone-...@chromium.org, Ahmed Fakhry, Chromium LUCI CQ, chromium...@chromium.org

      Patch set 7:Commit-Queue +2

      View Change

        To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
        Gerrit-Change-Number: 4864480
        Gerrit-PatchSet: 7
        Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
        Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
        Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
        Gerrit-Comment-Date: Fri, 15 Sep 2023 17:53:52 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        Chromium LUCI CQ (Gerrit)

        unread,
        Sep 15, 2023, 2:43:51 PM9/15/23
        to Sasha McIntosh, ozone-...@chromium.org, Ahmed Fakhry, chromium...@chromium.org

        Chromium LUCI CQ submitted this change.

        View Change



        3 is the latest approved patch-set.
        The change was submitted with unreviewed changes in the following files:

        ```
        The name of the file: ash/display/window_tree_host_manager.cc
        Insertions: 3, Deletions: 3.

        The diff is too large to show. Please review the diff.
        ```

        Approvals: Sasha McIntosh: Send CL to CQ automatically after approval; Commit Ahmed Fakhry: Looks good to me
        display: Maintain HDR color when switching primary display

        When the internal display is removed from the display list, we switch an
        external display to be the primary display. During the process we should
        update the color space of the new primary display.

        Also, add color space info to ManagedDisplayInfo logging.

        Bug: b:299966444
        Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864480
        Commit-Queue: Sasha McIntosh <sasham...@chromium.org>
        Reviewed-by: Ahmed Fakhry <afa...@chromium.org>
        Auto-Submit: Sasha McIntosh <sasham...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1197280}

        ---
        M ash/display/window_tree_host_manager.cc
        M ui/display/manager/managed_display_info.cc
        M ui/display/manager/managed_display_info_unittest.cc
        3 files changed, 18 insertions(+), 6 deletions(-)


        To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
        Gerrit-Change-Number: 4864480
        Gerrit-PatchSet: 8
        Gerrit-Owner: Sasha McIntosh <sasham...@chromium.org>
        Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Sasha McIntosh <sasham...@chromium.org>
        Reply all
        Reply to author
        Forward
        0 new messages