display: Maintain HDR color when switching primary display [chromium/src : main]
Sasha McIntosh (Gerrit)
Sasha McIntosh uploaded patch set #2 to this change.
display: Maintain HDR color when switching primary display
When the internal display is removed from the display list, we switch an
external display to be the primary display. During the process we should
update the color space of the new primary display.
Also, add color space info to ManagedDisplayInfo logging.
Bug: b:299966444
Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
---
M ash/display/window_tree_host_manager.cc
M ui/display/manager/managed_display_info.cc
2 files changed, 13 insertions(+), 3 deletions(-)
To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.
Sasha McIntosh (Gerrit)
Attention is currently required from: Ahmed Fakhry.
Sasha McIntosh would like Ahmed Fakhry to review this change.
display: Maintain HDR color when switching primary display
When the internal display is removed from the display list, we switch an
external display to be the primary display. During the process we should
update the color space of the new primary display.
Also, add color space info to ManagedDisplayInfo logging.
Bug: b:299966444
Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
---
M ash/display/window_tree_host_manager.cc
M ui/display/manager/managed_display_info.cc
M ui/display/manager/managed_display_info_unittest.cc
3 files changed, 18 insertions(+), 6 deletions(-)
Sasha McIntosh (Gerrit)
Attention is currently required from: Ahmed Fakhry.
Patch set 3:Auto-Submit +1Commit-Queue +1
Ahmed Fakhry (Gerrit)
Attention is currently required from: Sasha McIntosh.
Patch set 3:Code-Review +1
2 comments:
Patchset:
LGTM % below.
File ash/display/window_tree_host_manager.cc:
Patch Set #3, Line 683:
primary_displayNit: Can you please call this `new_primary_display` to be clear?
To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.
Sasha McIntosh (Gerrit)
Patch set 4:Auto-Submit +1Commit-Queue +2
1 comment:
File ash/display/window_tree_host_manager.cc:
Patch Set #3, Line 683:
primary_displayNit: Can you please call this `new_primary_display` to be clear?
Done
To view, visit change 4864480. To unsubscribe, or for help writing mail filters, visit settings.
Sasha McIntosh (Gerrit)
Patch set 5:Commit-Queue +2
Sasha McIntosh (Gerrit)
Patch set 7:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ash/display/window_tree_host_manager.cc
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
display: Maintain HDR color when switching primary display
When the internal display is removed from the display list, we switch an
external display to be the primary display. During the process we should
update the color space of the new primary display.
Also, add color space info to ManagedDisplayInfo logging.
Bug: b:299966444
Change-Id: Ib857c41af7e678a09993aff5c42958b954634e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864480
Commit-Queue: Sasha McIntosh <sasham...@chromium.org>
Reviewed-by: Ahmed Fakhry <afa...@chromium.org>
Auto-Submit: Sasha McIntosh <sasham...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1197280}
---
M ash/display/window_tree_host_manager.cc
M ui/display/manager/managed_display_info.cc
M ui/display/manager/managed_display_info_unittest.cc
3 files changed, 18 insertions(+), 6 deletions(-)