Mark an event generated by display config change IS_SYNTHESIZED [chromium/src : main]
0 views
Skip to first unread message
Mitsuru Oshima (Gerrit)
Aug 31, 2025, 9:26:14 PM (7 days ago) Aug 31
to Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Yuichiro Hanada
Mitsuru Oshima voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Yuichiro Hanada
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Aug 31, 2025, 9:26:40 PM (7 days ago) Aug 31
to Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Yuichiro Hanada
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yuichiro Hanada
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuichiro Hanada (Gerrit)
Sep 2, 2025, 2:46:22 AM (6 days ago) Sep 2
to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Mitsuru Oshima
Yuichiro Hanada voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuichiro Hanada
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Yuichiro Hanada . resolved
lgtm with a nit. Thanks for the fix!!
File ui/events/ozone/evdev/event_factory_evdev.h
Line 75, Patchset 6 (Latest):
// Creates and dispatches a synthesized mouse move caused. This event is usedYuichiro Hanada . unresolved
nit: event?
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Sep 2, 2025, 6:12:32 AM (6 days ago) Sep 2
to Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Mitsuru Oshima voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Commit-Queue | +2 |
1 comment
File ui/events/ozone/evdev/event_factory_evdev.h
Line 75, Patchset 6:
// Creates and dispatches a synthesized mouse move caused. This event is usedYuichiro Hanada . resolved
Mitsuru Oshimanit: event?
Fix applied.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 2, 2025, 6:43:21 AM (6 days ago) Sep 2
to Mitsuru Oshima, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/events/ozone/evdev/event_factory_evdev.h
Insertions: 1, Deletions: 1.
@@ -72,7 +72,7 @@
void WarpCursorTo(gfx::AcceleratedWidget widget,
const gfx::PointF& location);
- // Creates and dispatches a synthesized mouse move caused. This event is used
+ // Creates and dispatches a synthesized mouse move event. This event is used
// to notify the logical location has been changed even if a user didn't move
// the mouse, such as display configuration change.
void SynthesizeMouseMove(const gfx::PointF& location);
```
Change information
Commit message:
Mark an event generated by display config change IS_SYNTHESIZED
This will keep the mouse invisible and prevent being used by an app.
This CL rename GenerateMouseMove to SynthesizeMouseMove to be more
explicit.
Bug: 438837665, 440508983
Change-Id: Ic2c573d7022ae64247cc4507311590c2d6a8a138
Reviewed-by: Yuichiro Hanada <yha...@chromium.org>
Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1509456}
Files:
- M ui/events/ozone/evdev/event_factory_evdev.cc
- M ui/events/ozone/evdev/event_factory_evdev.h
- M ui/ozone/platform/drm/host/drm_cursor.cc
- M ui/ozone/platform/drm/host/drm_window_host.cc
- M ui/ozone/platform/drm/host/drm_window_host.h
Change size: S
Delta: 5 files changed, 12 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuichiro Hanada
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages