ozone/evdev: Permanently enable HeatmapPalmDetection [chromium/src : main]

0 views
Skip to first unread message

Komal Sambranikar (xWF) (Gerrit)

unread,
Jun 10, 2026, 3:58:51 AMJun 10
to Kenneth Albanowski, Henry Barnor, CrOS Platform Inputs Reviewers, Code Review Nudger, Sean O'Brien, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org

Komal Sambranikar (xWF) abandoned this change.

View Change

Abandoned

Komal Sambranikar (xWF) abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib8ee8f28ab6f500b1318f6e5b63648f50b44af18
Gerrit-Change-Number: 7874233
Gerrit-PatchSet: 7
Gerrit-Owner: Komal Sambranikar (xWF) <sambr...@google.com>
Gerrit-Reviewer: Kenneth Albanowski <ken...@google.com>
Gerrit-Reviewer: Komal Sambranikar (xWF) <sambr...@google.com>
Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: CrOS Platform Inputs Reviewers <cros-p12...@google.com>
Gerrit-CC: Henry Barnor <hba...@chromium.org>
Gerrit-CC: Srikanth Rajagopalan (xWF) <rajago...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Komal Sambranikar (xWF) (Gerrit)

unread,
Jun 10, 2026, 4:52:54 AMJun 10
to Kenneth Albanowski, Henry Barnor, CrOS Platform Inputs Reviewers, Code Review Nudger, Sean O'Brien, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org

Komal Sambranikar (xWF) restored this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: restore
satisfied_requirement
unsatisfied_requirement
open
diffy

Komal Sambranikar (xWF) (Gerrit)

unread,
Jun 10, 2026, 6:20:02 AMJun 10
to Sean O'Brien, Kenneth Albanowski, Henry Barnor, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Kenneth Albanowski and Sean O'Brien

Komal Sambranikar (xWF) voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kenneth Albanowski
  • Sean O'Brien
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I659aa81e49c4f7e68f061cb40a4e58130c5a58dc
Gerrit-Change-Number: 7901760
Gerrit-PatchSet: 6
Gerrit-Owner: Komal Sambranikar (xWF) <sambr...@google.com>
Gerrit-Reviewer: Kenneth Albanowski <ken...@google.com>
Gerrit-Reviewer: Komal Sambranikar (xWF) <sambr...@google.com>
Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Henry Barnor <hba...@chromium.org>
Gerrit-CC: Srikanth Rajagopalan (xWF) <rajago...@google.com>
Gerrit-Attention: Kenneth Albanowski <ken...@google.com>
Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Jun 2026 10:19:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sean O'Brien (Gerrit)

unread,
Jun 10, 2026, 10:01:03 AMJun 10
to Komal Sambranikar (xWF), CrOS Platform Inputs Reviewers, Kenneth Albanowski, Henry Barnor, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Henry Barnor, Kenneth Albanowski and Komal Sambranikar (xWF)

Sean O'Brien added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Sean O'Brien . unresolved

This LGTM assuming we want to enable this permanently. The study is currently not active, but it was extended repeatedly in 2025: https://source.corp.google.com/piper///depot/google3/googledata/googleclient/chrome/finch/gcl_studies/chrome_os/HeatmapPalmDetection.gcl

hbarnor@, can you confirm that we want this enabled?

Open in Gerrit

Related details

Attention is currently required from:
  • Henry Barnor
  • Kenneth Albanowski
  • Komal Sambranikar (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I659aa81e49c4f7e68f061cb40a4e58130c5a58dc
    Gerrit-Change-Number: 7901760
    Gerrit-PatchSet: 6
    Gerrit-Owner: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Kenneth Albanowski <ken...@google.com>
    Gerrit-Reviewer: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: CrOS Platform Inputs Reviewers <cros-p12...@google.com>
    Gerrit-CC: Henry Barnor <hba...@chromium.org>
    Gerrit-CC: Srikanth Rajagopalan (xWF) <rajago...@google.com>
    Gerrit-Attention: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Attention: Kenneth Albanowski <ken...@google.com>
    Gerrit-Attention: Henry Barnor <hba...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 14:00:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Henry Barnor (Gerrit)

    unread,
    Jun 12, 2026, 5:56:36 PMJun 12
    to Komal Sambranikar (xWF), Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Sean O'Brien, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
    Attention needed from Kenneth Albanowski and Komal Sambranikar (xWF)

    Henry Barnor added 1 comment

    Patchset-level comments
    Sean O'Brien . unresolved

    This LGTM assuming we want to enable this permanently. The study is currently not active, but it was extended repeatedly in 2025: https://source.corp.google.com/piper///depot/google3/googledata/googleclient/chrome/finch/gcl_studies/chrome_os/HeatmapPalmDetection.gcl

    hbarnor@, can you confirm that we want this enabled?

    Henry Barnor

    Nope. We want it disabled though it would be good to enable it in a builds as needed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenneth Albanowski
    • Komal Sambranikar (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I659aa81e49c4f7e68f061cb40a4e58130c5a58dc
    Gerrit-Change-Number: 7901760
    Gerrit-PatchSet: 6
    Gerrit-Owner: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Kenneth Albanowski <ken...@google.com>
    Gerrit-Reviewer: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: CrOS Platform Inputs Reviewers <cros-p12...@google.com>
    Gerrit-CC: Henry Barnor <hba...@chromium.org>
    Gerrit-CC: Jingyuan Liang <jingy...@chromium.org>
    Gerrit-CC: Srikanth Rajagopalan (xWF) <rajago...@google.com>
    Gerrit-Attention: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Attention: Kenneth Albanowski <ken...@google.com>
    Gerrit-Comment-Date: Fri, 12 Jun 2026 21:56:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Sean O'Brien <seob...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sean O'Brien (Gerrit)

    unread,
    Jun 23, 2026, 12:36:30 PM (8 days ago) Jun 23
    to Komal Sambranikar (xWF), Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Henry Barnor, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
    Attention needed from Kenneth Albanowski and Komal Sambranikar (xWF)

    Sean O'Brien voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenneth Albanowski
    • Komal Sambranikar (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I659aa81e49c4f7e68f061cb40a4e58130c5a58dc
    Gerrit-Change-Number: 7901760
    Gerrit-PatchSet: 11
    Gerrit-Owner: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Kenneth Albanowski <ken...@google.com>
    Gerrit-Reviewer: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: CrOS Platform Inputs Reviewers <cros-p12...@google.com>
    Gerrit-CC: Henry Barnor <hba...@chromium.org>
    Gerrit-CC: Jingyuan Liang <jingy...@chromium.org>
    Gerrit-CC: Srikanth Rajagopalan (xWF) <rajago...@google.com>
    Gerrit-Attention: Komal Sambranikar (xWF) <sambr...@google.com>
    Gerrit-Attention: Kenneth Albanowski <ken...@google.com>
    Gerrit-Comment-Date: Tue, 23 Jun 2026 16:36:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Henry Barnor (Gerrit)

    unread,
    Jun 25, 2026, 1:47:36 AM (6 days ago) Jun 25
    to Komal Sambranikar (xWF), Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
    Attention needed from Kenneth Albanowski and Komal Sambranikar (xWF)

    Henry Barnor added 3 comments

    Commit Message
    Line 7, Patchset 11 (Latest):ozone/evdev: Permanently enable HeatmapPalmDetection
    Henry Barnor . unresolved

    Please fix commit message.

    Line 11, Patchset 11 (Latest):constexpr boolean set to false. This keeps the code available for local testing if needed.
    Henry Barnor . unresolved

    Please wrap at 72 characters.

    Line 22, Patchset 11 (Latest):TEST=ozone_unittests, events_unittests
    Henry Barnor . unresolved

    Please test two cases (enabled/disabled) on device and ensure device boots without crashes at the minimum.

    Gerrit-Comment-Date: Thu, 25 Jun 2026 05:47:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages