[ozone/wayland] Don't reconfigure window geometry while minimized [chromium/src : main]
0 views
Skip to first unread message
Денис Баширов (Gerrit)
Jun 17, 2026, 4:03:56 PM (12 days ago) Jun 17
to Maksim Sisov, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Maksim Sisov and Nick Yamane
Денис Баширов added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Денис Баширов . resolved
New external contributor; fixes crbug.com/396148609 (Wayland minimize/restore jump). PTAL.
Related details
Attention is currently required from:
- Antonio Gomes Netto
- Maksim Sisov
- Nick Yamane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
Jun 18, 2026, 4:01:59 AM (11 days ago) Jun 18
to Денис Баширов, Kramer Ge, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane and Денис Баширов
Maksim Sisov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Maksim Sisov . resolved
Denis, please add yourself to the AUTHORS file (can do that in this CL)
Related details
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Денис Баширов (Gerrit)
Jun 18, 2026, 4:42:37 AM (11 days ago) Jun 18
to Kramer Ge, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Maksim Sisov and Nick Yamane
Денис Баширов added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Maksim Sisov . resolved
Denis, please add yourself to the AUTHORS file (can do that in this CL)
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Maksim Sisov
- Nick Yamane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
Jun 18, 2026, 5:12:23 AM (11 days ago) Jun 18
to Денис Баширов, Kramer Ge, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane and Денис Баширов
Maksim Sisov voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
Jun 19, 2026, 2:16:12 PM (10 days ago) Jun 19
to Денис Баширов, Kramer Ge, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane and Денис Баширов
Maksim Sisov voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 19, 2026, 4:28:31 PM (10 days ago) Jun 19
to Денис Баширов, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Nick Yamane and Денис Баширов
Kramer Ge added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 3 (Latest):
shadow insets (e.g. 16,10,16,32px): its buffer includes the shadow and theKramer Ge . unresolved
nit: plz format the commit messages to be wrapped to 72 columns.
Related details
Attention is currently required from:
- Antonio Gomes Netto
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Денис Баширов (Gerrit)
Jun 19, 2026, 4:51:46 PM (10 days ago) Jun 19
to Maksim Sisov, Kramer Ge, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge and Nick Yamane
Денис Баширов added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 3:
shadow insets (e.g. 16,10,16,32px): its buffer includes the shadow and theKramer Ge . resolved
nit: plz format the commit messages to be wrapped to 72 columns.
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Nick Yamane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 22, 2026, 5:27:15 PM (7 days ago) Jun 22
to Денис Баширов, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Nick Yamane and Денис Баширов
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Antonio Gomes Netto
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 22, 2026, 5:51:57 PM (7 days ago) Jun 22
to Денис Баширов, Thomas Anderson, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Nick Yamane, Thomas Anderson and Денис Баширов
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes Netto
- Nick Yamane
- Thomas Anderson
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 22, 2026, 5:52:26 PM (7 days ago) Jun 22
to Денис Баширов, Thomas Anderson, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane, Thomas Anderson and Денис Баширов
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
Thomas Anderson (Gerrit)
Jun 22, 2026, 5:56:52 PM (7 days ago) Jun 22
to Денис Баширов, Kramer Ge, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane and Денис Баширов
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes Netto
- Kramer Ge
- Nick Yamane
- Денис Баширов
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jun 22, 2026, 5:56:55 PM (7 days ago) Jun 22
to Денис Баширов, Kramer Ge, Maksim Sisov, Chromium LUCI CQ, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Gomes Netto, Kramer Ge, Nick Yamane and Денис Баширов
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Jun 22, 2026, 7:14:25 PM (6 days ago) Jun 22
to Денис Баширов, Thomas Anderson, Kramer Ge, Maksim Sisov, Nick Yamane, Antonio Gomes Netto, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ozone/wayland] Don't reconfigure window geometry while minimized
Under Wayland with client-side decorations a restored toplevel reserves
shadow insets (e.g. 16,10,16,32px): its buffer includes the shadow and
the xdg_surface window geometry origin is offset to the (left,top)
inset.
When the window is minimized Chromium collapses this layout - the
geometry origin drops to (0,0) and the bounds shrink to the no-shadow
configure size. On un-minimize both are restored, but the buffer is
re-attached without a compensating wl_surface.offset, so the compositor
briefly shows the restored (shadowed) buffer against the still-collapsed
anchor. The window appears shifted (down by the top inset; the page
shifts by the left inset) for a frame or two before snapping back. X11
is unaffected because its frame/shadow does not require per-state
geometry reconfiguration.
A minimized toplevel is not visible, so there is no reason to mutate its
geometry or bounds. Keep both at their restored values while minimized,
so the last committed frame matches the geometry the compositor retains,
eliminating the transient jump on un-minimize.
Wayland; window and page no longer jump on un-minimize.
Bug: 396148609
Test: Minimize/restore a non-maximized window on GNOME/Mutter
Test: ozone_unittests --gtest_filter=*MinimizedWindowDoesNot*
Change-Id: I301b5fd82a3384d2f2ff95714bbd4feb6326f326
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Maksim Sisov <msi...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1650646}
Files:
- M AUTHORS
- M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
- M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
Change size: M
Delta: 3 files changed, 94 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Maksim Sisov, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages