[viz] Remove features that are just declared [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Jan 21, 2026, 12:39:16 PM (12 days ago) Jan 21
to Kyle Charbonneau, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Kyle Charbonneau and Saifuddin Hitawala

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Kyle Charbonneau
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Gerrit-Change-Number: 7500191
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:39:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jan 21, 2026, 12:54:32 PM (12 days ago) Jan 21
to Saifuddin Hitawala, Colin Blundell, Kyle Charbonneau, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Kyle Charbonneau and Saifuddin Hitawala

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Charbonneau
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Gerrit-Change-Number: 7500191
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kyle Charbonneau (Gerrit)

unread,
Jan 21, 2026, 1:33:54 PM (12 days ago) Jan 21
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Saifuddin Hitawala

Kyle Charbonneau voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Gerrit-Change-Number: 7500191
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 18:33:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Saifuddin Hitawala (Gerrit)

unread,
Jan 21, 2026, 1:55:00 PM (12 days ago) Jan 21
to Kyle Charbonneau, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Saifuddin Hitawala voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Gerrit-Change-Number: 7500191
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 18:54:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 21, 2026, 1:57:56 PM (12 days ago) Jan 21
to Saifuddin Hitawala, Kyle Charbonneau, Colin Blundell, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[viz] Remove features that are just declared

As part of Code Health rotation, cleaning up some viz features that
are presumably launched as they are just declared but not defined
anywhere.
Bug: 356200701
Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572452}
Files:
  • M components/viz/common/features.h
  • M ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc
  • M ui/ozone/platform/flatland/overlay_manager_flatland.cc
Change size: XS
Delta: 3 files changed, 2 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kyle Charbonneau, +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5e0ef5578893293052762655ff81c6d5e625f6d
Gerrit-Change-Number: 7500191
Gerrit-PatchSet: 4
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kyle Charbonneau <kyle...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages