Block base::DIR_CACHE in File System Access API on Linux/ChromeOS [chromium/src : main]

0 views
Skip to first unread message

Antonio Sartori (Gerrit)

unread,
Jul 22, 2026, 2:04:46 AM (yesterday) Jul 22
to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, ozone-...@chromium.org, storage...@chromium.org
Attention needed from Etienne Bergeron

Antonio Sartori voted and added 1 comment

Votes added by Antonio Sartori

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Antonio Sartori . resolved

thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Bergeron
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I085954d4cc09a126e916e2fe0053fe5c1f0fd1aa
Gerrit-Change-Number: 8126779
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Bergeron <etie...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Etienne Bergeron <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Jul 2026 06:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Bergeron (Gerrit)

unread,
Jul 22, 2026, 10:44:05 AM (21 hours ago) Jul 22
to Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, ozone-...@chromium.org, storage...@chromium.org

Etienne Bergeron voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I085954d4cc09a126e916e2fe0053fe5c1f0fd1aa
Gerrit-Change-Number: 8126779
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Bergeron <etie...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Jul 2026 14:43:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 22, 2026, 10:48:05 AM (21 hours ago) Jul 22
to Etienne Bergeron, Antonio Sartori, chromium...@chromium.org, Permissions Reviews, ozone-...@chromium.org, storage...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Block base::DIR_CACHE in File System Access API on Linux/ChromeOS

Add base::DIR_CACHE (~/.cache) to the File System Access blocklist
on Linux and ChromeOS platforms in addition to Android, preventing web
content from gaining write access to user cache directories.

Also add unit tests in fontconfig_util_unittest and
chrome_file_system_access_permission_context_unittest.
Bug: 513361380
Change-Id: I085954d4cc09a126e916e2fe0053fe5c1f0fd1aa
Fixed: 513361380
Commit-Queue: Etienne Bergeron <etie...@chromium.org>
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666284}
Files:
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context_unittest.cc
Change size: S
Delta: 2 files changed, 8 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Antonio Sartori
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I085954d4cc09a126e916e2fe0053fe5c1f0fd1aa
Gerrit-Change-Number: 8126779
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Bergeron <etie...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Etienne Bergeron <etie...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages