[headless] Add DevTools Emulation.updateScreen() support on Linux [chromium/src : main]
0 views
Skip to first unread message
Peter Kvitek (Gerrit)
Mar 4, 2026, 2:03:03 PM (9 days ago) Mar 4
to Andrey Kosyakov, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov and Avi Drissman
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrey Kosyakov
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Mar 4, 2026, 2:58:03 PM (9 days ago) Mar 4
to Peter Kvitek, Avi Drissman, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov and Peter Kvitek
Avi Drissman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Avi Drissman
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andrey Kosyakov
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Mar 4, 2026, 4:53:06 PM (9 days ago) Mar 4
to Peter Kvitek, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Peter Kvitek
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Andrey Kosyakov . resolved
lgtm, but perhaps we can dedupe the boilerplate between headless_shell and chrome and have most protocol code in content/ while extracting embedder-specific differences into a delegate?
Related details
Attention is currently required from:
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Mar 4, 2026, 4:59:11 PM (9 days ago) Mar 4
to Andrey Kosyakov, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Peter Kvitek added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Andrey Kosyakov . resolved
lgtm, but perhaps we can dedupe the boilerplate between headless_shell and chrome and have most protocol code in content/ while extracting embedder-specific differences into a delegate?
Peter Kvitek
I don't think screen management belongs to `//content`, however moving the related code to a shared location like `//components/headless/devtools` totally makes sense.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Mar 4, 2026, 4:59:20 PM (9 days ago) Mar 4
to Andrey Kosyakov, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Peter Kvitek voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 4, 2026, 5:02:26 PM (9 days ago) Mar 4
to Peter Kvitek, Andrey Kosyakov, Avi Drissman, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[headless] Add DevTools Emulation.updateScreen() support on Linux
http://crrev.com/c/7617849 introduced Chrome DevTools method
Emulation.updateScreen() support in Chrome Headless Shell. This CL adds
support for this method in Chrome Headless Mode on Linux.
Bug: 397350115
Change-Id: Ief8f108a423c21aff3f0a92ef4dcc93a1fd99080
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Commit-Queue: Peter Kvitek <kvi...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1594231}
Files:
- M chrome/browser/devtools/inspector_protocol_config.json
- M chrome/browser/devtools/protocol/emulation_handler.cc
- M chrome/browser/devtools/protocol/emulation_handler.h
- M chrome/browser/headless/headless_mode_protocol_browsertest.cc
- M ui/ozone/platform/headless/headless_screen.cc
Change size: M
Delta: 5 files changed, 138 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages