Revert "[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat" [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Jan 8, 2026, 6:30:20 AM (3 days ago) Jan 8
to Gabrielle Lau, Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Daniel Cheng and Saifuddin Hitawala
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Colin Blundell
- Daniel Cheng
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabrielle Lau (Gerrit)
Jan 8, 2026, 6:32:56 AM (3 days ago) Jan 8
to Rubber Stamper, Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Daniel Cheng and Saifuddin Hitawala
Gabrielle Lau added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gabrielle Lau . resolved
Hi Colin, gardener here. LUCI bisection found this the culprit CL for tree closure, is it ok to revert this? I've re-opened the tree in the meantime.
https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693246647954167649
```
Justification:
The build failed in `ui/ozone/platform/cast/ozone_platform_cast.cc` with `error: no member named 'kBGRA_8888' in 'viz::SharedImageFormat'`. This CL modified that specific file to use `SharedImageFormat` for `IsNativePixmapConfigSupported` and likely introduced the incorrect reference to `kBGRA_8888`.
```
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 8, 2026, 6:33:55 AM (3 days ago) Jan 8
to Gabrielle Lau, Rubber Stamper, Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, Daniel Cheng, AyeAye, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Daniel Cheng and Saifuddin Hitawala
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection recommends submitting this revert because it has confirmed the target of this revert is the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693246229496375265
Sample failed build: https://ci.chromium.org/b/8693246229496375265
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7380105&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8693246229496375265&type=BUG
Gabrielle Lau (Gerrit)
Jan 8, 2026, 6:40:57 AM (3 days ago) Jan 8
to Rubber Stamper, Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Daniel Cheng and Saifuddin Hitawala
Gabrielle Lau voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Colin Blundell
- Daniel Cheng
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 8, 2026, 6:48:27 AM (3 days ago) Jan 8
to Gabrielle Lau, Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell, Daniel Cheng and Saifuddin Hitawala
Message from Rubber Stamper![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Colin Blundell
- Daniel Cheng
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 6:50:30 AM (3 days ago) Jan 8
to Gabrielle Lau, Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng, Gabrielle Lau and Saifuddin Hitawala
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Cheng
- Gabrielle Lau
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabrielle Lau (Gerrit)
Jan 8, 2026, 6:50:49 AM (3 days ago) Jan 8
to Markus Heintz, Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng, Gabrielle Lau, Markus Heintz and Saifuddin Hitawala
Gabrielle Lau voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gabrielle Lau
| Owners-Override | +1 |
1 comment
Patchset-level comments
Gabrielle Lau . resolved
Hi Markus (gardener), can you vote CR+1 please? Lost the bot stamp after rebasing locally to resolve merge conflict (patchset 2).
Related details
Attention is currently required from:
- Daniel Cheng
- Gabrielle Lau
- Markus Heintz
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabrielle Lau (Gerrit)
Jan 8, 2026, 6:51:38 AM (3 days ago) Jan 8
to Markus Heintz, Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng, Markus Heintz and Saifuddin Hitawala
Gabrielle Lau voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
- Markus Heintz
- Saifuddin Hitawala
Colin Blundell (Gerrit)
Jan 8, 2026, 6:52:22 AM (3 days ago) Jan 8
to Gabrielle Lau, Markus Heintz, Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Daniel Cheng, Markus Heintz and Saifuddin Hitawala
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Thank you, Gabrielle!
Colin Blundell
Will need to revert the two dependent CLs first, I'll take care of that.
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 6:56:29 AM (3 days ago) Jan 8
to Gabrielle Lau, Markus Heintz, Colin Blundell, Saifuddin Hitawala, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat"
This reverts commit d4e7e03122e4064cf5e9b05c7b07b7d97fe2afa9.
Reason for revert: Suspected culprit found by LUCI bisection for tree closure:
https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8693246647954167649
Tree is closed (Automatic: "compile" on https://cr-buildbucket.appspot.com/build/8693246647954167649 linux-cast-x64-rel from a986365bc5ab90b769af70b16f832e7baffd3405)
Original change's description:
> [//ui] Have OzonePlatform::IsNativePixmapConfigSupported take SIFormat
>
> Bug: 356649879
> Change-Id: Iba8e22f0d800f36a6fab4769df12ccab80374dbc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7380105
> Commit-Queue: Colin Blundell <blun...@chromium.org>
> Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566186}
Bug: 356649879
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ia5e7cd8f60e74ccd32b5f0ed8bf03b1786f1dad6
Reviewed-by: Colin Blundell <blun...@chromium.org>
Owners-Override: Gabrielle Lau <gabrie...@google.com>
Commit-Queue: Gabrielle Lau <gabrie...@google.com>
Cr-Commit-Position: refs/heads/main@{#1566204}
Files:
- M gpu/command_buffer/client/internal/mappable_buffer_test_template.h
- M gpu/command_buffer/service/shared_image/ozone_image_backing_factory_unittest.cc
- M gpu/command_buffer/service/shared_image/shared_image_factory.cc
- M ui/ozone/platform/cast/ozone_platform_cast.cc
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/platform/flatland/ozone_platform_flatland.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
- M ui/ozone/platform/x11/ozone_platform_x11.cc
- M ui/ozone/public/ozone_platform.cc
- M ui/ozone/public/ozone_platform.h
Change size: S
Delta: 10 files changed, 26 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 8, 2026, 7:17:26 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Gabrielle Lau, Markus Heintz, Colin Blundell, Saifuddin Hitawala, Daniel Cheng, AyeAye, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Markus Heintz (Gerrit)
Jan 8, 2026, 7:51:35 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Gabrielle Lau, Colin Blundell, Saifuddin Hitawala, Daniel Cheng, AyeAye, luci-bi...@appspot.gserviceaccount.com, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, nickdiego+wa...@igalia.com, fuchsia...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, spang...@chromium.org
Markus Heintz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages