[gfx] Rename IsValidBufferFormat to IsValidDrmFormat [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Feb 9, 2026, 9:30:59 AM (11 days ago) Feb 9
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell
Saifuddin Hitawala added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 9, 2026, 9:32:34 AM (11 days ago) Feb 9
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
Colin Blundell . resolved
Thanks!
File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
Line 360, Patchset 1 (Latest):
reason = "Buffer format is invalid";Colin Blundell . unresolved
nit: update
Related details
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Feb 9, 2026, 9:35:52 AM (11 days ago) Feb 9
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Saifuddin Hitawala voted and added 2 comments![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
Line 360, Patchset 1:
reason = "Buffer format is invalid";Colin Blundell . resolved
Saifuddin Hitawalanit: update
Nice, done!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Feb 9, 2026, 11:38:17 AM (11 days ago) Feb 9
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Saifuddin Hitawala voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 9, 2026, 11:41:47 AM (11 days ago) Feb 9
to Saifuddin Hitawala, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
Insertions: 1, Deletions: 1.
@@ -357,7 +357,7 @@
}
if (!IsValidDrmFormat(format)) {
- reason = "Buffer format is invalid";
+ reason = "Drm format is invalid";
}
if (!reason.empty()) {
```
Change information
Commit message:
[gfx] Rename IsValidBufferFormat to IsValidDrmFormat
Since we have removed BufferFormats, to avoid any confusion that
this method is related to BufferFormat this change renames method to
IsValidDrmFormat which is also a much better name for it.
Bug: 356649879
Change-Id: I5d08cba8115d984e1b168c067a0251ad58b895d4
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581785}
Files:
- M gpu/command_buffer/service/raster_decoder.cc
- M ui/gfx/linux/drm_util_linux.cc
- M ui/gfx/linux/drm_util_linux.h
- M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc
- M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
- M ui/ozone/platform/wayland/host/wayland_drm.cc
- M ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc
Change size: S
Delta: 7 files changed, 12 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages