[ozone] Rename GetBufferFormatModifier to GetFormatModifier [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Feb 5, 2026, 11:01:44 AMFeb 5
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, chromeos-gfx-...@google.com, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, spang...@chromium.org, vaapi-...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov

Saifuddin Hitawala added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Gerrit-Change-Number: 7544892
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Feb 5, 2026, 11:08:02 AMFeb 5
to Saifuddin Hitawala, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, chromeos-gfx-...@google.com, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, spang...@chromium.org, vaapi-...@chromium.org
Attention needed from Saifuddin Hitawala and Vasiliy Telezhnikov

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Gerrit-Change-Number: 7544892
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
Feb 5, 2026, 11:43:08 AMFeb 5
to Saifuddin Hitawala, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, chromeos-gfx-...@google.com, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, spang...@chromium.org, vaapi-...@chromium.org
Attention needed from Saifuddin Hitawala

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Gerrit-Change-Number: 7544892
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Saifuddin Hitawala (Gerrit)

unread,
Feb 5, 2026, 11:44:21 AMFeb 5
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, chromeos-gfx-...@google.com, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, spang...@chromium.org, vaapi-...@chromium.org

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+2

1 comment

Patchset-level comments
Saifuddin Hitawala . resolved

Thanks for reviews!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Gerrit-Change-Number: 7544892
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 5, 2026, 11:48:41 AMFeb 5
to Saifuddin Hitawala, Vasiliy Telezhnikov, Colin Blundell, chromium...@chromium.org, David Worsham, Robert Kroeger, cc-...@chromium.org, chromeos-gfx-...@google.com, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, headless...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, spang...@chromium.org, vaapi-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ozone] Rename GetBufferFormatModifier to GetFormatModifier

Rename GetBufferFormatModifier to GetFormatModifier as we get rid
of BufferFormat.
Bug: 356649879
Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1580161}
Files:
  • M components/viz/service/display/overlay_processor_ozone_unittest.cc
  • M gpu/command_buffer/service/drm_modifiers_filter_dawn.h
  • M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc
  • M media/gpu/chromeos/native_pixmap_frame_resource.cc
  • M media/gpu/chromeos/platform_video_frame_utils_unittest.cc
  • M media/gpu/vaapi/vaapi_wrapper.cc
  • M ui/gfx/linux/native_pixmap_dmabuf.cc
  • M ui/gfx/linux/native_pixmap_dmabuf.h
  • M ui/gfx/linux/native_pixmap_dmabuf_unittest.cc
  • M ui/gfx/native_pixmap.h
  • M ui/ozone/common/native_pixmap_egl_binding.cc
  • M ui/ozone/platform/cast/surface_factory_cast.cc
  • M ui/ozone/platform/drm/gpu/gbm_pixmap.cc
  • M ui/ozone/platform/drm/gpu/gbm_pixmap.h
  • M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.cc
  • M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.h
  • M ui/ozone/platform/headless/headless_surface_factory.cc
  • M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
  • M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.h
Change size: S
Delta: 19 files changed, 22 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell, +1 by Vasiliy Telezhnikov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I88b70ed6c40c84692b890436607b60bc633f7244
Gerrit-Change-Number: 7544892
Gerrit-PatchSet: 3
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages