Revert "[//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat)" [chromium/src : main]

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Colin Blundell and Vasiliy Telezhnikov

luci-bi...@appspot.gserviceaccount.com voted

LUCI Bisection is automatically submitting this revert.

Bot-Commit	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Vasiliy Telezhnikov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I63bfaf00278acb512ac88a492892c88d9a7dff8c

Gerrit-Change-Number: 7115983

Gerrit-PatchSet: 1

Gerrit-Owner: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-Reviewer: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Mahmoud Rashad <mmra...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Nov 2025 08:17:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "[//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat)"

This reverts commit cacfca2cb957a3384a1d8ca2fc867853fc6f02bf.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8699147411137472369

Sample failed build: https://ci.chromium.org/b/8699147411137472369

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7111560&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8699147411137472369&type=BUG

Original change's description:
> [//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat)
>
> This method is no longer overridden by any subclasses.
>
> Bug: 450325664
> Change-Id: Iff9a40548d0996bebf5a38edde0983ce10f877c2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7111560
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Commit-Queue: Colin Blundell <blun...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1539813}
>

Bug: 450325664

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: I63bfaf00278acb512ac88a492892c88d9a7dff8c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7115983

Commit-Queue: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Owners-Override: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Bot-Commit: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1539815}

Files:

• M ui/ozone/public/surface_factory_ozone.cc
• M ui/ozone/public/surface_factory_ozone.h

Change size: S

Delta: 2 files changed, 22 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I63bfaf00278acb512ac88a492892c88d9a7dff8c

Gerrit-Change-Number: 7115983

Gerrit-PatchSet: 2

[Colin Blundell (Gerrit)]

Attention needed from Mahmoud Rashad and Vasiliy Telezhnikov

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Colin Blundell . resolved

Thanks! Already landed: https://chromium-review.googlesource.com/c/chromium/src/+/7115983

Open in Gerrit

Related details

Attention is currently required from:

• Mahmoud Rashad
• Vasiliy Telezhnikov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4b0f8a9f5f49f776fb341ad632dea313b9c17e6d

Gerrit-Change-Number: 7117298

Gerrit-PatchSet: 1

Gerrit-Owner: Mahmoud Rashad <mmra...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mahmoud Rashad <mmra...@google.com>

Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Nov 2025 08:38:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mahmoud Rashad (Gerrit)]

Mahmoud Rashad abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon