Replace `std::unordered_set` with `absl::flat_hash_set`. [chromium/src : main]

0 views
Skip to first unread message

Jeffrey Yu (Gerrit)

unread,
Feb 18, 2026, 1:08:13 PM (2 days ago) Feb 18
to Colin Blundell, Code Review Nudger, Michael Spang, AyeAye, Chromium LUCI CQ, ozone-...@chromium.org
Attention needed from Colin Blundell and Michael Spang

Jeffrey Yu voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Michael Spang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia025e7c0aa3590c2d4e7fb54e2f1ebd741b71549
Gerrit-Change-Number: 7576696
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 18:08:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Feb 19, 2026, 3:08:53 AM (yesterday) Feb 19
to Jeffrey Yu, Colin Blundell, Code Review Nudger, Michael Spang, AyeAye, Chromium LUCI CQ, ozone-...@chromium.org
Attention needed from Jeffrey Yu and Michael Spang

Colin Blundell added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Colin Blundell . resolved

Thanks, Jeffrey! IIUC we were going to pause this effort pending the discussion on cxx?

Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
  • Michael Spang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia025e7c0aa3590c2d4e7fb54e2f1ebd741b71549
Gerrit-Change-Number: 7576696
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 08:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Feb 19, 2026, 11:45:59 AM (22 hours ago) Feb 19
to Colin Blundell, Code Review Nudger, Michael Spang, AyeAye, Chromium LUCI CQ, ozone-...@chromium.org
Attention needed from Colin Blundell and Michael Spang

Jeffrey Yu added 1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks, Jeffrey! IIUC we were going to pause this effort pending the discussion on cxx?

Jeffrey Yu

The feedback I got while filing the LSC was that any pending or in-flight CLs I had were fine to finish up.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Michael Spang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia025e7c0aa3590c2d4e7fb54e2f1ebd741b71549
Gerrit-Change-Number: 7576696
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 16:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
3:11 AM (7 hours ago) 3:11 AM
to Jeffrey Yu, Colin Blundell, Code Review Nudger, Michael Spang, AyeAye, Chromium LUCI CQ, ozone-...@chromium.org
Attention needed from Jeffrey Yu and Michael Spang

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
  • Michael Spang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia025e7c0aa3590c2d4e7fb54e2f1ebd741b71549
Gerrit-Change-Number: 7576696
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 08:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages