ozone/evdev: Disable HeatmapPalmDetection flag and add toggle [chromium/src : main]
0 views
Skip to first unread message
Komal Sambranikar (xWF) (Gerrit)
Aug 7, 2026, 3:36:39 AM (6 days ago) Aug 7
to Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Henry Barnor, Kenneth Albanowski and Sean O'Brien
Komal Sambranikar (xWF) added 1 comment![]( "Open in Gerrit")
Commit Message
Line 10, Patchset 14:
removes the flag and permanently enables the underlying feature toHenry Barnor . resolved
Komal Sambranikar (xWF)This CL does not permanently enable the feature. Please update the body and the subject.
Other than that LGTM.
Done
Related details
Attention is currently required from:
- Harry Cutts
- Henry Barnor
- Kenneth Albanowski
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harry Cutts (Gerrit)
Aug 7, 2026, 9:49:42 AM (6 days ago) Aug 7
to Komal Sambranikar (xWF), Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Henry Barnor, Kenneth Albanowski, Komal Sambranikar (xWF) and Sean O'Brien
Harry Cutts added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 15 (Latest):
Harry Cutts . resolved
I'm not entirely sure why you want my input on this CL; I don't work on Chrome anymore and am not an owner of the flag
Commit Message
Line 14, Patchset 15 (Latest):
keeps it available for developers to enable(by setting it to true) locally when required in heatmap_palm_detector.h.Harry Cutts . unresolved
Nit: CL descriptions should be wrapped to 72 characters
Line 13, Patchset 15 (Latest):
This removes the code from production builds entirely, but
keeps it available for developers to enable(by setting it to true) locally when required in heatmap_palm_detector.h.Harry Cutts . unresolved
If the code isn't currently under development, is it actually worth keeping around? @hba...@chromium.org, what do you think?
Line 15, Patchset 15 (Latest):
Specific changes include:
- Removing the flag from chrome://flags (about_flags.cc).
- Cleaning up flag-metadata.json and fieldtrial_testing_config.json.
- Deleting the kEnableHeatmapPalmDetection feature definition
in features.cc and features.h.
- Replacing the base::FeatureList checks with an inline
constexpr bool in heatmap_palm_detector.h.Harry Cutts . unresolved
Nit: CL descriptions should focus on why changes are being made, not what they are, except to give a high-level overview. These bullet points are just unnecessarily restating the contents of the diff, and should be removed
Related details
Attention is currently required from:
- Henry Barnor
- Kenneth Albanowski
- Komal Sambranikar (xWF)
- Sean O'Brien
Komal Sambranikar (xWF) (Gerrit)
Aug 7, 2026, 10:50:19 AM (6 days ago) Aug 7
to Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Henry Barnor, Kenneth Albanowski and Sean O'Brien
Komal Sambranikar (xWF) added 2 comments![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 15:
keeps it available for developers to enable(by setting it to true) locally when required in heatmap_palm_detector.h.Harry Cutts . resolved
Nit: CL descriptions should be wrapped to 72 characters
Komal Sambranikar (xWF)
Done
Specific changes include:
- Removing the flag from chrome://flags (about_flags.cc).
- Cleaning up flag-metadata.json and fieldtrial_testing_config.json.
- Deleting the kEnableHeatmapPalmDetection feature definition
in features.cc and features.h.
- Replacing the base::FeatureList checks with an inline
constexpr bool in heatmap_palm_detector.h.Harry Cutts . resolved
Nit: CL descriptions should focus on why changes are being made, not what they are, except to give a high-level overview. These bullet points are just unnecessarily restating the contents of the diff, and should be removed
Komal Sambranikar (xWF)
Done. Updated the commit message and wrapped it to the 72-character limit.
Related details
Attention is currently required from:
- Harry Cutts
- Henry Barnor
- Kenneth Albanowski
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harry Cutts (Gerrit)
Aug 7, 2026, 10:51:43 AM (6 days ago) Aug 7
to Komal Sambranikar (xWF), Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Henry Barnor, Kenneth Albanowski and Sean O'Brien
Harry Cutts added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 16 (Latest):
Harry Cutts . resolved
Looks fine to me assuming Henry's OK with keeping the code around, but as I'm not on the team anymore I'll let those who are give the Code Review vote
Related details
Attention is currently required from:
Komal Sambranikar (xWF) (Gerrit)
Aug 7, 2026, 10:58:34 AM (6 days ago) Aug 7
to Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Henry Barnor, Kenneth Albanowski and Sean O'Brien
Komal Sambranikar (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Harry Cutts . resolved
Looks fine to me assuming Henry's OK with keeping the code around, but as I'm not on the team anymore I'll let those who are give the Code Review vote
Attention is currently required from:
- Harry Cutts
Komal Sambranikar (xWF) (Gerrit)
Aug 7, 2026, 11:15:58 AM (6 days ago) Aug 7
to Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Kenneth Albanowski, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Henry Barnor, Kenneth Albanowski and Sean O'Brien
Komal Sambranikar (xWF) added 1 comment![]( "Open in Gerrit")
Commit Message
Line 20, Patchset 14:
TEST=ozone_unittests, events_unittestsHenry Barnor . resolved
Komal Sambranikar (xWF)Please do hardware test on a Ciri device and update the Test footer.
Tested on a Ciri device!
Verified it both enabled and disabled, and it boots successfully with no crashes.
Related details
Attention is currently required from:
- Harry Cutts
- Henry Barnor
- Kenneth Albanowski
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenneth Albanowski (Gerrit)
Aug 7, 2026, 1:29:49 PM (6 days ago) Aug 7
to Komal Sambranikar (xWF), Harry Cutts, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Henry Barnor, Komal Sambranikar (xWF) and Sean O'Brien
Kenneth Albanowski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Harry Cutts
- Henry Barnor
- Komal Sambranikar (xWF)
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henry Barnor (Gerrit)
Aug 11, 2026, 3:37:39 AM (2 days ago) Aug 11
to Komal Sambranikar (xWF), Kenneth Albanowski, Harry Cutts, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts, Komal Sambranikar (xWF) and Sean O'Brien
Henry Barnor added 1 comment![]( "Open in Gerrit")
Commit Message
Line 13, Patchset 15:
This removes the code from production builds entirely, but
keeps it available for developers to enable(by setting it to true) locally when required in heatmap_palm_detector.h.Harry Cutts . unresolved
If the code isn't currently under development, is it actually worth keeping around? @hba...@chromium.org, what do you think?
Henry Barnor
Yes, we will want to enable this code to do some comparisons at least till we finish developing the equivalent in AL.
Related details
Attention is currently required from:
- Harry Cutts
Harry Cutts (Gerrit)
Aug 11, 2026, 5:36:11 AM (2 days ago) Aug 11
to Komal Sambranikar (xWF), Harry Cutts, Kenneth Albanowski, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Komal Sambranikar (xWF) and Sean O'Brien
Harry Cutts voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Komal Sambranikar (xWF)
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Komal Sambranikar (xWF) (Gerrit)
Aug 11, 2026, 5:40:24 AM (2 days ago) Aug 11
to Harry Cutts, Kenneth Albanowski, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Henry Barnor and Sean O'Brien
Komal Sambranikar (xWF) added 1 comment![]( "Open in Gerrit")
Commit Message
Line 13, Patchset 15:
This removes the code from production builds entirely, but
keeps it available for developers to enable(by setting it to true) locally when required in heatmap_palm_detector.h.Harry Cutts . resolved
Henry BarnorIf the code isn't currently under development, is it actually worth keeping around? @hba...@chromium.org, what do you think?
Yes, we will want to enable this code to do some comparisons at least till we finish developing the equivalent in AL.
Attention is currently required from:
- Henry Barnor
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Komal Sambranikar (xWF) (Gerrit)
Aug 11, 2026, 5:40:30 AM (2 days ago) Aug 11
to Harry Cutts, Kenneth Albanowski, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Henry Barnor and Sean O'Brien
Komal Sambranikar (xWF) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Aug 11, 2026, 6:29:15 AM (2 days ago) Aug 11
to Komal Sambranikar (xWF), Harry Cutts, Kenneth Albanowski, Henry Barnor, Sean O'Brien, Jingyuan Liang, Code Review Nudger, CrOS Platform Inputs Reviewers, Srikanth Rajagopalan (xWF), Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ozone/evdev: Disable HeatmapPalmDetection flag and add toggle
The `enable-heatmap-palm-detection` flag expired in M140.
This CL removes the flag, cleaned up from the UI and metadata
and disables the feature.
The flag is replaced with a `constexpr bool` set to false.
This removes the code from production builds entirely,
but keeps it available for developers to enable(by setting
it to true) locally when required in heatmap_palm_detector.h.
BUG=b:427494517
TEST=1. Deploy chrome to the DUT:
third_party/chromite/bin/deploy_chrome --build-dir=\
out_${BOARD}/Release --device=<DEVICE_IP>
2. Run ozone unittests:
./out_${BOARD}/Release/bin/run_ozone_unittests
--device=<DEVICE_IP>
3. Run events unittests:
./out_${BOARD}/Release/bin/run_events_unittests
--device=<DEVICE_IP>
Change-Id: I659aa81e49c4f7e68f061cb40a4e58130c5a58dc
Reviewed-by: Harry Cutts <hcu...@chromium.org>
Reviewed-by: Kenneth Albanowski <ken...@google.com>
Commit-Queue: Komal Sambranikar (xWF) <sambr...@google.com>
Cr-Commit-Position: refs/heads/main@{#1677090}
Files:
- M chrome/browser/about_flags.cc
- M chrome/browser/flag-metadata.json
- M chrome/browser/flag_descriptions.h
- M testing/variations/fieldtrial_testing_config.json
- M tools/metrics/histograms/enums.xml
- M ui/events/ozone/evdev/heatmap_palm_detector.h
- M ui/events/ozone/evdev/touch_event_converter_evdev.cc
- M ui/events/ozone/evdev/touch_filter/palm_detection_filter_factory.cc
- M ui/events/ozone/features.cc
- M ui/events/ozone/features.h
Change size: S
Delta: 10 files changed, 5 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenneth Albanowski, +1 by Harry Cutts
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages