Fix Minimize operation on Wayland [chromium/src : main]

0 views
Skip to first unread message

Patryk Chodur (Gerrit)

unread,
Dec 16, 2025, 8:16:15 AM12/16/25
to Orko Garai, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com
Attention needed from Orko Garai

Patryk Chodur voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Orko Garai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Orko Garai <or...@igalia.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:15:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Patryk Chodur (Gerrit)

unread,
Dec 16, 2025, 8:20:48 AM12/16/25
to Orko Garai, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com
Attention needed from Orko Garai

Patryk Chodur voted and added 1 comment

Votes added by Patryk Chodur

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Orko Garai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Orko Garai <or...@igalia.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 13:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Orko Garai (Gerrit)

unread,
Dec 16, 2025, 1:56:44 PM12/16/25
to Patryk Chodur, Eliot Courtney, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com
Attention needed from Eliot Courtney and Patryk Chodur

Orko Garai added 1 comment

Patchset-level comments
Orko Garai . resolved

Looks good to me, but nice to have another look by @edcou...@chromium.org

Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 18:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Orko Garai (Gerrit)

unread,
Jan 9, 2026, 9:14:22 AM (2 days ago) Jan 9
to Patryk Chodur, Eliot Courtney, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com
Attention needed from Eliot Courtney and Patryk Chodur

Orko Garai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 14:14:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Patryk Chodur (Gerrit)

unread,
Jan 9, 2026, 10:23:34 AM (2 days ago) Jan 9
to Orko Garai, Eliot Courtney, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com
Attention needed from Eliot Courtney

Patryk Chodur voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 15:23:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 9, 2026, 11:08:12 AM (2 days ago) Jan 9
to Patryk Chodur, Orko Garai, Eliot Courtney, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, pwa-com...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix Minimize operation on Wayland

On Wayland there's a race condition in which if a window is Minimized
and the configure event is triggered on a window but minimizing didn't
yet take place, the window changes state to normal and cancels the
minimize event.
Bug: 458599317
Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Commit-Queue: Patryk Chodur <pch...@google.com>
Reviewed-by: Orko Garai <or...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1566951}
Files:
  • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Orko Garai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I721bbb5c21892bf245abe37c3bc937f7ac3a0189
Gerrit-Change-Number: 7265065
Gerrit-PatchSet: 2
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages