Remove base::JSONReader::Read's default argument for parsing options [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Sep 29, 2025, 6:49:50 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Daniel Cheng . resolved

I will run this through the Mega-CQ once more tonight; the last run over the weekend was clean.

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ab28367bd00c0f53f8e432f8ee0dfbc5ee02440
Gerrit-Change-Number: 6992114
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 22:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 29, 2025, 7:30:27 PM (8 days ago) Sep 29
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

Got red bots.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Sep 2025 23:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Sep 30, 2025, 8:09:41 PM (7 days ago) Sep 30
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Daniel Cheng . resolved

PTAL, this should be good to go now. Hopefully :)

ios-catalyst was the only bot failing with build errors and I've sent a CL for those fixes

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ab28367bd00c0f53f8e432f8ee0dfbc5ee02440
Gerrit-Change-Number: 6992114
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Oct 2025 00:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Sep 30, 2025, 8:31:11 PM (7 days ago) Sep 30
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 00:30:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Oct 1, 2025, 1:36:10 AM (6 days ago) Oct 1
    to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Wed, 01 Oct 2025 05:35:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 1, 2025, 1:39:22 AM (6 days ago) Oct 1
    to Daniel Cheng, Lei Zhang, Akihiro Ota, Alexis Menard, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Mathias Bynens, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Zijie He, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy+...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ashleydp+fe...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, bhartmire+w...@google.com, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+fe...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+w...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-enterpris...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-setti...@google.com, crost...@chromium.org, dcheng+c...@chromium.org, dclasson+w...@google.com, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wa...@chromium.org, hsuregan+wa...@chromium.org, iwells...@chromium.org, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+wa...@google.com, jasonrhee+w...@google.com, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, lens-chrome...@google.com, longbowei+fe...@google.com, loyso...@chromium.org, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mercer...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, subresource-f...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wangdanny+fe...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xiangdongkong+...@google.com, xinghui...@chromium.org, xlythe+wa...@google.com, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, yyhyyh+fee...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove base::JSONReader::Read's default argument for parsing options

    Callers should be explicit if they need to opt into non-compliant JSON
    parsing that allows Chromium-specific extensions, e.g. comments.
    Bug: 446188265
    Change-Id: I9ab28367bd00c0f53f8e432f8ee0dfbc5ee02440
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1523324}
    Files:
    • M base/json/json_perftest.cc
    • M base/json/json_reader.h
    • M base/json/json_reader_unittest.cc
    • M base/json/json_value_converter_unittest.cc
    • M base/json/json_value_serializer_unittest.cc
    • M base/metrics/statistics_recorder_unittest.cc
    • M base/test/launcher/test_launcher_test_utils.cc
    • M base/test/trace_event_analyzer.cc
    • M base/trace_event/trace_config.cc
    • M base/trace_event/trace_config_unittest.cc
    Change size: L
    Delta: 10 files changed, 278 insertions(+), 171 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9ab28367bd00c0f53f8e432f8ee0dfbc5ee02440
    Gerrit-Change-Number: 6992114
    Gerrit-PatchSet: 7
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages