[//ui] Rename GpuMemoryBufferSupportX11 to GBMSupportX11 [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
Nov 27, 2025, 10:46:19 AM (4 days ago) Nov 27
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov

Colin Blundell voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
Gerrit-Change-Number: 7205958
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 15:46:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
Nov 27, 2025, 11:53:29 AM (4 days ago) Nov 27
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
    Gerrit-Change-Number: 7205958
    Gerrit-PatchSet: 2
    Gerrit-Owner: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Thu, 27 Nov 2025 16:53:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    Nov 28, 2025, 2:51:17 AM (3 days ago) Nov 28
    to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

    Colin Blundell voted and added 1 comment

    Votes added by Colin Blundell

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Colin Blundell . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
      Gerrit-Change-Number: 7205958
      Gerrit-PatchSet: 3
      Gerrit-Owner: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Comment-Date: Fri, 28 Nov 2025 07:51:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Colin Blundell (Gerrit)

      unread,
      Nov 28, 2025, 2:54:04 AM (3 days ago) Nov 28
      to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

      Colin Blundell voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
        Gerrit-Change-Number: 7205958
        Gerrit-PatchSet: 4
        Gerrit-Owner: Colin Blundell <blun...@chromium.org>
        Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
        Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
        Gerrit-Comment-Date: Fri, 28 Nov 2025 07:53:49 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Nov 28, 2025, 3:01:02 AM (3 days ago) Nov 28
        to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        2 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        [//ui] Rename GpuMemoryBufferSupportX11 to GBMSupportX11

        This class conceptually provides wrappers around GBM device access and
        functionality.
        Bypass-Check-License: Renamed files
        Bug: 404905709
        Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
        Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
        Commit-Queue: Colin Blundell <blun...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1551353}
        Files:
        • M ui/gfx/linux/BUILD.gn
        • R ui/gfx/linux/gbm_support_x11.cc
        • R ui/gfx/linux/gbm_support_x11.h
        • M ui/gl/BUILD.gn
        • M ui/ozone/platform/x11/BUILD.gn
        • M ui/ozone/platform/x11/ozone_platform_x11.cc
        • M ui/ozone/platform/x11/x11_surface_factory.cc
        Change size: M
        Delta: 7 files changed, 41 insertions(+), 42 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id91fae4aa9877ede5b67e7343fb44eaf7872a103
        Gerrit-Change-Number: 7205958
        Gerrit-PatchSet: 5
        Gerrit-Owner: Colin Blundell <blun...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
        Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages