Stop using base::TimeTicks::UnixEpoch in ozone touch filters [chromium/src : main]
0 views
Skip to first unread message
Helmut Januschka (Gerrit)
Jun 19, 2026, 9:11:33 AM (10 days ago) Jun 19
to Helmut Januschka, Harry Cutts, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Harry Cutts
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Helmut Januschka . resolved
this CL is part of the effort to get rid of UnixEpoch
this is mostly mechanical, and should not break things.
please let me know if you want me to address anything.
the full CL list: https://chromium-review.googlesource.com/q/hashtag:%22timeticks%22+(status:open%20OR%20status:merged)
Related details
Attention is currently required from:
- Harry Cutts
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harry Cutts (Gerrit)
Jun 19, 2026, 9:28:45 AM (10 days ago) Jun 19
to Helmut Januschka, CrOS Platform Inputs Reviewers, Harry Cutts, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from CrOS Platform Inputs Reviewers
Harry Cutts added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Harry Cutts . resolved
This isn't an area I'm very familiar with, so rerouting to the CrOS input team's review alias
Related details
Attention is currently required from:
- CrOS Platform Inputs Reviewers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jun 19, 2026, 9:31:01 AM (10 days ago) Jun 19
to Helmut Januschka, CrOS Platform Inputs Reviewers, Sean O'Brien, Harry Cutts, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Sean O'Brien
Message from gwsq![]( "Open in Gerrit")
WARNING: gwsq was unable to find a reviewer who is not on vacation. As a fallback, gwsq is ignoring vacations and assigning seob...@chromium.org.
Reviewer source(s):
seob...@chromium.org is from owner(chrome/chromeos/input/config/OWNERS.evdev)
Related details
Attention is currently required from:
- Sean O'Brien
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean O'Brien (Gerrit)
Jun 19, 2026, 1:08:28 PM (10 days ago) Jun 19
to Helmut Januschka, CrOS Platform Inputs Reviewers, Harry Cutts, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Helmut Januschka
Sean O'Brien voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jun 19, 2026, 1:15:41 PM (10 days ago) Jun 19
to Helmut Januschka, Sean O'Brien, CrOS Platform Inputs Reviewers, Harry Cutts, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Helmut Januschka voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 19, 2026, 1:45:08 PM (10 days ago) Jun 19
to Helmut Januschka, Sean O'Brien, CrOS Platform Inputs Reviewers, Harry Cutts, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Stop using base::TimeTicks::UnixEpoch in ozone touch filters
Use a default-constructed base::TimeTicks() for the palm filter's initial
sentinel and the tests' arbitrary reference timestamps.
Bug: 355423207
Change-Id: I48cabd0e5c9e3c8697e38dd1ca2b3def67e09d24
Commit-Queue: Helmut Januschka <hel...@januschka.com>
Reviewed-by: Sean O'Brien <seob...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649741}
Files:
- M ui/events/ozone/evdev/touch_filter/heatmap_palm_detection_filter_unittest.cc
- M ui/events/ozone/evdev/touch_filter/heuristic_stylus_palm_detection_filter.cc
- M ui/events/ozone/evdev/touch_filter/neural_stylus_palm_detection_filter_unittest.cc
- M ui/events/ozone/evdev/touch_filter/neural_stylus_palm_detection_filter_util_unittest.cc
Change size: S
Delta: 4 files changed, 17 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sean O'Brien
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages