Fix some UNSAFE_TODOs in drm_wrapper.cc [chromium/src : main]

0 views
Skip to first unread message

YISI YU (Gerrit)

unread,
Feb 2, 2026, 5:03:00 AMFeb 2
to Kramer Ge, Peter McNeeley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge and Peter McNeeley

YISI YU voted and added 1 comment

Votes added by YISI YU

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
YISI YU . resolved

Hello Kramer, hello Peter, ptal thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Peter McNeeley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
Gerrit-Change-Number: 7538893
Gerrit-PatchSet: 5
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 10:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter McNeeley (Gerrit)

unread,
Feb 2, 2026, 9:50:25 AMFeb 2
to YISI YU, Kramer Ge, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge and YISI YU

Peter McNeeley voted and added 1 comment

Votes added by Peter McNeeley

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Peter McNeeley . resolved

This looks good. Thank you for doing this.

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • YISI YU
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
Gerrit-Change-Number: 7538893
Gerrit-PatchSet: 5
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
Gerrit-Attention: YISI YU <hello...@gmail.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 14:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Feb 2, 2026, 12:43:06 PMFeb 2
to YISI YU, Peter McNeeley, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Peter McNeeley and YISI YU

Kramer Ge voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Peter McNeeley
  • YISI YU
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
    Gerrit-Change-Number: 7538893
    Gerrit-PatchSet: 5
    Gerrit-Owner: YISI YU <hello...@gmail.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-Reviewer: YISI YU <hello...@gmail.com>
    Gerrit-Attention: Peter McNeeley <peterm...@google.com>
    Gerrit-Attention: YISI YU <hello...@gmail.com>
    Gerrit-Comment-Date: Mon, 02 Feb 2026 17:43:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 2, 2026, 1:05:12 PMFeb 2
    to YISI YU, Kramer Ge, Peter McNeeley, AyeAye, chromium...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix some UNSAFE_TODOs in drm_wrapper.cc

    Use std::ranges::fill instead of memset. Use std::string_view for
    equality comparison instead of strcmp.
    Bug: 40285824
    Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
    Auto-Submit: YISI YU <hello...@gmail.com>
    Reviewed-by: Peter McNeeley <peterm...@google.com>
    Commit-Queue: Kramer Ge <fang...@chromium.org>
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1578221}
    Files:
    • M ui/ozone/platform/drm/common/drm_wrapper.cc
    Change size: S
    Delta: 1 file changed, 13 insertions(+), 9 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kramer Ge, +1 by Peter McNeeley
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
    Gerrit-Change-Number: 7538893
    Gerrit-PatchSet: 6
    Gerrit-Owner: YISI YU <hello...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-Reviewer: YISI YU <hello...@gmail.com>
    open
    diffy
    satisfied_requirement

    YISI YU (Gerrit)

    unread,
    Feb 2, 2026, 7:14:09 PMFeb 2
    to Chromium LUCI CQ, Peter McNeeley, AyeAye, chromium...@chromium.org, ozone-...@chromium.org

    YISI YU added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    YISI YU . resolved

    Thanks for reviewing!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic452b0c5c9ffea41ab8eed5cab1b161411ee742e
    Gerrit-Change-Number: 7538893
    Gerrit-PatchSet: 6
    Gerrit-Owner: YISI YU <hello...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-Reviewer: YISI YU <hello...@gmail.com>
    Gerrit-Comment-Date: Tue, 03 Feb 2026 00:13:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages