[ozone/wayland]Treat xdg_toplevel::state::suspended as minimized [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Mar 3, 2026, 11:40:58 AM (10 days ago) Mar 3
to Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Message from Kramer Ge

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
Gerrit-Change-Number: 7625941
Gerrit-PatchSet: 2
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 16:40:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Mar 3, 2026, 1:52:40 PM (10 days ago) Mar 3
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Thomas Anderson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
    Gerrit-Change-Number: 7625941
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 18:52:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Mar 3, 2026, 2:54:04 PM (10 days ago) Mar 3
    to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Kramer Ge voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
    Gerrit-Change-Number: 7625941
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 19:53:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 3, 2026, 2:57:18 PM (10 days ago) Mar 3
    to Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [ozone/wayland]Treat xdg_toplevel::state::suspended as minimized

    minimized was a state used by chromium aura-shell extension for lacros,
    it is now unreachable. Linux Wayland compositors (KDE and GNOME) send
    xdg_toplevel::state::suspended when minimizing a window, use it to set
    window state to minimized instead.

    R=thomasanderson
    Fixed: 459509272
    Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
    Commit-Queue: Kramer Ge <fang...@chromium.org>
    Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1593405}
    Files:
    • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
    • M ui/ozone/platform/wayland/host/wayland_window.cc
    • M ui/ozone/platform/wayland/host/wayland_window.h
    • M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
    Change size: XS
    Delta: 4 files changed, 2 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Thomas Anderson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
    Gerrit-Change-Number: 7625941
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages