Fred Shih (Gerrit)

unread,

Feb 4, 2026, 9:02:10 PMFeb 4

to Kevin McNee, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Kevin McNee and Mitsuru Oshima

Fred Shih added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Fred Shih . resolved

@kevin, I will update the docs once we have a simpler API.

Open in Gerrit

Related details

Attention is currently required from:

Kevin McNee
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

Feb 4, 2026, 9:12:03 PMFeb 4

to Kevin McNee, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Kevin McNee and Mitsuru Oshima

Fred Shih added 1 comment

File ui/ozone/public/ozone_platform.cc

Line 124, Patchset 1: return GetOzonePlatformName() == "wayland";

Fred Shih . unresolved

@oshima: I think this is a bit of an abstraction leak, but maybe ok for test if it's just a string?

Open in Gerrit

Related details

Attention is currently required from:

Kevin McNee
Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Feb 5, 2026, 12:52:43 PMFeb 5

to Fred Shih, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Fred Shih and Kevin McNee

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Code-Review

+1

1 comment

File ui/ozone/public/ozone_platform.cc

Line 124, Patchset 1: return GetOzonePlatformName() == "wayland";

Fred Shih . unresolved

@oshima: I think this is a bit of an abstraction leak, but maybe ok for test if it's just a string?

Mitsuru Oshima

If we don't need this runtime check in production code, then ok. That's being said, I'd be better to use PlatformProperties and enable/disable based on the feature underlying wayland supports. (e.g. supports_global_screen_coordinates).

If we keep this in the test, I'd prefer a name like "RunsOnWaylandForTes" rather than "IsWaylandForTest" to be more specific.

Open in Gerrit

Related details

Attention is currently required from:

Fred Shih
Kevin McNee

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

Feb 5, 2026, 4:41:07 PMFeb 5

to Tom Lukaszewicz, Mitsuru Oshima, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Kevin McNee and Tom Lukaszewicz

Fred Shih added 1 comment

File ui/ozone/public/ozone_platform.cc

Line 124, Patchset 1: return GetOzonePlatformName() == "wayland";

Fred Shih . resolved

@oshima: I think this is a bit of an abstraction leak, but maybe ok for test if it's just a string?

Mitsuru Oshima

If we don't need this runtime check in production code, then ok. That's being said, I'd be better to use PlatformProperties and enable/disable based on the feature underlying wayland supports. (e.g. supports_global_screen_coordinates).

If we keep this in the test, I'd prefer a name like "RunsOnWaylandForTes" rather than "IsWaylandForTest" to be more specific.

Fred Shih

I think I'd prefer to stick with this. I'm pretty sure most of the users are going to be build gardeners who probably won't have time to figure out which features implies wayland. Renamed (but changed it to RunningOnWaylandForTest), thanks!

Open in Gerrit

Related details

Attention is currently required from:

Kevin McNee
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

Feb 5, 2026, 4:41:21 PMFeb 5

to Tom Lukaszewicz, Mitsuru Oshima, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Kevin McNee and Tom Lukaszewicz

Fred Shih added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Fred Shih . resolved

I need your owners power tluk@!

Open in Gerrit

Related details

Attention is currently required from:

Kevin McNee
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin McNee (Gerrit)

unread,

Feb 5, 2026, 4:55:12 PMFeb 5

to Fred Shih, Tom Lukaszewicz, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Fred Shih and Tom Lukaszewicz

Kevin McNee voted and added 2 comments

Votes added by Kevin McNee

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kevin McNee . resolved

LGTM, thanks.

Commit Message

Line 7, Patchset 2:Introduce a static function to determine is ozone is wayland in test

Kevin McNee . unresolved

if

Open in Gerrit

Related details

Attention is currently required from:

Fred Shih
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Introduce a static function to determine is ozone is wayland in test [chromium/src : main]

Fred Shih (Gerrit)

Fred Shih added 1 comment

Related details

Fred Shih (Gerrit)

Fred Shih added 1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

1 comment

Related details

Fred Shih (Gerrit)

Fred Shih added 1 comment

Related details

Fred Shih (Gerrit)

Fred Shih added 1 comment

Related details

Kevin McNee (Gerrit)

Kevin McNee voted and added 2 comments

Votes added by Kevin McNee

2 comments

Related details